Allow this.getState references (not calls) in lifecycle methods. #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this should not be considered an error/warning by this rule: (my actual code follows)
While I don't know that this is great code per se, it is essentially binding
setState
to a list of Flux stores via a helper (dependencies
). This seems to me like a valid use ofsetState
withincomponentDidMount
.I refactored both rules pertaining to
setState
to respond toCallExpression
nodes instead ofMemberExpression
, and it returns if thecallee
is not aMemberExpression
. The original logic follows thereafter.I can imagine also potentially making this reduction in strength an option, but I believe the behavior here captures the spirit of the rule, and thus an option should not be necessary.
Submitted for your consideration. 👍