Skip to content

[no-unused-prop-types] known false positives doc #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2017
Merged

[no-unused-prop-types] known false positives doc #1344

merged 1 commit into from
Aug 6, 2017

Conversation

DianaSuvorova
Copy link
Contributor

No description provided.

ljharb
ljharb requested changes Aug 5, 2017
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! After these changes, could you squash these down to a single commit?

docs/rules/no-unused-prop-types.md Outdated
```js
class AComponent extends React.Component {
render() {
const { props } = this.props;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const { props } = this;?

docs/rules/no-unused-prop-types.md Outdated

```js
class AComponent extends React.Component {
const { aProp } = this.props.aProp;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const { aProp } = this.props;

@DianaSuvorova
Copy link
Contributor Author

Done. Thanks

@ljharb ljharb merged commit e305279 into jsx-eslint:master Aug 6, 2017
@dependencies dependencies bot mentioned this pull request Aug 25, 2017
Open
@renovate renovate bot mentioned this pull request Feb 2, 2018
Open
1 task
This was referenced Sep 22, 2018
Closed
Closed
Open
Open
Open
Open
Open
This was referenced Oct 25, 2018
Merged
Open
@renovate renovate bot mentioned this pull request Nov 7, 2018
Merged
@renovate renovate bot mentioned this pull request Nov 23, 2018
Open
1 task
@renovate renovate bot mentioned this pull request Dec 5, 2018
Closed
1 task
@mesosphere-web mesosphere-web mentioned this pull request Dec 19, 2018
Closed
1 task
This was referenced Jan 8, 2019
Closed
Merged
This was referenced Sep 3, 2024
Merged
Open
@renovate renovate bot mentioned this pull request Sep 12, 2024
Open
1 task
This was referenced Oct 3, 2024
Open
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
documentation
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DianaSuvorova @ljharb