ESLint check fails after upgrading to 5.2.0 - 'Cannot read property 'name' of undefined'

[dorsha]

Getting the following error after upgrading from 5.1.1 to 5.2.0:

This is a bit a blocker since our build fails.

Any idea?

[yannickcr]

Can you post the source code that trigger the crash? I will try to quickly push a bugfix release.

[dorsha]

I don't know which part of my code cause this error. I ran eslint for the entire repository and got the error.
I also tried on a single file and got the same error.

https://github.com/yannickcr/eslint-plugin-react/blob/master/lib/rules/jsx-no-bind.js#L23
Seems that callee.property is undefined.

This is the stacktrace:

Cannot read property 'name' of undefined
TypeError: Cannot read property 'name' of undefined
    at EventEmitter.CallExpression (/Users/dorsha/dev/demisto/web-client/node_modules/eslint-plugin-react/lib/rules/jsx-no-bind.js:23:24)
    at emitOne (events.js:101:20)
    at EventEmitter.emit (events.js:188:7)
    at NodeEventGenerator.enterNode (/Users/dorsha/dev/demisto/web-client/node_modules/eslint/lib/util/node-event-generator.js:40:22)
    at CodePathAnalyzer.enterNode (/Users/dorsha/dev/demisto/web-client/node_modules/eslint/lib/code-path-analysis/code-path-analyzer.js:607:23)
    at CommentEventGenerator.enterNode (/Users/dorsha/dev/demisto/web-client/node_modules/eslint/lib/util/comment-event-generator.js:97:23)
    at Controller.traverser.traverse.enter (/Users/dorsha/dev/demisto/web-client/node_modules/eslint/lib/eslint.js:905:36)
    at Controller.__execute (/Users/dorsha/dev/demisto/web-client/node_modules/estraverse/estraverse.js:397:31)
    at Controller.traverse (/Users/dorsha/dev/demisto/web-client/node_modules/estraverse/estraverse.js:501:28)
    at Controller.Traverser.controller.traverse (/Users/dorsha/dev/demisto/web-client/node_modules/eslint/lib/util/traverser.js:36:33)

[yannickcr]

I also tried on a single file and got the same error.

Well if you could isolate the piece of code in this file that trigger this error it will be very helpful for me to write a proper test case and a proper fix.

Thanks for your help 😃

[aviadl]

Here you are
import React, { Component, PropTypes } from 'react';
import { connect } from 'react-redux';

class ErrorExample extends Component {

render() {
return ;
}
}

export default connect()(ErrorExample);

[dorsha]

No Error:

import React, { Component } from 'react';
import { connect } from 'react-redux';

class ErrorExample extends Component {

  render() {
    return <div></div>;
  }
}

export default ErrorExample;

Error:

import React, { Component } from 'react';
import { connect } from 'react-redux';

class ErrorExample extends Component {

  render() {
    return <div></div>;
  }
}

export default connect()(ErrorExample);

This cause an error as well:

import React, { Component } from 'react';
import { injectIntl } from 'react-intl';

class ErrorExample extends Component {

  render() {
    return <div></div>;
  }
}

export default injectIntl(ErrorExample);

[dorsha]

Redux actions error:

import * as Api from '../util/api';

function updateTest(res) {
  return {
    type: 'TEST_TYPE',
    payload: res
  };
}

export function test() {
  return dispatch => {
    Api.post('/test', {})
      .then((res) => {
        dispatch(updateTest(res));
      });
  };
}

When removing the dispatch(updateTest(res)); line, the error disappears...

[dorsha]

Our ESLint dependencies:

[Odywan55]

Any fixes?

[yannickcr]

Working on it

[Odywan55]

Thanks a lot !

[yannickcr]

Thanks for your help, it should now be fixed in v5.2.2

[dorsha]

Yup, fixed.
Thanks for the quick response.