Skip to content

Commit f7fb96b

Browse files
committed
Fix void-dom-elements-no-children crash on faulty createElement detection (fixes #1101)
1 parent f111e45 commit f7fb96b

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

lib/rules/void-dom-elements-no-children.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ module.exports = {
9898
return;
9999
}
100100

101-
if (!utils.hasDestructuredReactCreateElement() && !utils.isReactCreateElement(node)) {
101+
if (!utils.isReactCreateElement(node)) {
102102
return;
103103
}
104104

tests/lib/rules/void-dom-elements-no-children.js

+13
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,19 @@ ruleTester.run('void-dom-elements-no-children', rule, {
6767
'createElement("img")'
6868
].join('\n'),
6969
parser: 'babel-eslint'
70+
}, {
71+
code: [
72+
'import React, {createElement, PureComponent} from \'react\';',
73+
'class Button extends PureComponent {',
74+
' handleClick = ev => {',
75+
' ev.preventDefault();',
76+
' }',
77+
' render() {',
78+
' return <div onClick={this.handleClick}>Hello</div>;',
79+
' }',
80+
'}'
81+
].join('\n'),
82+
parser: 'babel-eslint'
7083
}
7184
],
7285
invalid: [

0 commit comments

Comments
 (0)