Skip to content

Commit 66c0d66

Browse files
committed
[Fix] displayName (but really, propTypes detection): do not crash on empty flow type spreads
Fixes #2570.
1 parent 0a717a5 commit 66c0d66

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

lib/util/ast.js

+3
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,9 @@ function getKeyValue(context, node) {
168168
if (node.type === 'GenericTypeAnnotation') {
169169
return node.id.name;
170170
}
171+
if (node.type === 'ObjectTypeAnnotation') {
172+
return;
173+
}
171174
const key = node.key || node.argument;
172175
return key.type === 'Identifier' ? key.name : key.value;
173176
}

tests/lib/rules/display-name.js

+7
Original file line numberDiff line numberDiff line change
@@ -482,6 +482,13 @@ ruleTester.run('display-name', rule, {
482482
return <div>{items}</div>;
483483
}
484484
`
485+
}, {
486+
code: `
487+
import {Component} from "react";
488+
type LinkProps = {...{}};
489+
class Link extends Component<LinkProps> {}
490+
`,
491+
parser: parsers.BABEL_ESLINT
485492
}],
486493

487494
invalid: [{

0 commit comments

Comments
 (0)