Add additional serialization test cases for additional and pattern properties

Author: wol-soft

tests/PostProcessor/AdditionalPropertiesAccessorPostProcessorTest.php

@@ -16,6 +16,7 @@
 use PHPModelGenerator\ModelGenerator;
 use PHPModelGenerator\SchemaProcessor\Hook\SetterBeforeValidationHookInterface;
 use PHPModelGenerator\SchemaProcessor\PostProcessor\AdditionalPropertiesAccessorPostProcessor;
+use PHPModelGenerator\SchemaProcessor\PostProcessor\PopulatePostProcessor;
 use PHPModelGenerator\SchemaProcessor\PostProcessor\PostProcessor;
 use PHPModelGenerator\Tests\AbstractPHPModelGeneratorTest;
 
@@ -405,6 +406,66 @@ public function testAdditionalPropertiesAreSerialized(bool $implicitNull): void
         $this->assertNull($this->getParameterType($object, 'setAdditionalProperty', 1));
     }
 
+
+    public function testAdditionalPropertiesAreSerializedWithoutAdditionalPropertiesAccessorPostProcessor(): void
+    {
+        $this->modifyModelGenerator = function (ModelGenerator $generator): void {
+            $generator->addPostProcessor(new PopulatePostProcessor());
+        };
+
+        $className = $this->generateClassFromFile(
+            'AdditionalPropertiesTransformingFilter.json',
+            (new GeneratorConfiguration())->setSerialization(true)
+        );
+
+        $object = new $className(['name' => 'Late autumn', 'start' => '2020-10-10']);
+        $this->assertEqualsCanonicalizing(['name' => 'Late autumn', 'start' => '20201010'], $object->toArray());
+
+        $object->populate(['end' => '20201212']);
+        $this->assertEqualsCanonicalizing(
+            ['name' => 'Late autumn', 'start' => '20201010', 'end' => '20201212'],
+            $object->toArray()
+        );
+    }
+
+    public function testAdditionalPropertiesAreNotSerializedWhenNotDefinedWithoutExplicitAccessorMethods(): void
+    {
+        $this->modifyModelGenerator = function (ModelGenerator $generator): void {
+            $generator->addPostProcessor(new PopulatePostProcessor());
+        };
+
+        $className = $this->generateClassFromFile(
+            'AdditionalPropertiesNotDefined.json',
+            (new GeneratorConfiguration())->setSerialization(true)
+        );
+
+        $object = new $className(['a' => 1, 'b' => 2]);
+        $this->assertSame([], $object->toArray());
+
+        $object->populate(['a' => 3, 'c' => 4]);
+        $this->assertSame([], $object->toArray());
+    }
+
+    public function testAdditionalPropertiesAreSerializedWhenNotDefinedWithExplicitAccessorMethods(): void
+    {
+        $this->modifyModelGenerator = function (ModelGenerator $generator): void {
+            $generator
+                ->addPostProcessor(new PopulatePostProcessor())
+                ->addPostProcessor(new AdditionalPropertiesAccessorPostProcessor(true));
+        };
+
+        $className = $this->generateClassFromFile(
+            'AdditionalPropertiesNotDefined.json',
+            (new GeneratorConfiguration())->setSerialization(true)
+        );
+
+        $object = new $className(['a' => 1, 'b' => 2]);
+        $this->assertEqualsCanonicalizing(['a' => 1, 'b' => 2], $object->toArray());
+
+        $object->populate(['a' => 3, 'c' => 4]);
+        $this->assertEqualsCanonicalizing(['a' => 3, 'b' => 2, 'c' => 4], $object->toArray());
+    }
+
     public function testMultiTypeAdditionalProperties(): void
     {
         $this->addPostProcessor(true);

tests/PostProcessor/PatternPropertiesAccessorPostProcessorTest.php

@@ -249,19 +249,42 @@ public function testModifyingPatternPropertiesViaPopulate(): void
             $object->getPatternProperties('^b')
         );
         $this->assertSame(['c1' => 'World'], $object->getAdditionalProperties());
-        $this->assertEqualsCanonicalizing(
-            [
-                'a0' => 100,
-                'a1' => -10,
-                'a2' => 10,
-                'b1' => 'Hello',
-                'b2' => 'World',
-                'c1' => 'World',
-                'alpha' => 100,
-                'beta' => null,
-            ],
-            $object->toArray()
+
+        $state = [
+            'a0' => 100,
+            'a1' => -10,
+            'a2' => 10,
+            'b1' => 'Hello',
+            'b2' => 'World',
+            'c1' => 'World',
+            'alpha' => 100,
+            'beta' => null,
+        ];
+        $this->assertEqualsCanonicalizing($state, $object->toArray());
+
+        // make sure the pattern properties are not changed when a validation error occurs
+        try {
+            $object->populate(['a0' => 50, 'a1' => 60, 'beta' => false]);
+            $this->fail('Exception not thrown');
+        } catch (Exception $exception) {
+            $this->assertEqualsCanonicalizing($state, $object->toArray());
+        }
+    }
+
+    public function testPatternPropertiesAreSerializedWithoutPatternPropertiesAccessorPostProcessor(): void
+    {
+        $this->addPostProcessors(new PopulatePostProcessor());
+
+        $className = $this->generateClassFromFile(
+            'PatternProperties.json',
+            (new GeneratorConfiguration())->setSerialization(true)
         );
+
+        $object = new $className(['a0' => 100]);
+        $this->assertEqualsCanonicalizing(['alpha' => null, 'beta' => null, 'a0' => 100], $object->toArray());
+
+        $object->populate(['alpha' => 30, 'a0' => 10, 'a1' => 20]);
+        $this->assertEqualsCanonicalizing(['alpha' => 30, 'beta' => null, 'a0' => 10, 'a1' => 20], $object->toArray());
     }
 
     /**