drop pretty printing option

Author: wol-soft

README.md

@@ -160,8 +160,8 @@ The class generation process basically splits up into three to four steps:
 
 - Scan the given source directory to find all *.json files which should be processed.
 - Loop over all schemas which should be generated. This is the main step of the class generation. Now each schema is parsed and a Schema model class which holds the properties for the generated model is populated. All validation rules defined in the JSON-Schema are translated into plain PHP code. After the model is finished a RenderJob is generated and added to the RenderQueue. If a JSON-Schema contains nested objects or references multiple RenderJobs may be added to the RenderQueue for a given schema file.
+- If post processors are defined for the generation process the post processors will be applied.
 - After all schema files have been parsed without an error the RenderQueue will be worked off. All previous added RenderJobs will be executed and the PHP classes will be saved to the filesystem at the given destination directory.
-- If pretty printing is enabled the generated PHP classes will be cleaned up for a better code formatting. Done.
 
 ## Tests ##
 

composer.json

@@ -21,9 +21,6 @@
     "require-dev": {
         "phpunit/phpunit": "^8.5 || ^9.4"
     },
-    "suggest": {
-        "symplify/easy-coding-standard": "Allows pretty printing of the generated code"
-    },
     "autoload": {
         "psr-4": {
             "PHPModelGenerator\\": "src"

docs/source/examples.rst

@@ -25,4 +25,4 @@ The Ebay OpenAPIv3 spec for the sell-inventory API is an around 6000 lines API d
         ->generateModelDirectory($resultDir)
         ->generateModels(new OpenAPIv3Provider($file), $resultDir);
 
-Measured runtime of the script (Pretty printing is disabled) is around 3 seconds at a memory peak consumption between 5 and 6 MB.
+Measured runtime of the script is around 3 seconds at a memory peak consumption between 5 and 6 MB.

docs/source/gettingStarted.rst

@@ -254,24 +254,6 @@ If you want to customize the exception handling you can set an own ErrorRegistry
     (new GeneratorConfiguration())
         ->setErrorRegistryClass(MyCustomException::class);
 
-Code style of the generated classes
-^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-
-.. code-block:: php
-
-    setPrettyPrint(bool $prettyPrint);
-
-If set to false, the generated model classes won't follow coding guidelines (but the generation is faster). If enabled the package `Symplify/EasyCodingStandard <https://github.com/Symplify/EasyCodingStandard>`_ will be used to clean up the generated code. By default pretty printing is disabled.
-
-.. code-block:: php
-
-    (new GeneratorConfiguration())
-        ->setPrettyPrint(true);
-
-.. warning::
-
-    The ECS package must be installed manually: `composer require --dev symplify/easy-coding-standard`
-
 Serialization methods
 ^^^^^^^^^^^^^^^^^^^^^
 

src/Model/GeneratorConfiguration.php

@@ -33,8 +33,6 @@ class GeneratorConfiguration
     /** @var bool */
     protected $denyAdditionalProperties = false;
     /** @var bool */
-    protected $prettyPrint = false;
-    /** @var bool */
     protected $outputEnabled = true;
     /** @var bool */
     protected $collectErrors = true;
@@ -255,26 +253,6 @@ public function setDenyAdditionalProperties(bool $denyAdditionalProperties): sel
         return $this;
     }
 
-    /**
-     * @return bool
-     */
-    public function hasPrettyPrintEnabled(): bool
-    {
-        return $this->prettyPrint;
-    }
-
-    /**
-     * @param bool $prettyPrint
-     *
-     * @return $this
-     */
-    public function setPrettyPrint(bool $prettyPrint): self
-    {
-        $this->prettyPrint = $prettyPrint;
-
-        return $this;
-    }
-
     /**
      * @return bool
      */

src/ModelGenerator.php

@@ -128,13 +128,6 @@ public function generateModels(SchemaProviderInterface $schemaProvider, string $
         // render all collected classes
         $renderQueue->execute($this->generatorConfiguration, $this->postProcessors);
 
-        if ($this->generatorConfiguration->hasPrettyPrintEnabled()) {
-            // @codeCoverageIgnoreStart
-            $out = $this->generatorConfiguration->isOutputEnabled() ? '' : '2>&1';
-            shell_exec(__DIR__ . "/../vendor/bin/ecs check $destination --config " . __DIR__ . "/cs.yml --fix $out");
-            // @codeCoverageIgnoreEnd
-        }
-
         return $schemaProcessor->getGeneratedFiles();
     }
 }

src/cs.yml

@@ -213,7 +213,6 @@ protected function generateClass(
         string $schemaProviderClass = RecursiveDirectoryProvider::class
     ): string {
         $generatorConfiguration = ($generatorConfiguration ?? (new GeneratorConfiguration())->setCollectErrors(false))
-            ->setPrettyPrint(false)
             ->setImplicitNull($implicitNull)
             ->setOutputEnabled(false);