Skip to content

Commit 35b0774

Browse files
authored
revert Fix bugs in type (#1807) (#1820)
1 parent bc6f681 commit 35b0774

File tree

1 file changed

+27
-29
lines changed

1 file changed

+27
-29
lines changed

index.d.ts

+27-29
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ declare namespace winston {
5858
[optionName: string]: any;
5959
}
6060

61-
interface LogMethod {
61+
interface LogMethod {
6262
(level: string, message: string, callback: LogCallback): Logger;
6363
(level: string, message: string, meta: any, callback: LogCallback): Logger;
6464
(level: string, message: string, ...meta: any[]): Logger;
@@ -74,8 +74,8 @@ declare namespace winston {
7474
(infoObject: object): Logger;
7575
}
7676

77-
interface LoggerOptions<T extends Config.AbstractConfigSetLevels = Config.AbstractConfigSetLevels> {
78-
levels?: T;
77+
interface LoggerOptions {
78+
levels?: Config.AbstractConfigSetLevels;
7979
silent?: boolean;
8080
format?: logform.Format;
8181
level?: string;
@@ -86,32 +86,10 @@ declare namespace winston {
8686
exceptionHandlers?: any;
8787
}
8888

89-
type DefaultLevels = {
90-
// for cli and npm levels
91-
error: number;
92-
warn: number;
93-
help: number;
94-
data: number;
95-
info: number;
96-
debug: number;
97-
prompt: number;
98-
http: number;
99-
verbose: number;
100-
input: number;
101-
silly: number;
102-
103-
// for syslog levels only
104-
emerg: number;
105-
alert: number;
106-
crit: number;
107-
warning: number;
108-
notice: number;
109-
}
110-
111-
type Logger<T extends Config.AbstractConfigSetLevels = DefaultLevels> = NodeJSStream.Transform & {
89+
interface Logger extends NodeJSStream.Transform {
11290
silent: boolean;
11391
format: logform.Format;
114-
levels: T;
92+
levels: Config.AbstractConfigSetLevels;
11593
level: string;
11694
transports: Transport[];
11795
exceptions: ExceptionHandler;
@@ -125,6 +103,26 @@ declare namespace winston {
125103
clear(): Logger;
126104
close(): Logger;
127105

106+
// for cli and npm levels
107+
error: LeveledLogMethod;
108+
warn: LeveledLogMethod;
109+
help: LeveledLogMethod;
110+
data: LeveledLogMethod;
111+
info: LeveledLogMethod;
112+
debug: LeveledLogMethod;
113+
prompt: LeveledLogMethod;
114+
http: LeveledLogMethod;
115+
verbose: LeveledLogMethod;
116+
input: LeveledLogMethod;
117+
silly: LeveledLogMethod;
118+
119+
// for syslog levels only
120+
emerg: LeveledLogMethod;
121+
alert: LeveledLogMethod;
122+
crit: LeveledLogMethod;
123+
warning: LeveledLogMethod;
124+
notice: LeveledLogMethod;
125+
128126
query(options?: QueryOptions, callback?: (err: Error, results: any) => void): any;
129127
stream(options?: any): NodeJS.ReadableStream;
130128

@@ -144,7 +142,7 @@ declare namespace winston {
144142
isSillyEnabled(): boolean;
145143

146144
new(options?: LoggerOptions): Logger;
147-
} & {[K in keyof T]: LeveledLogMethod;}
145+
}
148146

149147
interface Container {
150148
loggers: Map<string, Logger>;
@@ -164,7 +162,7 @@ declare namespace winston {
164162
let loggers: Container;
165163

166164
let addColors: (target: Config.AbstractConfigSetColors) => any;
167-
let createLogger: <T extends Config.AbstractConfigSetLevels = DefaultLevels>(options?: LoggerOptions<T>) => Logger<T>;
165+
let createLogger: (options?: LoggerOptions) => Logger;
168166

169167
// Pass-through npm level methods routed to the default logger.
170168
let error: LeveledLogMethod;

0 commit comments

Comments
 (0)