Skip to content
This repository was archived by the owner on Sep 2, 2020. It is now read-only.

Commit 8689c67

Browse files
niedzielskiniedzielski
committed
Chore: replace Rollup.js bundler with Webpack
- This initial Webpack refactor patch aims for parity with the previous Rollup.js implementation. The configuration was largely derived from project Marvin. There are many enhancements possible with the new configuration but an effort to keep changes minimal where practical was made. For example, subsequent patches may diversify the library entry points offered, automatically vendor prefix all CSS, or inline image assets as data URIs. https://phabricator.wikimedia.org/source/marvin/browse/master/ - The unusual Rollup.js Babel configuration is simplified and consolidated at the project root. - An empty PostCSS configuration is included for later auto-vendor prefixing. - The JavaScript and CSS artifacts have been minimized in production builds. Notably, the JavaScript build product is now half what it was. - A superfluous entry, build/wikimedia-page-library-override.js, is now generated and may safely be ignored. This is noted in the readme. webpack-contrib/extract-text-webpack-plugin#518 - All demo URLs have been updated to reference webpack-dev-server outputs. - There are no anticipated client changes necessary but integrators should smoke test CSS and JavaScript functionality, especially on older devices. - The NPM clean script has been removed as this is part of the build process provided by Webpack and the "Clean for WebPack" plugin. - The build:watch NPM script is preserved to retain existing app developer workflows. App devs should verify that their processes are unaltered.
1 parent a6fbf09 commit 8689c67

18 files changed

+11774
-5767
lines changed

‎.babelrc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"presets": [["env", {"targets": { "android": "4.4", "ios": "10.3" }}]]
3+
}

‎.postcssrc.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
{}

‎changelog.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
### v4.9.1
2+
- Chore: replace Rollup.js bundler with Webpack; there are no anticipated client changes necessary but integrators should smoke test CSS and JavaScript functionality, especially on older devices, and app devs should verify their development workflows
3+
14
### v4.9.0
25
- New: consolidated 1st paragraph relocation transform
36

‎demo/DimImagesTransform.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,15 @@
44
<head>
55
<meta charset=utf-8>
66
<title>DimImagesTransform</title>
7-
<link href=../build/wikimedia-page-library-transform.css rel=stylesheet>
7+
<link href=http://localhost:8080/wikimedia-page-library-transform.css rel=stylesheet>
88
<style>
99
:root {
1010
--control-panel-theme-visibility: visible;
1111
}
1212
body, img, input { margin: 14px; }
1313
</style>
1414
<script src=https://polygit.org/components/webcomponentsjs/webcomponents-loader.js></script>
15-
<script src=build/wikimedia-page-library-transform.js></script>
15+
<script src=http://localhost:8080/wikimedia-page-library-transform.js></script>
1616
<link rel=import href=ControlPanel.html>
1717
</head>
1818

‎demo/EditTransform.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<head>
55
<meta charset=utf-8>
66
<title>EditTransform</title>
7-
<link href=../build/wikimedia-page-library-transform.css rel=stylesheet>
7+
<link href=http://localhost:8080/wikimedia-page-library-transform.css rel=stylesheet>
88
<style>
99
:root {
1010
--control-panel-platform-visibility: visibile;
@@ -21,7 +21,7 @@
2121
}
2222
</style>
2323
<script src=https://polygit.org/components/webcomponentsjs/webcomponents-loader.js></script>
24-
<script src=build/wikimedia-page-library-transform.js></script>
24+
<script src=http://localhost:8080/wikimedia-page-library-transform.js></script>
2525
<link rel=import href=ControlPanel.html>
2626
</head>
2727

‎demo/FooterTransformer.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<head>
55
<meta charset=utf-8>
66
<title>FooterTransform</title>
7-
<link href=../build/wikimedia-page-library-transform.css rel=stylesheet>
7+
<link href=http://localhost:8080/wikimedia-page-library-transform.css rel=stylesheet>
88
<style>
99
:root {
1010
--control-panel-platform-visibility: visible;
@@ -23,7 +23,7 @@
2323
}
2424
</style>
2525
<script src=https://polygit.org/components/webcomponentsjs/webcomponents-loader.js></script>
26-
<script src=build/wikimedia-page-library-transform.js></script>
26+
<script src=http://localhost:8080/wikimedia-page-library-transform.js></script>
2727
<link rel=import href=ControlPanel.html>
2828
</head>
2929

‎demo/LazyLoadTransform.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<head>
55
<meta charset=utf-8>
66
<title>LazyLoadTransform</title>
7-
<link href=../build/wikimedia-page-library-transform.css rel=stylesheet>
7+
<link href=http://localhost:8080/wikimedia-page-library-transform.css rel=stylesheet>
88
<style>
99
:root {
1010
--control-panel-theme-visibility: visible;
@@ -14,7 +14,7 @@
1414
img, .pagelib_lazy_load_placeholder { margin-top: 4px; margin-bottom: 4px; }
1515
</style>
1616
<script src=https://polygit.org/components/webcomponentsjs/webcomponents-loader.js></script>
17-
<script src=build/wikimedia-page-library-transform.js></script>
17+
<script src=http://localhost:8080/wikimedia-page-library-transform.js></script>
1818
<link rel=import href=ControlPanel.html>
1919
</head>
2020

‎demo/LazyLoadTransformer.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<head>
55
<meta charset=utf-8>
66
<title>LazyLoadTransformer</title>
7-
<link href=../build/wikimedia-page-library-transform.css rel=stylesheet>
7+
<link href=http://localhost:8080/wikimedia-page-library-transform.css rel=stylesheet>
88
<style>
99
:root {
1010
--control-panel-theme-visibility: visible;
@@ -13,7 +13,7 @@
1313
body, img, .pagelib_lazy_load_placeholder { margin: 4px; }
1414
</style>
1515
<script src=https://polygit.org/components/webcomponentsjs/webcomponents-loader.js></script>
16-
<script src=build/wikimedia-page-library-transform.js></script>
16+
<script src=http://localhost:8080/wikimedia-page-library-transform.js></script>
1717
<link rel=import href=ControlPanel.html>
1818
</head>
1919

‎demo/ThemeTransform.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<meta charset=utf-8>
66
<title>ThemeTransform</title>
77
<link href="https://en.wikipedia.org/w/load.php?debug=true&lang=en&modules=skins.minerva.base.reset|skins.minerva.content.styles|ext.cite.style|ext.math.styles|ext.timeline.styles|mediawiki.page.gallery.styles|mediawiki.skinning.content.parsoid&only=styles&version=&*" rel="stylesheet" type="text/css"></link>
8-
<link href=../build/wikimedia-page-library-transform.css rel=stylesheet>
8+
<link href=http://localhost:8080/wikimedia-page-library-transform.css rel=stylesheet>
99
<style>
1010
:root {
1111
--control-panel-theme-visibility: visible;
@@ -42,7 +42,7 @@
4242
</style>
4343

4444
<script src=https://polygit.org/components/webcomponentsjs/webcomponents-loader.js></script>
45-
<script src=build/wikimedia-page-library-transform.js></script>
45+
<script src=http://localhost:8080/wikimedia-page-library-transform.js></script>
4646
<script src='./DemoArticles/ArticleRef.js'></script>
4747
<script src='./DemoUtilities.js'></script>
4848

0 commit comments

Comments
 (0)