Project maintenance

* Update npm dependencies to latest
* Upgrade node to 18
* Update linter config to latest WMF config
  * Disable some failing rules
* Fix CI errors caused by old sonar scanner image
* Fix tsc/linter issues
* Automated code formatting
* Disable broken codehealth integration

Change-Id: I12830ba40723b0ba32cc3671dba2131561801f88
Bug: T366040
Bug: T349118
Bug: T367272

Author: johngian

.eslintrc.json

@@ -3,16 +3,10 @@
     "eslint:recommended",
     "plugin:@typescript-eslint/eslint-recommended",
     "plugin:@typescript-eslint/recommended",
-    "wikimedia/server",
-    "wikimedia/node",
-    "wikimedia/language/es2017"
+    "wikimedia/server"
   ],
   "plugins": ["json", "jsdoc"],
   "parser": "@typescript-eslint/parser",
-  "parserOptions": {
-    "ecmaVersion": 2017,
-    "sourceType": "module"
-  },
   "rules": {
     "camelcase": [
       "error",
@@ -27,7 +21,12 @@
         "args": "none"
       }
     ],
-    "space-in-parens": ["error", "never"],
+    "@typescript-eslint/no-unused-vars": [
+      "error",
+      {
+        "args": "none"
+      }
+    ],
     "computed-property-spacing": "off",
     "no-multi-spaces": "off",
     "prefer-const": "error",
@@ -39,7 +38,9 @@
     "@typescript-eslint/no-var-requires": "off",
     "@typescript-eslint/no-explicit-any": "off",
     "@typescript-eslint/explicit-function-return-type": "off",
-    "@typescript-eslint/camelcase": "off"
+    "@typescript-eslint/camelcase": "off",
+    "es-x/no-optional-chaining": "off",
+    "es-x/no-class-fields": "off"
   },
   "settings": {
     "node": {

.pipeline/blubber.yaml

@@ -1,15 +1,15 @@
 version: v4
-base: docker-registry.wikimedia.org/nodejs12-slim
+base: docker-registry.wikimedia.org/nodejs18-slim
 lives:
   in: /srv/service
 runs:
   environment: { APP_BASE_PATH: /srv/service }
 
 variants:
   all-dependencies:
-    base: docker-registry.wikimedia.org/nodejs12-devel
+    base: docker-registry.wikimedia.org/nodejs18-devel
     copies: [local]
-    apt: { packages: [git, build-essential, python, pkg-config] }
+    apt: { packages: [git, build-essential, python3, pkg-config] }
     node: { requirements: [package.json, package-lock.json] }
     runs: { environment: { LINK: g++ } }
   build:
@@ -33,7 +33,7 @@ variants:
         destination: /srv/service/dist
     node: { env: production }
   production:
-    base: docker-registry.wikimedia.org/nodejs12-slim
+    base: docker-registry.wikimedia.org/nodejs18-slim
     node: { requirements: [] }
     includes: [prep]
     apt: { packages: [ca-certificates] }
@@ -43,7 +43,7 @@ variants:
       environment:
         GOOGLE_APPLICATION_CREDENTIALS: /etc/mediawiki-services-push-notifications/google-application-credentials.json
   codehealth:
-    base: docker-registry.wikimedia.org/releng/sonar-scanner:1.0.1
+    base: docker-registry.wikimedia.org/releng/sonar-scanner:4.6.0.2311-s3
     copies: [all-dependencies]
     runs:
       environment: { SONAR_API_KEY: "SONAR_API_KEY" }

.pipeline/config.yaml

@@ -8,30 +8,30 @@ pipelines:
         run:
           image: '${built.imageID}'
           arguments: [test]
-      - name: codehealth_built
-        build: codehealth
-      - name: coverage
-        run:
-          image: '${codehealth_built.imageID}'
-          env:
-            SONAR_BRANCH_TARGET: ${ZUUL_BRANCH}
-            SONAR_BRANCH_NAME: '${ZUUL_CHANGE}-${ZUUL_PATCHSET}'
-          credentials:
-            - id: SONAR_API_KEY
-              name: SONAR_API_KEY
+#     - name: codehealth_built
+#       build: codehealth
+#     - name: coverage
+#       run:
+#         image: '${codehealth_built.imageID}'
+#         env:
+#           SONAR_BRANCH_TARGET: ${ZUUL_BRANCH}
+#           SONAR_BRANCH_NAME: '${ZUUL_CHANGE}-${ZUUL_PATCHSET}'
+#         credentials:
+#           - id: SONAR_API_KEY
+#             name: SONAR_API_KEY
   publish:
     blubberfile: blubber.yaml
     stages:
-      - name: codehealth_built
-        build: codehealth
-      - name: coverage
-        run:
-          image: '${codehealth_built.imageID}'
-          env:
-            SONAR_BRANCH_NAME: ${ZUUL_BRANCH}
-          credentials:
-            - id: SONAR_API_KEY
-              name: SONAR_API_KEY
+#     - name: codehealth_built
+#       build: codehealth
+#     - name: coverage
+#       run:
+#         image: '${codehealth_built.imageID}'
+#         env:
+#           SONAR_BRANCH_NAME: ${ZUUL_BRANCH}
+#         credentials:
+#           - id: SONAR_API_KEY
+#             name: SONAR_API_KEY
       - name: publish
         build: production
         publish: