Return all JSON schema errors

This is currently failing due to python-jsonschema/jsonschema#411

Author: wichert

src/rest_toolkit/ext/jsonschema.py

@@ -1,15 +1,16 @@
 from __future__ import absolute_import
 import abc
 import jsonschema
+from jsonschema.validators import validator_for
 from pyramid.httpexceptions import HTTPBadRequest
 from ..compat import add_metaclass
-from ..utils import add_missing
 
 
 class JSONValidationError(HTTPBadRequest):
     """HTTP response for JSON validation errors.
     """
 
+
 def validate(data, schema):
     """Validate data against a JSON schema.
 
@@ -21,15 +22,12 @@ def validate(data, schema):
     :raises pyramid.httpexceptions.HTTPBadRequest: if validation fails this
         exception is raised to abort any further processing.
     """
-    try:
-        jsonschema.validate(data, schema,
-            format_checker=jsonschema.draft4_format_checker)
-    except jsonschema.ValidationError as e:
-        error = {
-            '.'.join(str(p) for p in e.path): e.message
-        }
-        response = JSONValidationError(json=error)
-        response.validation_error = e
+    validator = validator_for(schema)
+    errors = {}
+    for e in validator(schema).iter_errors(data):
+        errors['.'.join(str(p) for p in e.path)] = e.message
+    if errors:
+        response = JSONValidationError(json=errors)
         raise response
 
 

tests/ext/test_jsonschema.py

@@ -6,7 +6,6 @@
 
 class DummyResource(JsonSchemaValidationMixin, EditableResource):
     schema = {
-           '$schema': 'http://json-schema.org/draft-04/schema',
            'type': 'object',
            'properties': {
                'email': {
@@ -57,6 +56,15 @@ def test_array_validation_error():
             }, partial=False)
 
 
+def test_multiple_errors():
+    resource = DummyResource()
+    with pytest.raises(HTTPBadRequest) as exc_info:
+        import pdb ; pdb.set_trace()
+        resource.validate({})
+    assert 'email' in exc_info.value.json
+    assert 'password' in exc_info.value.json
+
+
 def test_partial_data():
     resource = DummyResource()
     resource.to_dict = lambda: {'password': 'Jane'}