Skip to content

Commit 6ef3a47

Browse files
committed
fixed up mixed with embedded nulls tests
1 parent 560b9e6 commit 6ef3a47

10 files changed

+10
-1
lines changed

cpp/release-build/release/c-api-test

-631 KB
Binary file not shown.

cpp/release-build/release/io-test

-650 KB
Binary file not shown.
-159 KB
Binary file not shown.
-17.6 KB
Binary file not shown.
-665 KB
Binary file not shown.

cpp/release-build/release/writer-test

-698 KB
Binary file not shown.

cpp/src/src

Lines changed: 0 additions & 1 deletion
This file was deleted.

python/feather/tests/test_reader.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -244,10 +244,20 @@ def test_boolean_object_nulls(self):
244244

245245
def test_strings(self):
246246
repeats = 1000
247+
248+
# we hvae mixed bytes, unicode, strings
247249
values = [b'foo', None, u'bar', 'qux', np.nan]
248250
df = pd.DataFrame({'strings': values * repeats})
251+
self._assert_error_on_write(df, ValueError)
249252

253+
# embedded nulls are ok
250254
values = ['foo', None, 'bar', 'qux', None]
255+
df = pd.DataFrame({'strings': values * repeats})
256+
expected = pd.DataFrame({'strings': values * repeats})
257+
self._check_pandas_roundtrip(df, expected, null_counts=[2 * repeats])
258+
259+
values = ['foo', None, 'bar', 'qux', np.nan]
260+
df = pd.DataFrame({'strings': values * repeats})
251261
expected = pd.DataFrame({'strings': values * repeats})
252262
self._check_pandas_roundtrip(df, expected, null_counts=[2 * repeats])
253263

python/feather_5854510bed814f8d9429c7ef4a6b4307

Whitespace-only changes.

python/feather_7f1424cb01464378a722b496467af81d

Whitespace-only changes.

0 commit comments

Comments
 (0)