Skip to content

Commit d3f7099

Browse files
authored
Merge pull request diesel-rs#3917 from greyblake/fix-doc-example-returning-does-not-preserve-order
Fix doc example to make it clear that ".returning()" does not preserve original order
2 parents ec455eb + 7f3ead2 commit d3f7099

File tree

1 file changed

+6
-2
lines changed
  • diesel/src/query_builder/insert_statement

1 file changed

+6
-2
lines changed

diesel/src/query_builder/insert_statement/mod.rs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -281,8 +281,12 @@ impl<T: QuerySource, U, Op> InsertStatement<T, U, Op> {
281281
/// let inserted_names = diesel::insert_into(users)
282282
/// .values(&vec![name.eq("Timmy"), name.eq("Jimmy")])
283283
/// .returning(name)
284-
/// .get_results(connection);
285-
/// assert_eq!(Ok(vec!["Timmy".to_string(), "Jimmy".to_string()]), inserted_names);
284+
/// .get_results(connection)
285+
/// .unwrap();
286+
/// // Note that the returned order is not guaranteed to be preserved
287+
/// assert_eq!(inserted_names.len(), 2);
288+
/// assert!(inserted_names.contains(&"Timmy".to_string()));
289+
/// assert!(inserted_names.contains(&"Jimmy".to_string()));
286290
/// # }
287291
/// # #[cfg(not(feature = "postgres"))]
288292
/// # fn main() {}

0 commit comments

Comments
 (0)