Skip to content

Commit 453edeb

Browse files
committed
resolve: Leave a comment about name bindings for legacy derive helpers
1 parent 50bbe01 commit 453edeb

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

compiler/rustc_resolve/src/ident.rs

+5
Original file line numberDiff line numberDiff line change
@@ -432,6 +432,11 @@ impl<'a, 'tcx> Resolver<'a, 'tcx> {
432432
}
433433
}
434434
Scope::DeriveHelpersCompat => {
435+
// FIXME: Try running this logic eariler, to allocate name bindings for
436+
// legacy derive helpers when creating an attribute invocation with
437+
// following derives. Legacy derive helpers are not common, so it shouldn't
438+
// affect performance. It should also allow to remove the `derives`
439+
// component from `ParentScope`.
435440
let mut result = Err(Determinacy::Determined);
436441
for derive in parent_scope.derives {
437442
let parent_scope = &ParentScope { derives: &[], ..*parent_scope };

0 commit comments

Comments
 (0)