Skip to content

Commit 75fdfa9

Browse files
committed
[test] Fix nits
1 parent e1ddacc commit 75fdfa9

File tree

1 file changed

+4
-10
lines changed

1 file changed

+4
-10
lines changed

test/websocket.test.js

+4-10
Original file line numberDiff line numberDiff line change
@@ -1101,11 +1101,9 @@ describe('WebSocket', () => {
11011101
});
11021102

11031103
it('emits an error if the redirect URL is invalid (1/2)', (done) => {
1104-
const onUpgrade = (req, socket) => {
1104+
server.once('upgrade', (req, socket) => {
11051105
socket.end('HTTP/1.1 302 Found\r\nLocation: ws://\r\n\r\n');
1106-
};
1107-
1108-
server.on('upgrade', onUpgrade);
1106+
});
11091107

11101108
const ws = new WebSocket(`ws://localhost:${server.address().port}`, {
11111109
followRedirects: true
@@ -1117,17 +1115,14 @@ describe('WebSocket', () => {
11171115
assert.strictEqual(err.message, 'Invalid URL: ws://');
11181116
assert.strictEqual(ws._redirects, 1);
11191117

1120-
server.removeListener('upgrade', onUpgrade);
11211118
ws.on('close', () => done());
11221119
});
11231120
});
11241121

11251122
it('emits an error if the redirect URL is invalid (2/2)', (done) => {
1126-
const onUpgrade = (req, socket) => {
1123+
server.once('upgrade', (req, socket) => {
11271124
socket.end('HTTP/1.1 302 Found\r\nLocation: http://localhost\r\n\r\n');
1128-
};
1129-
1130-
server.on('upgrade', onUpgrade);
1125+
});
11311126

11321127
const ws = new WebSocket(`ws://localhost:${server.address().port}`, {
11331128
followRedirects: true
@@ -1142,7 +1137,6 @@ describe('WebSocket', () => {
11421137
);
11431138
assert.strictEqual(ws._redirects, 1);
11441139

1145-
server.removeListener('upgrade', onUpgrade);
11461140
ws.on('close', () => done());
11471141
});
11481142
});

0 commit comments

Comments
 (0)