Skip to content

Commit e5d8da0

Browse files
committed
Display node.js fields. See
angelozerr#147
1 parent 48f1c35 commit e5d8da0

File tree

8 files changed

+302
-99
lines changed

8 files changed

+302
-99
lines changed

eclipse/ts.eclipse.ide.ui/src/ts/eclipse/ide/internal/ui/TypeScriptUIMessages.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,9 @@ public class TypeScriptUIMessages extends NLS {
197197
public static String TypeScriptRuntimeAndNodejsWizardPage_typescript_group_label;
198198
public static String TypeScriptRuntimeAndNodejsWizardPage_useEmbeddedTsRuntime_label;
199199
public static String TypeScriptRuntimeAndNodejsWizardPage_useInstallTsRuntime_label;
200-
200+
public static String TypeScriptRuntimeAndNodejsWizardPage_useEmbeddedNodeJs_label;
201+
public static String TypeScriptRuntimeAndNodejsWizardPage_useInstalledNodeJs_label;
202+
201203
// NPM Module Versions
202204
public static String NPMModuleVersionsSelectionDialog_title;
203205
public static String NPMModuleVersionsSelectionDialog_message;

eclipse/ts.eclipse.ide.ui/src/ts/eclipse/ide/internal/ui/TypeScriptUIMessages.properties

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -170,8 +170,10 @@ TypeScriptRuntimeAndNodejsWizardPage_title=TypeScript Runtime / Node.js
170170
TypeScriptRuntimeAndNodejsWizardPage_description=Select the TypeScript runtime and the Node.js required by the TypeScript tsserver.
171171
TypeScriptRuntimeAndNodejsWizardPage_nodejs_group_label=Node.js
172172
TypeScriptRuntimeAndNodejsWizardPage_typescript_group_label=TypeScript Runtime
173-
TypeScriptRuntimeAndNodejsWizardPage_useEmbeddedTsRuntime_label=Use embedded TypeScript
174-
TypeScriptRuntimeAndNodejsWizardPage_useInstallTsRuntime_label=Install TypeScript
173+
TypeScriptRuntimeAndNodejsWizardPage_useEmbeddedTsRuntime_label=Use embedded
174+
TypeScriptRuntimeAndNodejsWizardPage_useInstallTsRuntime_label=Install
175+
TypeScriptRuntimeAndNodejsWizardPage_useEmbeddedNodeJs_label=Use embedded
176+
TypeScriptRuntimeAndNodejsWizardPage_useInstalledNodeJs_label=Use installed
175177

176178
# NPM Module widget
177179
NPMModuleVersionsSelectionDialog_title=Open NPM module version for ''{0}''
@@ -180,5 +182,5 @@ NPMModuleVersionsSelectionDialog_searchJob_taskName=Searching
180182

181183
# NPN Install Widgets
182184
NPMInstallWidget_ValidateVersionJob_name=Validate NPM module version job.
183-
NPMInstallWidget_SearchingVersions_status=Searching versions for ''{0}'' with 'npm show'
184-
NPMInstallWidget_InvalidVersion_status=Invalid version ''{0}'' for ''{1}''.
185+
NPMInstallWidget_SearchingVersions_status=Searching available versions for ''{0}'' module with 'npm show'...
186+
NPMInstallWidget_InvalidVersion_status=Invalid version ''{0}'' for ''{1}'' module.

eclipse/ts.eclipse.ide.ui/src/ts/eclipse/ide/internal/ui/dialogs/NPMModuleVersionsSelectionDialog.java

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,7 @@
2121
import org.eclipse.jface.dialogs.IDialogSettings;
2222
import org.eclipse.jface.text.ITextSelection;
2323
import org.eclipse.jface.viewers.ISelection;
24-
import org.eclipse.jface.viewers.LabelProvider;
2524
import org.eclipse.osgi.util.NLS;
26-
import org.eclipse.swt.graphics.Image;
2725
import org.eclipse.swt.widgets.Composite;
2826
import org.eclipse.swt.widgets.Control;
2927
import org.eclipse.swt.widgets.Shell;
@@ -52,7 +50,7 @@ public NPMModuleVersionsSelectionDialog(String moduleName, Shell shell, boolean
5250
setTitle(NLS.bind(TypeScriptUIMessages.NPMModuleVersionsSelectionDialog_title, moduleName));
5351
setMessage(TypeScriptUIMessages.NPMModuleVersionsSelectionDialog_message);
5452
setImage(TypeScriptUIImageResource.getImage(TypeScriptUIImageResource.IMG_NPM));
55-
setListLabelProvider(new VersionLabelProvider());
53+
setListLabelProvider(VersionLabelProvider.getInstance());
5654
this.moduleName = moduleName;
5755
}
5856

@@ -131,14 +129,6 @@ protected Control createExtendedContentArea(Composite parent) {
131129
return null;
132130
}
133131

134-
protected class VersionLabelProvider extends LabelProvider {
135-
136-
@Override
137-
public Image getImage(Object element) {
138-
return TypeScriptUIImageResource.getImage(TypeScriptUIImageResource.IMG_NPM);
139-
}
140-
}
141-
142132
protected class VersionFilter extends ItemsFilter {
143133

144134
@Override
Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
package ts.eclipse.ide.internal.ui.dialogs;
2+
3+
import org.eclipse.jface.fieldassist.IContentProposal;
4+
import org.eclipse.jface.viewers.LabelProvider;
5+
import org.eclipse.swt.graphics.Image;
6+
7+
import ts.eclipse.ide.ui.TypeScriptUIImageResource;
8+
9+
public class VersionLabelProvider extends LabelProvider {
10+
11+
private static final VersionLabelProvider INSTANCE = new VersionLabelProvider();
12+
13+
public static VersionLabelProvider getInstance() {
14+
return INSTANCE;
15+
}
16+
17+
@Override
18+
public String getText(Object element) {
19+
if (element instanceof IContentProposal) {
20+
return ((IContentProposal) element).getLabel();
21+
}
22+
return super.getText(element);
23+
}
24+
25+
@Override
26+
public Image getImage(Object element) {
27+
return TypeScriptUIImageResource.getImage(TypeScriptUIImageResource.IMG_NPM);
28+
}
29+
30+
}

eclipse/ts.eclipse.ide.ui/src/ts/eclipse/ide/internal/ui/preferences/NodejsConfigurationBlock.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ public void widgetSelected(SelectionEvent e) {
201201
dialog.setFilterPath(filePathCombo.getText());
202202
String result = dialog.open();
203203
if (!StringUtils.isEmpty(result)) {
204-
installedComboBox.setText(result);
204+
filePathCombo.setText(result);
205205
}
206206

207207
}

eclipse/ts.eclipse.ide.ui/src/ts/eclipse/ide/internal/ui/wizards/TSConfigWizardPage.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ protected void createBody(Composite parent) {
135135
label.setFont(font);
136136

137137
// Text for outDir
138-
txtOutDir = new Text(subGroup, SWT.BORDER);
138+
txtOutDir = new Text(subGroup, SWT.SINGLE | SWT.BORDER);
139139
txtOutDir.addListener(SWT.Modify, this);
140140
data = new GridData(SWT.FILL, SWT.CENTER, true, false);
141141
txtOutDir.setLayoutData(data);

0 commit comments

Comments
 (0)