From c72d90b8bcd2c76e0d4210e87a9dc43187e347ce Mon Sep 17 00:00:00 2001 From: 311289189 Date: Mon, 2 Jul 2018 22:03:14 +0200 Subject: [PATCH 1/3] updates example - catches the case whereby assets are an object --- README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README.md b/README.md index 5ddd3579a..2716b2b41 100644 --- a/README.md +++ b/README.md @@ -318,6 +318,9 @@ const middleware = require('webpack-dev-middleware'); // This function makes server rendering of asset references consistent with different webpack chunk/entry configurations function normalizeAssets(assets) { + if (typeof assets === 'object') { + return Object.values(assets) + } return Array.isArray(assets) ? assets : [assets] } From bf30f2537a1796bfe291c798d76f6cf0e8f3fcda Mon Sep 17 00:00:00 2001 From: 311289189 Date: Thu, 5 Jul 2018 20:09:10 +0200 Subject: [PATCH 2/3] Update README.md correct typecheck in SSR example --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 2716b2b41..a19411728 100644 --- a/README.md +++ b/README.md @@ -318,7 +318,7 @@ const middleware = require('webpack-dev-middleware'); // This function makes server rendering of asset references consistent with different webpack chunk/entry configurations function normalizeAssets(assets) { - if (typeof assets === 'object') { + if (Object.prototype.toString.call(assets) === '[object Object]') { return Object.values(assets) } return Array.isArray(assets) ? assets : [assets] From f9ab7749e67746e504ceae435a62cfab5a9b43bf Mon Sep 17 00:00:00 2001 From: 311289189 Date: Fri, 6 Jul 2018 06:28:54 +0200 Subject: [PATCH 3/3] Update README.md uses helper for isObject --- README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index a19411728..6b883a42e 100644 --- a/README.md +++ b/README.md @@ -314,11 +314,12 @@ Example Implementation: ```js const webpack = require('webpack'); const compiler = webpack({ ... }); +const isObject = require('is-object'); const middleware = require('webpack-dev-middleware'); // This function makes server rendering of asset references consistent with different webpack chunk/entry configurations function normalizeAssets(assets) { - if (Object.prototype.toString.call(assets) === '[object Object]') { + if (isObject(assets)) { return Object.values(assets) } return Array.isArray(assets) ? assets : [assets]