fix: remove splitchunks (#2310)

Author: rishabh3112

packages/generators/__tests__/__snapshots__/init-generator.test.ts.snap

@@ -14,23 +14,6 @@ Object {
       },
     ],
   },
-  "optimization": Object {
-    "minimizer": Array [
-      "new TerserPlugin()",
-    ],
-    "splitChunks": Object {
-      "cacheGroups": Object {
-        "vendors": Object {
-          "priority": -10,
-          "test": "/[\\\\\\\\/]node_modules[\\\\\\\\/]/",
-        },
-      },
-      "chunks": "'async'",
-      "minChunks": 1,
-      "minSize": 30000,
-      "name": false,
-    },
-  },
   "plugins": Array [
     "new webpack.ProgressPlugin()",
   ],
@@ -55,23 +38,6 @@ Object {
       },
     ],
   },
-  "optimization": Object {
-    "minimizer": Array [
-      "new TerserPlugin()",
-    ],
-    "splitChunks": Object {
-      "cacheGroups": Object {
-        "vendors": Object {
-          "priority": -10,
-          "test": "/[\\\\\\\\/]node_modules[\\\\\\\\/]/",
-        },
-      },
-      "chunks": "'async'",
-      "minChunks": 1,
-      "minSize": 30000,
-      "name": false,
-    },
-  },
   "plugins": Array [
     "new webpack.ProgressPlugin()",
   ],
@@ -121,23 +87,6 @@ Object {
       },
     ],
   },
-  "optimization": Object {
-    "minimizer": Array [
-      "new TerserPlugin()",
-    ],
-    "splitChunks": Object {
-      "cacheGroups": Object {
-        "vendors": Object {
-          "priority": -10,
-          "test": "/[\\\\\\\\/]node_modules[\\\\\\\\/]/",
-        },
-      },
-      "chunks": "'async'",
-      "minChunks": 1,
-      "minSize": 30000,
-      "name": false,
-    },
-  },
   "plugins": Array [
     "new webpack.ProgressPlugin()",
     "new MiniCssExtractPlugin({ filename:'main.[contenthash].css' })",
@@ -166,23 +115,6 @@ Object {
       },
     ],
   },
-  "optimization": Object {
-    "minimizer": Array [
-      "new TerserPlugin()",
-    ],
-    "splitChunks": Object {
-      "cacheGroups": Object {
-        "vendors": Object {
-          "priority": -10,
-          "test": "/[\\\\\\\\/]node_modules[\\\\\\\\/]/",
-        },
-      },
-      "chunks": "'async'",
-      "minChunks": 1,
-      "minSize": 30000,
-      "name": false,
-    },
-  },
   "plugins": Array [
     "new webpack.ProgressPlugin()",
   ],
@@ -196,23 +128,6 @@ Object {
   "module": Object {
     "rules": Array [],
   },
-  "optimization": Object {
-    "minimizer": Array [
-      "new TerserPlugin()",
-    ],
-    "splitChunks": Object {
-      "cacheGroups": Object {
-        "vendors": Object {
-          "priority": -10,
-          "test": "/[\\\\\\\\/]node_modules[\\\\\\\\/]/",
-        },
-      },
-      "chunks": "'async'",
-      "minChunks": 1,
-      "minSize": 30000,
-      "name": false,
-    },
-  },
   "output": Object {
     "path": "path.resolve(__dirname, 'dist2')",
   },
@@ -231,14 +146,6 @@ Object {
   "module": Object {
     "rules": Array [],
   },
-  "optimization": Object {
-    "minimizer": Array [
-      "new TerserPlugin()",
-    ],
-    "splitChunks": Object {
-      "chunks": "'all'",
-    },
-  },
   "plugins": Array [
     "new webpack.ProgressPlugin()",
     "new HtmlWebpackPlugin({
@@ -263,23 +170,6 @@ Object {
   "module": Object {
     "rules": Array [],
   },
-  "optimization": Object {
-    "minimizer": Array [
-      "new TerserPlugin()",
-    ],
-    "splitChunks": Object {
-      "cacheGroups": Object {
-        "vendors": Object {
-          "priority": -10,
-          "test": "/[\\\\\\\\/]node_modules[\\\\\\\\/]/",
-        },
-      },
-      "chunks": "'async'",
-      "minChunks": 1,
-      "minSize": 30000,
-      "name": false,
-    },
-  },
   "plugins": Array [
     "new webpack.ProgressPlugin()",
   ],

packages/generators/src/init-generator.ts

@@ -4,16 +4,7 @@ import logSymbols from 'log-symbols';
 import path from 'path';
 import { Confirm, Input, List } from './utils/scaffold-utils';
 
-import {
-    getDefaultOptimization,
-    LangType,
-    langQuestionHandler,
-    tooltip,
-    generatePluginName,
-    StylingType,
-    styleQuestionHandler,
-    entryQuestions,
-} from './utils';
+import { LangType, langQuestionHandler, tooltip, generatePluginName, StylingType, styleQuestionHandler, entryQuestions } from './utils';
 import { CustomGenerator } from './types';
 
 const { logger, getPackageManager } = utils;
@@ -60,15 +51,6 @@ export default class InitGenerator extends CustomGenerator {
 
         this.entryOption = './src/index.js';
 
-        // add splitChunks options for transparency
-        // defaults coming from: https://webpack.js.org/plugins/split-chunks-plugin/#optimization-splitchunks
-        this.configuration.config.topScope.push(
-            "const path = require('path');",
-            "const webpack = require('webpack');",
-            '\n',
-            tooltip.splitChunks(),
-        );
-
         (this.configuration.config.webpackOptions.plugins as string[]).push('new webpack.ProgressPlugin()');
     }
 
@@ -231,12 +213,6 @@ export default class InitGenerator extends CustomGenerator {
 			})`);
         }
 
-        // TerserPlugin
-        this.dependencies.push('terser-webpack-plugin');
-        this.configuration.config.topScope.push(tooltip.terser(), "const TerserPlugin = require('terser-webpack-plugin');", '\n');
-
-        // Chunksplitting
-        this.configuration.config.webpackOptions.optimization = getDefaultOptimization(this.usingDefaults);
         this.configuration.config.webpackOptions.mode = this.usingDefaults ? "'production'" : "'development'";
     }