fix: Regex does not work for minified artifact of style-loader #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #38 |
michael-ciniawsky
requested review from
bebraw,
michael-ciniawsky and
joshwiens
|
@michael-ciniawsky I think so, and it should be fixed with this PR. |
bebraw
approved these changes
Mar 30, 2017
michael-ciniawsky
approved these changes
Mar 30, 2017
joshwiens
approved these changes
Mar 30, 2017
|
@zuohaocheng I forgot to ask, if you're basically interested in helping to maintain this project ? 😛 |
|
@michael-ciniawsky Thanks for invitation, I'm glad to be able to help :) |
|
@zuohaocheng - Send me an email via direct message on gitter & i'll get you an invitation to Slack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix some cases for PR #31
In minified artifacts of
style-loader, there is no space in js file, which couldn't be handled by the regex. It is fixed in this PR, and test cases updated accordingly.