Skip to content

Usage with style loader - ambiguous docs #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 4 tasks
gaurav5430 opened this issue Mar 22, 2020 · 0 comments · Fixed by #605
Closed
1 of 4 tasks

Usage with style loader - ambiguous docs #516

gaurav5430 opened this issue Mar 22, 2020 · 0 comments · Fixed by #605

Comments

@gaurav5430
Copy link

Documentation Is:

  • Missing
  • Needed
  • Confusing
  • Not Sure?

Please Explain in Detail...

The documentation says:

This plugin should be used only on production builds without style-loader in the loaders chain, especially if you want to have HMR in development

The first part:

This plugin should be used only on production builds without style-loader in the loaders chain

seems to suggest that this plugin should not be used in development builds, only in production builds and that too without style-loader. Is that understanding correct?

The second part:
especially if you want to have HMR in development
seems to suggest that the plugin can be used in development and can also enable HMR.
But if it can be used in development, is style-loader still a problem? Why does it say especially and talk about development, while the previous statement is about production?
This is quite confusing.

Your Proposal for Changes

If the plugin can also be used in development, and if should always be used without style loader, then the first part may be better written as:
This plugin should be used only on builds without style-loader in the loaders chain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant