Skip to content

Commit c3eb08b

Browse files
fix: improves sorting of modules
1 parent c5ba6d7 commit c3eb08b

File tree

1 file changed

+11
-19
lines changed

1 file changed

+11
-19
lines changed

src/index.js

+11-19
Original file line numberDiff line numberDiff line change
@@ -322,22 +322,6 @@ class MiniCssExtractPlugin {
322322
}
323323
}
324324

325-
sortedModules(compilation, chunk, modules, requestShortener) {
326-
let cache = this._sortedModulesCache.get(chunk);
327-
328-
if (!cache && modules) {
329-
cache = this.sortModules(
330-
compilation,
331-
chunk,
332-
[...modules],
333-
requestShortener
334-
);
335-
this._sortedModulesCache.set(chunk, cache);
336-
}
337-
338-
return cache;
339-
}
340-
341325
/** @param {import("webpack").Compiler} compiler */
342326
apply(compiler) {
343327
const webpack = compiler.webpack
@@ -553,7 +537,7 @@ class MiniCssExtractPlugin {
553537
? Array.from(this.getChunkModules(chunk, chunkGraph)).filter(
554538
(module) => module.type === MODULE_TYPE
555539
)
556-
: this.sortedModules(
540+
: this.sortModules(
557541
compilation,
558542
chunk,
559543
chunkGraph.getChunkModulesIterableBySourceType(
@@ -1103,7 +1087,13 @@ class MiniCssExtractPlugin {
11031087
}
11041088

11051089
sortModules(compilation, chunk, modules, requestShortener) {
1106-
let usedModules;
1090+
let usedModules = this._sortedModulesCache.get(chunk);
1091+
1092+
if (usedModules || !modules) {
1093+
return usedModules;
1094+
}
1095+
1096+
modules = [...modules];
11071097

11081098
const [chunkGroup] = chunk.groupsIterable;
11091099
const moduleIndexFunctionName =
@@ -1241,11 +1231,13 @@ class MiniCssExtractPlugin {
12411231
usedModules = modules;
12421232
}
12431233

1234+
this._sortedModulesCache.set(chunk, usedModules);
1235+
12441236
return usedModules;
12451237
}
12461238

12471239
renderContentAsset(compiler, compilation, chunk, modules, requestShortener) {
1248-
const usedModules = this.sortedModules(
1240+
const usedModules = this.sortModules(
12491241
compilation,
12501242
chunk,
12511243
modules,

0 commit comments

Comments
 (0)