Skip to content

Commit 4c5a137

Browse files
test: fixing broken test
1 parent 7d3a4e3 commit 4c5a137

File tree

4 files changed

+13
-12
lines changed

4 files changed

+13
-12
lines changed

src/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,7 @@ class MiniCssExtractPlugin {
378378
])
379379
: '',
380380
insert
381-
? 'insert(linkTag);'
381+
? Template.asString([insert, 'insert(linkTag);'])
382382
: 'var head = document.getElementsByTagName("head")[0]; head.appendChild(linkTag)',
383383
]),
384384
'}).then(function() {',

test/cases/insert-function/expected/main.js

+2-10
Original file line numberDiff line numberDiff line change
@@ -115,21 +115,13 @@
115115
/******/ };
116116
/******/ linkTag.href = fullhref;
117117
/******/
118-
/******/ var insert = function insert(linkTag) {
118+
/******/ function insert(linkTag) {
119119
/******/ const reference = document.querySelector('.hot-reload');
120120
/******/
121121
/******/ if (reference) {
122122
/******/ reference.parentNode.insertBefore(linkTag, reference);
123123
/******/ }
124-
/******/ };
125-
/******/ if (typeof insert === 'function') { insert(linkTag); }
126-
/******/ else { var target = document.querySelector(function insert(linkTag) {
127-
/******/ const reference = document.querySelector('.hot-reload');
128-
/******/
129-
/******/ if (reference) {
130-
/******/ reference.parentNode.insertBefore(linkTag, reference);
131-
/******/ }
132-
/******/ }); target && insert === 'body' ? target && target.insertBefore(linkTag,target.firstChild) : target.appendChild(linkTag); }
124+
/******/ }insert(linkTag);
133125
/******/ }).then(function() {
134126
/******/ installedCssChunks[chunkId] = 0;
135127
/******/ }));

test/cases/insert-function/webpack.config.e2e.js

+7-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,13 @@ module.exports = {
6464
new Self({
6565
filename: '[name].css',
6666
chunkFilename: '[id].css',
67-
insert: 'body',
67+
insert: function insert(linkTag) {
68+
// eslint-disable-next-line no-undef
69+
const reference = document.querySelector('.hot-reload');
70+
if (reference) {
71+
reference.parentNode.insertBefore(linkTag, reference);
72+
}
73+
},
6874
}),
6975
],
7076
devServer: {

test/validate-plugin-options.test.js

+3
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,9 @@ describe('validate options', () => {
1818
success: [true, false],
1919
failure: [1],
2020
},
21+
insert: {
22+
success: [],
23+
},
2124
unknown: {
2225
success: [],
2326
// TODO failed in next release

0 commit comments

Comments
 (0)