fix: corrected order for chunk.modules (#563)

* corrected order for chunk.modules loop

* added regression test for #548

* upgraded to latest webpack version 3.1.0 which includes needed Chunk.sortModules method

* applied change to new location of index.js

Author: hulkish

package.json

@@ -61,7 +61,7 @@
     "node": ">= 4.3 < 5.0.0 || >= 5.10"
   },
   "peerDependencies": {
-    "webpack": "^3.0.0"
+    "webpack": "^3.1.0"
   },
   "homepage": "http://github.com/webpack-contrib/extract-text-webpack-plugin",
   "repository": {

src/index.js

@@ -144,6 +144,7 @@ class ExtractTextPlugin {
         async.forEach(chunks, (chunk, callback) => { // eslint-disable-line no-shadow
           const extractedChunk = extractedChunks[chunks.indexOf(chunk)];
           const shouldExtract = !!(options.allChunks || isInitialOrHasNoParents(chunk));
+          chunk.sortModules();
           async.forEach(chunk.mapModules((c) => { return c; }), (module, callback) => { // eslint-disable-line no-shadow, arrow-body-style
             let meta = module[NS];
             if (meta && (!meta.options.id || meta.options.id === id)) {

test/cases/chunk-modules-ordered-by-id/a.js

@@ -0,0 +1 @@
+require('./c.txt');

test/cases/chunk-modules-ordered-by-id/b.txt

@@ -0,0 +1,3 @@
+.block {
+	color: tomato;
+}

test/cases/chunk-modules-ordered-by-id/c.txt

@@ -0,0 +1,3 @@
+.App {
+	color: black;
+}

test/cases/chunk-modules-ordered-by-id/expected/file.css

@@ -0,0 +1,6 @@
+.block {
+	color: tomato;
+}
+.App {
+	color: black;
+}

test/cases/chunk-modules-ordered-by-id/index.js

@@ -0,0 +1,2 @@
+require('./a');
+require('./b.txt');

test/cases/chunk-modules-ordered-by-id/webpack.config.js

@@ -0,0 +1,7 @@
+var ExtractTextPlugin = require("../../../");
+module.exports = {
+	entry: "./index",
+	plugins: [
+		new ExtractTextPlugin("file.css")
+	]
+};