Skip to content

Wrong output when deal with css modules #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
honghui-qiao opened this issue Mar 6, 2019 · 7 comments · Fixed by #904
Closed

Wrong output when deal with css modules #902

honghui-qiao opened this issue Mar 6, 2019 · 7 comments · Fixed by #904
Labels
priority: 4 (important) semver: Patch severity: 3 (broken) type: Bug

Comments

@honghui-qiao
Copy link

  • Operating System: Mojave
  • Node Version: v10.15.1
  • NPM Version: 6.4.1
  • webpack Version: 4.x
  • css-loader Version: 2.x

Expected Behavior

a[href=''] { xxx } should compiled to a[href=''] { xxx }

Actual Behavior

a[href=''] { xxx } compiled to a[href] { xxx }

We don't have this issue with css-loader 1.x
@alexander-akait
Copy link
Member

@honghui-qiao please create minimum reproducible test repo

@alexander-akait
Copy link
Member

No need, reproduce

@alexander-akait
Copy link
Member

WIP

@alexander-akait alexander-akait mentioned this issue Mar 6, 2019
Merged
6 tasks
@alexander-akait
Copy link
Member

Upstream issue postcss/postcss-selector-parser#185

@alexander-akait
Copy link
Member

Wait merge postcss/postcss-selector-parser#186

@alexander-akait
Copy link
Member

last version of postcss-value-parser fixes this problem. I added test to ensure we don't do regressions in future. Unfortunately we don't have directly postcss-selector-parser deps, so i can't bump this on our side. I recommend update your deps and lock file. Thanks!

@honghui-qiao
Copy link
Author

Thanks all! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: 4 (important) semver: Patch severity: 3 (broken) type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: don't remove value from attribute selector webpack-contrib/css-loader
2 participants
@alexander-akait @honghui-qiao