Skip to content

Critical vulnerability in [email protected] - retire.js #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tpopov94 opened this issue Jun 18, 2018 · 4 comments · Fixed by #742
Closed

Critical vulnerability in [email protected] - retire.js #732

tpopov94 opened this issue Jun 18, 2018 · 4 comments · Fixed by #742

Comments

@tpopov94
Copy link

Retire.js identifies a critical vulnerability when scanning projects with css-loader as dependency.

Retire.js Report:
"results": [ { "component": "macaddress", "version": "0.2.8", "parent": { "component": "uniqid", "version": "4.1.1", "parent": { "component": "postcss-filter-plugins", "version": "2.0.2", "parent": { "component": "cssnano", "version": "3.10.0", "parent": { "component": "css-loader", "version": "0.28.11" "level": 1 }, "level": 2 }, "level": 3 }, "level": 4 }, "level": 5, "vulnerabilities": [ { "info": [ "https://hackerone.com/reports/319467" ], "severity": "critical", "identifiers": { "summary": "Command Injection" } } ] } ]

This vulnerability comes from one of the module subdependencies - macddress

npm ls macaddress
[email protected] /Users/tpopov/Work/PlatformUI
└─┬ [email protected]
└─┬ [email protected]
└─┬ [email protected]
└─┬ [email protected]
└── [email protected]

@TixieSalander
Copy link

For info, macaddress have fixed the vulnerability in 0.2.9

@pumano
Copy link

pumano commented Jun 27, 2018

update macaddress dependency and make a release please.

@alexander-akait
Copy link
Member

@pumano we don't have macaddress in deps, please update own deps and lock file

@turbobeast
Copy link

@evilebottnawi you do have cssnano v3.10.0 which has an older version of post-css-filter-plugins (v2.0.2), that still depends on uniqid (also an older version), that has the vulnerable version of macadress.

The version of cssnano that breaks this chain (removed/updated post-css-filter-plugins), is still in pre-release, and has breaking changes 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants