Skip to content

Commit 28c1277

Browse files
committed
Merge pull request #428 from ericwilligers/increase-bezier-accuracy
Increase Bezier timing function accuracy
2 parents 7ec73f5 + 83c9090 commit 28c1277

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/timing-utilities.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@
178178
var mid = (start + end) / 2;
179179
function f(a, b, m) { return 3 * a * (1 - m) * (1 - m) * m + 3 * b * (1 - m) * m * m + m * m * m};
180180
var xEst = f(a, c, mid);
181-
if (Math.abs(x - xEst) < 0.001) {
181+
if (Math.abs(x - xEst) < 0.0001) {
182182
return f(b, d, mid);
183183
}
184184
if (xEst < x) {

test/js/timing-utilities.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,15 @@ suite('timing-utilities', function() {
2323
var f = toTimingFunction('ease');
2424
var g = toTimingFunction('cubic-bezier(.25, 0.1, 0.25, 1.0)');
2525
assertTimingFunctionsEqual(f, g, 'ease should map onto preset cubic-bezier');
26-
assert.closeTo(f(0.1844), 0.2601, 0.01);
27-
assert.closeTo(g(0.1844), 0.2601, 0.01);
26+
assert.closeTo(f(0.1844), 0.2599, 0.001);
27+
assert.closeTo(g(0.1844), 0.2599, 0.001);
2828
assert.equal(f(0), 0);
2929
assert.equal(f(1), 1);
3030
assert.equal(g(0), 0);
3131
assert.equal(g(1), 1);
3232

3333
f = toTimingFunction('cubic-bezier(0, 1, 1, 0)');
34-
assert.closeTo(f(0.104), 0.392, 0.01);
34+
assert.closeTo(f(0.104), 0.3920, 0.001);
3535

3636
function assertInvalidEasingThrows(easing) {
3737
assert.throws(function() {

0 commit comments

Comments
 (0)