Skip to content

Commit a74ed53

Browse files
committed
Remove push-tar
The release process and `make push` pushes the tar files to gs://kubernetes-release historically. No one has write permission to the GCS bucket anymore. We haven't pushed NPD tar files to that GCS bucket after v0.8.10. k/k has been using NPD v0.8.13+ since 1.29. This PR cleans up the Make file. NPD release should just include the tar files in the release note. Related issues: - kubernetes#874 - kubernetes#878
1 parent e14b392 commit a74ed53

File tree

1 file changed

+1
-10
lines changed

1 file changed

+1
-10
lines changed

Makefile

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,6 @@ TAG?=$(VERSION)
3535
# REGISTRY is the container registry to push into.
3636
REGISTRY?=gcr.io/k8s-staging-npd
3737

38-
# UPLOAD_PATH is the cloud storage path to upload release tar.
39-
UPLOAD_PATH?=gs://kubernetes-release
40-
# Trim the trailing '/' in the path
41-
UPLOAD_PATH:=$(shell echo $(UPLOAD_PATH) | sed '$$s/\/*$$//')
42-
4338
# PKG is the package name of node problem detector repo.
4439
PKG:=k8s.io/node-problem-detector
4540

@@ -264,11 +259,7 @@ endif
264259
# Build should be cached from build-container
265260
docker buildx build --push --platform $(DOCKER_PLATFORMS) -t $(IMAGE) --build-arg BASEIMAGE=$(BASEIMAGE) --build-arg LOGCOUNTER=$(LOGCOUNTER) .
266261

267-
push-tar: build-tar
268-
gsutil cp $(TARBALL) $(UPLOAD_PATH)/node-problem-detector/
269-
gsutil cp node-problem-detector-$(VERSION)-*.tar.gz* $(UPLOAD_PATH)/node-problem-detector/
270-
271-
push: push-container push-tar
262+
push: push-container build-tar
272263

273264
coverage.out:
274265
rm -f coverage.out

0 commit comments

Comments
 (0)