refactor(tsfmt): change editorconfig post processing logic

Author: vvakame

lib/provider/editorconfig.ts

@@ -45,7 +45,7 @@ export default function makeFormatCodeOptions(fileName: string, opts: Options, f
 }
 
 
-export function postProcess(fileName: string, formattedCode: string, opts: Options, formatOptions: ts.FormatCodeOptions): Promise<string> {
+export function postProcess(fileName: string, formattedCode: string, opts: Options, _formatOptions: ts.FormatCodeOptions): Promise<string> {
 
     if (opts.verbose && opts.baseDir && !emitBaseDirWarning) {
         console.log("editorconfig is not supported baseDir options");
@@ -55,8 +55,8 @@ export function postProcess(fileName: string, formattedCode: string, opts: Optio
     return editorconfig
         .parse(fileName)
         .then(config => {
-            if (config.insert_final_newline) {
-                return formattedCode.replace(/\s+$/, formatOptions.NewLineCharacter);
+            if (config.insert_final_newline && !/\n$/.test(formattedCode)) {
+                formattedCode += "\n";
             }
             return formattedCode;
         });

test/expected/editorconfig/insert_final_newline/main.json

@@ -0,0 +1,17 @@
+{
+  "IndentSize": 4,
+  "TabSize": 4,
+  "IndentStyle": 2,
+  "NewLineCharacter": "\r\n",
+  "ConvertTabsToSpaces": true,
+  "InsertSpaceAfterCommaDelimiter": true,
+  "InsertSpaceAfterSemicolonInForStatements": true,
+  "InsertSpaceBeforeAndAfterBinaryOperators": true,
+  "InsertSpaceAfterKeywordsInControlFlowStatements": true,
+  "InsertSpaceAfterFunctionKeywordForAnonymousFunctions": false,
+  "InsertSpaceAfterOpeningAndBeforeClosingNonemptyParenthesis": false,
+  "InsertSpaceAfterOpeningAndBeforeClosingNonemptyBrackets": false,
+  "InsertSpaceAfterOpeningAndBeforeClosingTemplateStringBraces": false,
+  "PlaceOpenBraceOnNewLineForFunctions": false,
+  "PlaceOpenBraceOnNewLineForControlBlocks": false
+}

test/expected/editorconfig/insert_final_newline/main.ts

@@ -0,0 +1 @@
+console.log("test");

test/fixture/editorconfig/insert_final_newline/.editorconfig

@@ -0,0 +1,7 @@
+# EditorConfig is awesome: http://EditorConfig.org
+
+# top-most EditorConfig file
+root = true
+
+[*]
+insert_final_newline=true

test/fixture/editorconfig/insert_final_newline/main.ts

@@ -0,0 +1 @@
+console.log("test");