Add Date comparison in deepEqual function (#4638)

Author: YoanChapron

src/util/helpers.ts

@@ -130,6 +130,11 @@ export function getNestedValue (obj: any, path: (string | number)[], fallback?:
 export function deepEqual (a: any, b: any): boolean {
   if (a === b) return true
 
+  if (a instanceof Date && b instanceof Date) {
+    // If the values are Date, they were convert to timestamp with getTime and compare it
+    if (a.getTime() !== b.getTime()) return false
+  }
+
   if (a !== Object(a) || b !== Object(b)) {
     // If the values aren't objects, they were already checked for equality
     return false

test/unit/util/helpers.spec.js

@@ -84,6 +84,15 @@ test('helpers.js', () => {
     expect(deepEqual({x: 1}, {})).toEqual(false)
     expect(deepEqual({x: {a: 1, b: 2}}, {x: {a: 1, b: 2}})).toEqual(true)
 
+    // Date
+    const currentDate = new Date
+    const futureDate = new Date(1000)
+
+    expect(deepEqual(currentDate, currentDate)).toEqual(true)
+    expect(deepEqual({date: currentDate}, {date: currentDate})).toEqual(true)
+    expect(deepEqual(currentDate, futureDate)).toEqual(false)
+    expect(deepEqual({date: currentDate}, {date: futureDate})).toEqual(false)
+
     const circular = {}
     circular.me = circular