Skip to content

Commit 33d1652

Browse files
committed
fix(VSlider): use a text input internally
firefox sliders don't play well with the css reset fixes #4464
1 parent 15012f8 commit 33d1652

File tree

2 files changed

+2
-16
lines changed

2 files changed

+2
-16
lines changed

src/components/VSlider/VSlider.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -233,13 +233,13 @@ export default {
233233
return children
234234
},
235235
genListeners () {
236-
return Object.assign({}, {
236+
return {
237237
blur: this.onBlur,
238238
click: this.onSliderClick,
239239
focus: this.onFocus,
240240
keydown: this.onKeyDown,
241241
keyup: this.onKeyUp
242-
})
242+
}
243243
},
244244
genInput () {
245245
return this.$createElement('input', {
@@ -248,7 +248,6 @@ export default {
248248
name: this.name,
249249
role: 'slider',
250250
tabindex: this.disabled ? -1 : this.$attrs.tabindex,
251-
type: 'range',
252251
value: this.internalValue,
253252
readonly: true,
254253
'aria-readonly': String(this.readonly)

test/unit/components/VSlider/__snapshots__/VSlider.spec.js.snap

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ exports[`VSlider.vue should change track styles in rtl 1`] = `
77
<div class="v-input__slot">
88
<div class="v-slider">
99
<input role="slider"
10-
type="range"
1110
value="0"
1211
readonly="readonly"
1312
aria-readonly="false"
@@ -46,7 +45,6 @@ exports[`VSlider.vue should change track styles in rtl 2`] = `
4645
<div class="v-input__slot">
4746
<div class="v-slider">
4847
<input role="slider"
49-
type="range"
5048
value="50"
5149
readonly="readonly"
5250
aria-readonly="false"
@@ -85,7 +83,6 @@ exports[`VSlider.vue should change track styles in rtl 3`] = `
8583
<div class="v-input__slot">
8684
<div class="v-slider">
8785
<input role="slider"
88-
type="range"
8986
value="50"
9087
readonly="readonly"
9188
aria-readonly="false"
@@ -125,7 +122,6 @@ exports[`VSlider.vue should change track styles in rtl 4`] = `
125122
<div class="v-input__slot">
126123
<div class="v-slider">
127124
<input role="slider"
128-
type="range"
129125
value="0"
130126
readonly="readonly"
131127
aria-readonly="false"
@@ -164,7 +160,6 @@ exports[`VSlider.vue should change track styles in rtl 5`] = `
164160
<div class="v-input__slot">
165161
<div class="v-slider">
166162
<input role="slider"
167-
type="range"
168163
value="50"
169164
readonly="readonly"
170165
aria-readonly="false"
@@ -203,7 +198,6 @@ exports[`VSlider.vue should change track styles in rtl 6`] = `
203198
<div class="v-input__slot">
204199
<div class="v-slider">
205200
<input role="slider"
206-
type="range"
207201
value="50"
208202
readonly="readonly"
209203
aria-readonly="false"
@@ -243,7 +237,6 @@ exports[`VSlider.vue should match a snapshot 1`] = `
243237
<div class="v-input__slot">
244238
<div class="v-slider">
245239
<input role="slider"
246-
type="range"
247240
value="0"
248241
readonly="readonly"
249242
aria-readonly="false"
@@ -282,7 +275,6 @@ exports[`VSlider.vue should render component with thumbLabel and match a snapsho
282275
<div class="v-input__slot">
283276
<div class="v-slider">
284277
<input role="slider"
285-
type="range"
286278
value="0"
287279
readonly="readonly"
288280
aria-readonly="false"
@@ -332,7 +324,6 @@ exports[`VSlider.vue should render component with thumbLabel and match a snapsho
332324
<div class="v-input__slot">
333325
<div class="v-slider">
334326
<input role="slider"
335-
type="range"
336327
value="0"
337328
readonly="readonly"
338329
aria-readonly="false"
@@ -382,7 +373,6 @@ exports[`VSlider.vue should render component with ticks and match a snapshot 1`]
382373
<div class="v-input__slot">
383374
<div class="v-slider">
384375
<input role="slider"
385-
type="range"
386376
value="0"
387377
readonly="readonly"
388378
aria-readonly="false"
@@ -443,7 +433,6 @@ exports[`VSlider.vue should render component with ticks and match a snapshot 2`]
443433
<div class="v-input__slot">
444434
<div class="v-slider">
445435
<input role="slider"
446-
type="range"
447436
value="0"
448437
readonly="readonly"
449438
aria-readonly="false"
@@ -511,7 +500,6 @@ exports[`VSlider.vue should reverse label location when inverse 1`] = `
511500
<div class="v-slider">
512501
<input aria-label="foo"
513502
role="slider"
514-
type="range"
515503
value="0"
516504
readonly="readonly"
517505
aria-readonly="false"
@@ -551,7 +539,6 @@ exports[`VSlider.vue should reverse label location when inverse 2`] = `
551539
<div class="v-slider">
552540
<input aria-label="foo"
553541
role="slider"
554-
type="range"
555542
value="0"
556543
readonly="readonly"
557544
aria-readonly="false"

0 commit comments

Comments
 (0)