fix(v-toolbar): fix a fix

added unncessary prop, also fixed logic preventing inverted scroll from working properly

Author: johnleider

src/components/VToolbar/VToolbar.js

@@ -9,6 +9,7 @@ import SSRBootable from '../../mixins/ssr-bootable'
 
 // Directives
 import Scroll from '../../directives/scroll'
+import { deprecate } from '../../util/console'
 
 /* @vue/component */
 export default {
@@ -49,6 +50,7 @@ export default {
     manualScroll: Boolean,
     prominent: Boolean,
     scrollOffScreen: Boolean,
+    /* @deprecated */
     scrollToolbarOffScreen: Boolean,
     scrollTarget: String,
     scrollThreshold: {
@@ -77,6 +79,16 @@ export default {
   }),
 
   computed: {
+    canScroll () {
+      // TODO: remove
+      if (this.scrollToolbarOffScreen) {
+        deprecate('scrollToolbarOffScreen', 'scrollOffScreen', this)
+
+        return true
+      }
+
+      return this.scrollOffScreen || this.invertedScroll
+    },
     computedContentHeight () {
       if (this.height) return parseInt(this.height)
       if (this.dense) return this.heights.dense
@@ -112,7 +124,7 @@ export default {
         'v-toolbar': true,
         'elevation-0': this.flat || (!this.isActive &&
           !this.tabs &&
-          !this.scrollToolbarOffScreen
+          this.canScroll
         ),
         'v-toolbar--absolute': this.absolute,
         'v-toolbar--card': this.card,
@@ -138,7 +150,7 @@ export default {
     },
     computedTransform () {
       return !this.isActive
-        ? this.scrollToolbarOffScreen
+        ? this.canScroll
           ? -this.computedContentHeight
           : -this.computedHeight
         : 0
@@ -197,8 +209,7 @@ export default {
 
   methods: {
     onScroll () {
-      if ((!this.scrollOffScreen &&
-        !this.scrollToolbarOffScreen) ||
+      if (!this.canScroll ||
         this.manualScroll ||
         typeof window === 'undefined'
       ) return

test/unit/components/VToolbar/VToolbar.spec.js

@@ -10,6 +10,8 @@ const scrollWindow = y => {
   return new Promise(resolve => setTimeout(resolve, 200))
 }
 
+const deprecateScrollToolbarOffScreen = `'scrollToolbarOffScreen' is deprecated, use 'scrollOffScreen' instead`
+
 test('VToolbar.vue', ({ mount }) => {
   it('should render a colored toolbar', () => {
     const wrapper = mount(VToolbar, {
@@ -209,6 +211,7 @@ test('VToolbar.vue', ({ mount }) => {
     wrapper.setProps({ scrollToolbarOffScreen: true })
 
     expect(wrapper.vm.computedTransform).toBe(-56)
+    expect(deprecateScrollToolbarOffScreen).toHaveBeenTipped()
   })
 
   it('should have a custom extension height', () => {