fix(inputs): don't override aria-label attribute

fixes #4642

Author: KaelWD

src/components/VTextField/VTextField.js

@@ -314,12 +314,12 @@ export default {
           value: this.maskText(this.lazyValue)
         },
         attrs: {
+          'aria-label': (!this.$attrs || !this.$attrs.id) && this.label, // Label `for` will be set if we have an id
           ...this.$attrs,
           autofocus: this.autofocus,
           disabled: this.disabled,
           readonly: this.readonly,
-          type: this.type,
-          'aria-label': (!this.$attrs || !this.$attrs.id) && this.label // Label `for` will be set if we have an id
+          type: this.type
         },
         on: Object.assign(listeners, {
           blur: this.onBlur,

test/unit/components/VDataIterator/__snapshots__/VDataIterator.spec.js.snap

@@ -24,7 +24,8 @@ exports[`VDataIterator.js should match a snapshot - footer slot 1`] = `
                       <div class="v-select__selection v-select__selection--comma">
                         5
                       </div>
-                      <input readonly="readonly"
+                      <input aria-label="Items per page:"
+                             readonly="readonly"
                              type="text"
                              autocomplete="on"
                              aria-readonly="false"
@@ -162,7 +163,8 @@ exports[`VDataIterator.js should match a snapshot - no data 1`] = `
                       <div class="v-select__selection v-select__selection--comma">
                         5
                       </div>
-                      <input readonly="readonly"
+                      <input aria-label="Items per page:"
+                             readonly="readonly"
                              type="text"
                              autocomplete="on"
                              aria-readonly="false"
@@ -291,7 +293,8 @@ exports[`VDataIterator.js should match a snapshot - no matching records 1`] = `
                       <div class="v-select__selection v-select__selection--comma">
                         5
                       </div>
-                      <input readonly="readonly"
+                      <input aria-label="Items per page:"
+                             readonly="readonly"
                              type="text"
                              autocomplete="on"
                              aria-readonly="false"
@@ -424,7 +427,8 @@ exports[`VDataIterator.js should match a snapshot - with data 1`] = `
                       <div class="v-select__selection v-select__selection--comma">
                         5
                       </div>
-                      <input readonly="readonly"
+                      <input aria-label="Items per page:"
+                             readonly="readonly"
                              type="text"
                              autocomplete="on"
                              aria-readonly="false"

test/unit/components/VDataTable/__snapshots__/VDataTable.spec.js.snap

@@ -77,7 +77,8 @@ exports[`VDataTable.vue should match a snapshot - no data 1`] = `
                 <div class="v-menu__activator">
                   <div class="v-select__slot">
                     <div class="v-select__selections">
-                      <input readonly="readonly"
+                      <input aria-label="Rows per page:"
+                             readonly="readonly"
                              type="text"
                              autocomplete="on"
                              aria-readonly="false"
@@ -257,7 +258,8 @@ exports[`VDataTable.vue should match a snapshot - no matching results 1`] = `
                 <div class="v-menu__activator">
                   <div class="v-select__slot">
                     <div class="v-select__selections">
-                      <input readonly="readonly"
+                      <input aria-label="Rows per page:"
+                             readonly="readonly"
                              type="text"
                              autocomplete="on"
                              aria-readonly="false"
@@ -439,7 +441,8 @@ exports[`VDataTable.vue should match a snapshot - with data 1`] = `
                 <div class="v-menu__activator">
                   <div class="v-select__slot">
                     <div class="v-select__selections">
-                      <input readonly="readonly"
+                      <input aria-label="Rows per page:"
+                             readonly="readonly"
                              type="text"
                              autocomplete="on"
                              aria-readonly="false"

test/unit/components/VTextField/__snapshots__/VTextField.spec.js.snap

@@ -29,8 +29,8 @@ exports[`VTextField.js should apply theme to label, counter, messages and icons
         >
           foo
         </label>
-        <input type="text"
-               aria-label="foo"
+        <input aria-label="foo"
+               type="text"
         >
       </div>
       <div class="v-input__append-inner">