From 461b0d57b580d6746e054c7118d823ba7d45ffcf Mon Sep 17 00:00:00 2001 From: Carlos Rodrigues Date: Tue, 9 Jun 2020 16:30:09 +0100 Subject: [PATCH 1/2] fix: watch for chokidar v3 --- packages/@vuepress/core/lib/node/dev/index.js | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/packages/@vuepress/core/lib/node/dev/index.js b/packages/@vuepress/core/lib/node/dev/index.js index bec9a1de2c..556665ea38 100644 --- a/packages/@vuepress/core/lib/node/dev/index.js +++ b/packages/@vuepress/core/lib/node/dev/index.js @@ -207,8 +207,12 @@ module.exports = class DevProcess extends EventEmitter { publicPath: this.context.base, watchOptions: { ignored: [ - /node_modules/, - `!${this.context.tempPath}/**` + (x) => { + if (x.includes(this.context.tempPath)) { + return false + } + return /node_modules/.test(x) + } ] }, historyApiFallback: { @@ -235,6 +239,15 @@ module.exports = class DevProcess extends EventEmitter { WebpackDevServer.addDevServerEntrypoints(this.webpackConfig, serverConfig) const compiler = webpack(this.webpackConfig) + + // serverConfig.watchOptions.persisted = true; + // serverConfig.watchContentBase = true + // serverConfig.liveReload = true + // serverConfig.contentBase= [ + // this.context.sourceDir+ '\\*', + // contentBase + // ] + console.log('server config dev server', this.webpackConfig) this.server = new WebpackDevServer(compiler, serverConfig) return this } From d3644f93f6935c73f6aea797c287d5dad5adae57 Mon Sep 17 00:00:00 2001 From: Carlos Rodrigues Date: Tue, 9 Jun 2020 16:33:51 +0100 Subject: [PATCH 2/2] chore: remove comments --- packages/@vuepress/core/lib/node/dev/index.js | 9 --------- 1 file changed, 9 deletions(-) diff --git a/packages/@vuepress/core/lib/node/dev/index.js b/packages/@vuepress/core/lib/node/dev/index.js index 556665ea38..224de1707a 100644 --- a/packages/@vuepress/core/lib/node/dev/index.js +++ b/packages/@vuepress/core/lib/node/dev/index.js @@ -239,15 +239,6 @@ module.exports = class DevProcess extends EventEmitter { WebpackDevServer.addDevServerEntrypoints(this.webpackConfig, serverConfig) const compiler = webpack(this.webpackConfig) - - // serverConfig.watchOptions.persisted = true; - // serverConfig.watchContentBase = true - // serverConfig.liveReload = true - // serverConfig.contentBase= [ - // this.context.sourceDir+ '\\*', - // contentBase - // ] - console.log('server config dev server', this.webpackConfig) this.server = new WebpackDevServer(compiler, serverConfig) return this }