From 26b46482b71f97658a5f8b01adfc1b49bdf4d912 Mon Sep 17 00:00:00 2001
From: Ahmad Nassri <ahmad@ahmadnassri.com>
Date: Thu, 21 Feb 2019 12:25:39 -0500
Subject: [PATCH] feat(hero): improved hero header

- allow removing the h1 tag when `data.heroText` is `NULL`
- allow passing `data.heroAlt` to define alt text.

this is useful when `data.heroImage` can act as the "header"
---
 packages/@vuepress/theme-default/components/Home.vue | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/@vuepress/theme-default/components/Home.vue b/packages/@vuepress/theme-default/components/Home.vue
index e7748e13d5..6f94525dc7 100644
--- a/packages/@vuepress/theme-default/components/Home.vue
+++ b/packages/@vuepress/theme-default/components/Home.vue
@@ -4,10 +4,10 @@
       <img
         v-if="data.heroImage"
         :src="$withBase(data.heroImage)"
-        alt="hero"
+        :alt="data.heroAlt || 'hero'"
       >
 
-      <h1 id="main-title">{{ data.heroText || $title || 'Hello' }}</h1>
+      <h1 v-if="data.heroText !== null" id="main-title">{{ data.heroText || $title || 'Hello' }}</h1>
 
       <p class="description">
         {{ data.tagline || $description || 'Welcome to your VuePress site' }}