Skip to content

Why warning in custom container bu warn in built-in component Badge? #2080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
showmethecode9527 opened this issue Dec 14, 2019 · 1 comment · Fixed by #2085
Closed

Why warning in custom container bu warn in built-in component Badge? #2080

showmethecode9527 opened this issue Dec 14, 2019 · 1 comment · Fixed by #2085
Labels
has PR Has a related PR topic: docs Used when working with docs

Comments

@showmethecode9527
Copy link

Feature request

What problem does this feature solve?

When using warning custom containers, we write like this:

::: warning
This is a warning
:::

and when using warn(warning) Badge, we write like this:

<Badge text="beta" type="warn"/>

in custom containers is warning but in built-in component Badge is warn, why?

What does the proposed API look like?

<!-- use warning rather than warn -->
<Badge text="beta" type="warning"/>

How should this be implemented in your opinion?

use warning as a optional value in built-in component Badge rather than warn.

Are you willing to work on this yourself?

No.

@kefranabg
Copy link
Collaborator

kefranabg commented Dec 19, 2019

Actually warning value is already supported for the type property, but documentation is not up to date. I'll do an update.

@kefranabg kefranabg added topic: docs Used when working with docs has PR Has a related PR labels Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has PR Has a related PR topic: docs Used when working with docs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants