Skip to content

Standardize VS Code editor experience #1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bencodezen opened this issue Sep 9, 2019 · 7 comments
Open

Standardize VS Code editor experience #1847

bencodezen opened this issue Sep 9, 2019 · 7 comments
Assignees
Labels
complexity: easy Easy complexity effort: low Around a day or less priority: low Low priority issue status: core team assigned Core team member assigned

Comments

@bencodezen
Copy link
Member

Description

Contributors to VuePress should have a standard experience working on code and submitting PRs so that random style changes don't occur as a result.

@bencodezen bencodezen added priority: medium Medium priority issue complexity: easy Easy complexity effort: low Around a day or less status: core team assigned Core team member assigned labels Sep 9, 2019
@bencodezen bencodezen self-assigned this Sep 9, 2019
@bd82
Copy link

bd82 commented Sep 10, 2019

Is this an IDE problem or a CLI problem?
Are all contributors expected to code using VS Code?

Did you consider integrating an automated formatting tool? (e.g prettier)

@bencodezen
Copy link
Member Author

@bd82 I think it would be a mix. Ideally we'd have a pre-commit for linting and ensuring styles are enforced and consistent, but it would be nice to give VS Code contributors a more consistent experience.

@flozero
Copy link
Collaborator

flozero commented Sep 12, 2019

Actually we are using:

  • .eslintrc with 'plugin:vue-libs/recommended' and 'plugin:jest/recommended' with some special rules
  • we have and editorconfig
  • lint-staged that lint --fix on stage commit
  • husky but i dont see husky config or maybe i am missing something ?

@meteorlxy
Copy link
Member

Not related to this issue, but a VSCode extension for syntax of VuePress (i.e. vue in markdown) would be needed 😄

@ulivz
Copy link
Member

ulivz commented Sep 22, 2019

That's a good suggestion but maybe the priority would be relatively low. 😅

@ulivz ulivz added priority: low Low priority issue and removed priority: medium Medium priority issue labels Sep 22, 2019
@bencodezen
Copy link
Member Author

Great suggestion @meteorlxy! Will add that to the issue for when we work on it.

@billyyyyy3320
Copy link
Collaborator

Perhaps we can reuse it in official blog plugin and theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: easy Easy complexity effort: low Around a day or less priority: low Low priority issue status: core team assigned Core team member assigned
Projects
None yet
Development

No branches or pull requests

6 participants