Skip to content

Ability to add placeholder to SearchBox from config #1650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MaxHershey opened this issue Jun 10, 2019 · 0 comments · Fixed by #1834
Closed

Ability to add placeholder to SearchBox from config #1650

MaxHershey opened this issue Jun 10, 2019 · 0 comments · Fixed by #1834
Labels
complexity: easy Easy complexity type: feature request Request to add a new feature

Comments

@MaxHershey
Copy link

MaxHershey commented Jun 10, 2019 •
edited
Loading

Feature request

What problem does this feature solve?

Adds ability to add a placeholder to the search box component

What does the proposed API look like?

<SearchBox :placeholder="someStringHere" />
or

themeConfig: {
  search: {
     placeholder: someStringHere
  }
}

How should this be implemented in your opinion?

As a config object on the themeConfig

Are you willing to work on this yourself?

No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
complexity: easy Easy complexity type: feature request Request to add a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat($theme): Add search box placeholder setting to theme-config
2 participants
@kefranabg @MaxHershey