Use header's slug as it is if possible #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
ulivz
requested changes
Apr 18, 2018
| @@ -59,10 +59,11 @@ exports.extractHeaders = (content, include = [], md) => { | |||
| tokens.forEach((t, i) => { | |||
| if (t.type === 'heading_open' && include.includes(t.tag)) { | |||
| const title = tokens[i + 1].content | |||
| const slug = t.attrs.find(([name]) => name === 'id')[1] | |||
There was a problem hiding this comment.
Avoid using Array.prototype.find since Buble doesn't polyfill for it and it won't work at IE11.
There was a problem hiding this comment.
lib/util only runs in Node so it's ok
There was a problem hiding this comment.
Oh, excuse me, I forget some important thing.
ulivz
reviewed
Apr 18, 2018
ulivz
approved these changes
Apr 18, 2018
|
Thanks! |
meteorlxy
added a commit
that referenced
this pull request
Jun 17, 2021
Co-authored-by: meteorlxy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue concerning missing slug link of sidebar.
Reproduction
The issue can even be reproduced in the official VuePress guide.
Why Not ...?link in sidebarWe can see that the guide page doesn't scroll to the
Why Not ...?header.Reason
The issue is caused by markdown-it's
typographer: trueoption, which is for beautification. By the option, three dots (...) are replaced with a single unicode character…. They are handled differently by slugify().When logging the tokens,
tokens[i + 1].contentis nottypographer-ed, even its actual slug is.Fix
The token already has an attribute
idwhich is a correct and final result of the parser. Also, the slug is used for sidebar links later, so I guess it would be more proper to useidas it is.Please let me know if there is anything unclear.
Thanks!