Skip to content

ssrKey: false not working in useDocument #1504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
daviddomkar opened this issue Mar 10, 2024 · 1 comment
Closed

ssrKey: false not working in useDocument #1504

daviddomkar opened this issue Mar 10, 2024 · 1 comment

Comments

@daviddomkar
Copy link

Reproduction

Just set ssrKey to false - it will type warn and also still call onServerPrefetch

Steps to reproduce the bug

Just set ssrKey to false - it will type warn and also still call onServerPrefetch

Expected behavior

I would expect setting ssrKey to false disables onServerPrefetch and have correct typings.

Actual behavior

setting ssrKey to false type warns and also still calls onServerPrefetch

Additional information

I followed the documentation here: https://vuefire.vuejs.org/guide/ssr.html#Exclude-from-hydration from the behavior and the code in this repo it seems that the feature is not yet implemented?

@posva posva closed this as completed in 687ce09 Mar 22, 2024
@posva
Copy link
Member

posva commented Mar 22, 2024

It's not implemented yet so in the meantime, I removed it from docs. If you want to implement it, feel free to submit a PR though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants