-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
Passing empty string into boolean type prop result in true #5959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Seems this is intended, found the code here: https://github.com/vuejs/vue/blob/dev/src/core/util/props.js#L27 Is there any background reason for this? |
@gebilaoxiong i found wrong commit so i delete that 😂 |
Found it in docs as well...https://vuejs.org/v2/guide/migration.html#Built-In-Directives Maybe we should make this more clear in component section? |
You're welcome to submit a PR to Vue docs repo :) |
Version
2.3.4
Reproduction link
https://jsfiddle.net/u2mo75oo/2/
Steps to reproduce
run repro
What is expected?
comp.name
to be false or get warning.What is actually happening?
comp.name
is true.The text was updated successfully, but these errors were encountered: