Skip to content

Return type of HTMLElement is not correct #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
steverep opened this issue Jan 9, 2023 · 1 comment · May be fixed by #127
Open

Return type of HTMLElement is not correct #126

steverep opened this issue Jan 9, 2023 · 1 comment · May be fixed by #127

Comments

@steverep
Copy link

steverep commented Jan 9, 2023

The return type for Wrap is incorrectly typed as HTMLElement. The function returns the class, i.e. the component constructor, and not an actual element, i.e. an instance of that constructor. The return type should be CustomElementConstructor or something more narrow.
This was referenced Jan 9, 2023
Open
Merged
@bghandou
Copy link

This is still an issue unfortunately. cf. my comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct return type to CustomElementConstructor steverep/vue-web-component-wrapper
2 participants
@steverep @bghandou