Skip to content

allow array for multiselect .setValue() method #1554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 22, 2020
Merged

allow array for multiselect .setValue() method #1554

merged 4 commits into from
May 22, 2020

Conversation

bugy
Copy link
Contributor

@bugy bugy commented May 21, 2020

enables Wrapper.setValue() method to accept array value for select elements (requires select to have an attribute 'multiple' or 'multiple="true"')

fix #1505

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

enables Wrapper.setValue() method to accept array value for select elements (requires select to have
an attribute 'multiple' or 'multiple="true"')

fix #1505
@lmiller1990 lmiller1990 self-requested a review May 22, 2020 10:39
Copy link
Member

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this looks good!

Great job! I'll get one more review and merge.

Copy link
Member

@afontcu afontcu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just added some small suggestions on test naming :)

bugy and others added 2 commits May 22, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow array values for select.setValue
3 participants