feat: support object class binding in stubbed functional components #1476
Conversation
| // see https://github.com/vuejs/vue-test-utils/issues/1474 for more context. | ||
| if (typeof dynamicClass === 'object') { | ||
| evaluatedDynamicClass = Object.keys(dynamicClass).reduce((acc, key) => { | ||
| if (dynamicClass[key] === true) { |
There was a problem hiding this comment.
Should we check if this is a truthy value or like this, straight up true?
There was a problem hiding this comment.
Not sure, I just went with this to be explicit. I haven't seen people use something like :class={ 'my-class': 'some-truthy-val' }. I guess we should just copy whatever Vue does - will try it out.
| } | ||
| return staticClass || dynamicClass | ||
| return staticClass || evaluatedDynamicClass |
There was a problem hiding this comment.
Wouldnt have pushing all to an array and using join(' ') at the end been a more cleaner way of doing this?
There was a problem hiding this comment.
I think both are fine - was having problems iterating over Object.keys, using of throws some warning. A few other places in the codebase do Object.keys().reduce so I just tried to follow that same style.
I like reduce but I don't mind either way.
lmiller1990
deleted the
feature/1474_support_dynamic_class_in_functional_component
branch
|
gg |
|
What's the release process please? |
fixes #1474