Skip to content

docs: mounting options is attachToDocument #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 8, 2019
Merged

docs: mounting options is attachToDocument #1171

merged 2 commits into from
Mar 8, 2019

Conversation

marcoleong
Copy link
Contributor

mounting options in wrapper is attachToDocument

@marcoleong
Update README.md
2dc78ae 
mounting options in wrapper is `attachToDocument`
@eddyerburgh
Copy link
Member

Thanks for this, can you also update the same line in the translations (ja, zh,and ru)?

@marcoleong
Copy link
Contributor Author

Updated

eddyerburgh
eddyerburgh approved these changes Mar 8, 2019
View reviewed changes
Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks :)

@eddyerburgh eddyerburgh merged commit 839402b into vuejs:dev Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyerburgh eddyerburgh eddyerburgh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcoleong @eddyerburgh