From 076f4042de086419d3738a00b510b641d3f23238 Mon Sep 17 00:00:00 2001
From: eddyerburgh <edward.yerburgh@gmail.com>
Date: Sun, 3 Feb 2019 14:51:55 +0000
Subject: [PATCH 1/6] test: use sandbox to avoid memory leaks in test

---
 test/specs/components/TransitionStub.spec.js  |  8 +++----
 test/specs/config.spec.js                     | 13 ++++++-----
 test/specs/mount.spec.js                      | 16 ++++++++------
 test/specs/mounting-options/mocks.spec.js     |  7 +++---
 .../mounting-options/scopedSlots.spec.js      |  4 +++-
 test/specs/mounting-options/stubs.spec.js     | 10 +++------
 test/specs/mounting-options/sync.spec.js      | 11 +++++-----
 test/specs/shallow-mount.spec.js              |  9 ++++----
 test/specs/wrapper-array.spec.js              | 18 +++++++++------
 test/specs/wrapper-array/trigger.spec.js      | 10 ++++++---
 test/specs/wrapper/destroy.spec.js            | 17 ++++++++------
 test/specs/wrapper/setData.spec.js            |  8 +++----
 test/specs/wrapper/setProps.spec.js           |  9 ++++----
 test/specs/wrapper/trigger.spec.js            | 22 ++++++++-----------
 14 files changed, 87 insertions(+), 75 deletions(-)

diff --git a/test/specs/components/TransitionStub.spec.js b/test/specs/components/TransitionStub.spec.js
index 17594edab..f30d7d5f1 100644
--- a/test/specs/components/TransitionStub.spec.js
+++ b/test/specs/components/TransitionStub.spec.js
@@ -3,14 +3,14 @@ import { describeWithShallowAndMount } from '~resources/utils'
 import { TransitionStub } from '~vue/test-utils'
 
 describeWithShallowAndMount('TransitionStub', mountingMethod => {
-  let consoleError
+  const sandbox = sinon.createSandbox()
 
   beforeEach(() => {
-    consoleError = sinon.stub(console, 'error')
+    sandbox.stub(console, 'error').callThrough()
   })
 
   afterEach(() => {
-    consoleError.restore()
+    sandbox.restore()
   })
 
   it('update synchronously when used as stubs for Transition', () => {
@@ -63,7 +63,7 @@ describeWithShallowAndMount('TransitionStub', mountingMethod => {
         transition: TransitionStub
       }
     })
-    expect(consoleError).calledWith(msg)
+    expect(console.error).calledWith(msg)
   })
 
   it('handles keyed transitions', () => {
diff --git a/test/specs/config.spec.js b/test/specs/config.spec.js
index 4261aa198..0cfebe3ad 100644
--- a/test/specs/config.spec.js
+++ b/test/specs/config.spec.js
@@ -9,20 +9,23 @@ import {
 } from '~vue/test-utils'
 
 describeWithShallowAndMount('config', mountingMethod => {
-  let configStubsSave, configLogSave, configSilentSave
+  const sandbox = sinon.createSandbox()
+  let configStubsSave
+  let configLogSave
+  let configSilentSave
 
   beforeEach(() => {
     configStubsSave = config.stubs
     configLogSave = config.logModifiedComponents
     configSilentSave = config.silent
-    sinon.stub(console, 'error').callThrough()
+    sandbox.stub(console, 'error').callThrough()
   })
 
   afterEach(() => {
     config.stubs = configStubsSave
     config.logModifiedComponents = configLogSave
     config.silent = configSilentSave
-    console.error.restore()
+    sandbox.restore()
   })
 
   itDoNotRunIf(
@@ -149,7 +152,7 @@ describeWithShallowAndMount('config', mountingMethod => {
     wrapper.setProps({
       prop1: 'new value'
     })
-    expect(console.error).not.calledWith(sinon.match('[Vue warn]'))
+    expect(console.error).not.calledWith(sandbox.match('[Vue warn]'))
   })
 
   it('does throw Vue warning when silent is set to false', () => {
@@ -165,6 +168,6 @@ describeWithShallowAndMount('config', mountingMethod => {
     wrapper.setProps({
       prop1: 'new value'
     })
-    expect(console.error).calledWith(sinon.match('[Vue warn]'))
+    expect(console.error).calledWith(sandbox.match('[Vue warn]'))
   })
 })
diff --git a/test/specs/mount.spec.js b/test/specs/mount.spec.js
index 882457568..a2c3e9682 100644
--- a/test/specs/mount.spec.js
+++ b/test/specs/mount.spec.js
@@ -10,15 +10,16 @@ import { describeRunIf, itDoNotRunIf, itSkipIf } from 'conditional-specs'
 import Vuex from 'vuex'
 
 describeRunIf(process.env.TEST_ENV !== 'node', 'mount', () => {
+  const sandbox = sinon.createSandbox()
   const windowSave = window
 
   beforeEach(() => {
-    sinon.stub(console, 'error').callThrough()
+    sandbox.stub(console, 'error').callThrough()
   })
 
   afterEach(() => {
     window = windowSave // eslint-disable-line no-native-reassign
-    console.error.restore()
+    sandbox.restore()
   })
 
   it('returns new VueWrapper with mounted Vue instance if no options are passed', () => {
@@ -126,10 +127,11 @@ describeRunIf(process.env.TEST_ENV !== 'node', 'mount', () => {
   )
 
   it('does not use cached component', () => {
-    ComponentWithMixin.methods.someMethod = sinon.stub()
+    sandbox.stub(ComponentWithMixin.methods, 'someMethod')
     mount(ComponentWithMixin)
     expect(ComponentWithMixin.methods.someMethod.callCount).to.equal(1)
-    ComponentWithMixin.methods.someMethod = sinon.stub()
+    ComponentWithMixin.methods.someMethod.restore()
+    sandbox.stub(ComponentWithMixin.methods, 'someMethod')
     mount(ComponentWithMixin)
     expect(ComponentWithMixin.methods.someMethod.callCount).to.equal(1)
   })
@@ -160,7 +162,7 @@ describeRunIf(process.env.TEST_ENV !== 'node', 'mount', () => {
   })
 
   itDoNotRunIf(vueVersion < 2.3, 'overrides methods', () => {
-    const stub = sinon.stub()
+    const stub = sandbox.stub()
     const TestComponent = Vue.extend({
       template: '<div />',
       methods: {
@@ -179,8 +181,8 @@ describeRunIf(process.env.TEST_ENV !== 'node', 'mount', () => {
   })
 
   it.skip('overrides component prototype', () => {
-    const mountSpy = sinon.spy()
-    const destroySpy = sinon.spy()
+    const mountSpy = sandbox.spy()
+    const destroySpy = sandbox.spy()
     const Component = Vue.extend({})
     const {
       $mount: originalMount,
diff --git a/test/specs/mounting-options/mocks.spec.js b/test/specs/mounting-options/mocks.spec.js
index a3c437ae0..bcd356cc5 100644
--- a/test/specs/mounting-options/mocks.spec.js
+++ b/test/specs/mounting-options/mocks.spec.js
@@ -6,17 +6,18 @@ import { describeWithMountingMethods, vueVersion } from '~resources/utils'
 import { itDoNotRunIf, itSkipIf, itRunIf } from 'conditional-specs'
 
 describeWithMountingMethods('options.mocks', mountingMethod => {
+  const sandbox = sinon.createSandbox()
   let configMocksSave
 
   beforeEach(() => {
     configMocksSave = config.mocks
     config.mocks = {}
-    sinon.stub(console, 'error')
+    sandbox.stub(console, 'error').callThrough()
   })
 
   afterEach(() => {
     config.mocks = configMocksSave
-    console.error.restore()
+    sandbox.restore()
   })
 
   it('adds variables to vm when passed', () => {
@@ -69,7 +70,7 @@ describeWithMountingMethods('options.mocks', mountingMethod => {
     mountingMethod.name === 'renderToString',
     'adds variables as reactive properties to vm when passed',
     () => {
-      const stub = sinon.stub()
+      const stub = sandbox.stub()
       const $reactiveMock = { value: 'value' }
       const wrapper = mountingMethod(
         {
diff --git a/test/specs/mounting-options/scopedSlots.spec.js b/test/specs/mounting-options/scopedSlots.spec.js
index c65d1cb38..7b34febc4 100644
--- a/test/specs/mounting-options/scopedSlots.spec.js
+++ b/test/specs/mounting-options/scopedSlots.spec.js
@@ -4,10 +4,12 @@ import ComponentWithScopedSlots from '~resources/components/component-with-scope
 import { itDoNotRunIf } from 'conditional-specs'
 
 describeWithShallowAndMount('scopedSlots', mountingMethod => {
+  const sandbox = sinon.createSandbox()
   const windowSave = window
 
   afterEach(() => {
     window = windowSave // eslint-disable-line no-native-reassign
+    sandbox.restore()
   })
 
   itDoNotRunIf(vueVersion < 2.1, 'handles templates as the root node', () => {
@@ -248,7 +250,7 @@ describeWithShallowAndMount('scopedSlots', mountingMethod => {
           return this.$scopedSlots.default(this.val)
         }
       }
-      const stub = sinon.stub()
+      const stub = sandbox.stub()
       mountingMethod(TestComponent, {
         scopedSlots: {
           default: stub
diff --git a/test/specs/mounting-options/stubs.spec.js b/test/specs/mounting-options/stubs.spec.js
index 0c0cd1996..9b0d59a4e 100644
--- a/test/specs/mounting-options/stubs.spec.js
+++ b/test/specs/mounting-options/stubs.spec.js
@@ -9,14 +9,11 @@ import { describeWithMountingMethods, vueVersion } from '~resources/utils'
 import { itDoNotRunIf, itSkipIf, itRunIf } from 'conditional-specs'
 
 describeWithMountingMethods('options.stub', mountingMethod => {
-  let info
-  let warn
+  const sandbox = sinon.createSandbox()
   let configStubsSave
   let serverConfigSave
 
   beforeEach(() => {
-    info = sinon.stub(console, 'info')
-    warn = sinon.stub(console, 'error')
     configStubsSave = config.stubs
     serverConfigSave = serverConfig.stubs
     config.stubs = {}
@@ -24,8 +21,7 @@ describeWithMountingMethods('options.stub', mountingMethod => {
   })
 
   afterEach(() => {
-    info.restore()
-    warn.restore()
+    sandbox.restore()
     config.stubs = configStubsSave
     serverConfig.stubs = serverConfigSave
   })
@@ -64,7 +60,7 @@ describeWithMountingMethods('options.stub', mountingMethod => {
     mountingMethod.name === 'renderToString',
     'replaces component with a component',
     () => {
-      const mounted = sinon.stub()
+      const mounted = sandbox.stub()
       const Stub = {
         template: '<div />',
         mounted
diff --git a/test/specs/mounting-options/sync.spec.js b/test/specs/mounting-options/sync.spec.js
index 385b2b7fe..b0395caa6 100644
--- a/test/specs/mounting-options/sync.spec.js
+++ b/test/specs/mounting-options/sync.spec.js
@@ -1,14 +1,15 @@
-import sinon from 'sinon'
 import { describeWithShallowAndMount, vueVersion } from '~resources/utils'
 import { itDoNotRunIf } from 'conditional-specs'
 
 describeWithShallowAndMount('options.sync', mountingMethod => {
+  const sandbox = sinon.createSandbox()
+
   beforeEach(() => {
-    sinon.stub(console, 'error').callThrough()
+    sandbox.stub(console, 'error').callThrough()
   })
 
   afterEach(() => {
-    console.error.restore()
+    sandbox.restore()
   })
 
   it('sets watchers to sync if set to true', () => {
@@ -124,7 +125,7 @@ describeWithShallowAndMount('options.sync', mountingMethod => {
   })
 
   it('call updated when sync is not false', () => {
-    const childComponentSpy = sinon.stub()
+    const childComponentSpy = sandbox.stub()
     const ChildComponent = {
       template: '<div>{{ foo }}</div>',
       props: ['foo'],
@@ -132,7 +133,7 @@ describeWithShallowAndMount('options.sync', mountingMethod => {
         childComponentSpy()
       }
     }
-    const spy = sinon.stub()
+    const spy = sandbox.stub()
     const TestComponent = {
       template: '<div>{{ foo }}<child-component :foo="foo" /></div>',
       data() {
diff --git a/test/specs/shallow-mount.spec.js b/test/specs/shallow-mount.spec.js
index df07a232b..e0b5d888c 100644
--- a/test/specs/shallow-mount.spec.js
+++ b/test/specs/shallow-mount.spec.js
@@ -12,9 +12,10 @@ import { vueVersion } from '~resources/utils'
 import { describeRunIf, itDoNotRunIf } from 'conditional-specs'
 
 describeRunIf(process.env.TEST_ENV !== 'node', 'shallowMount', () => {
+  const sandbox = sinon.createSandbox()
   beforeEach(() => {
-    sinon.stub(console, 'info').callThrough()
-    sinon.stub(console, 'error').callThrough()
+    sandbox.stub(console, 'info').callThrough()
+    sandbox.stub(console, 'error').callThrough()
   })
 
   afterEach(() => {
@@ -149,7 +150,7 @@ describeRunIf(process.env.TEST_ENV !== 'node', 'shallowMount', () => {
         }
       }
       shallowMount(TestComponent)
-      expect(console.error).not.calledWith(sinon.match('[Vue warn]'))
+      expect(console.error).not.calledWith(sandbox.match('[Vue warn]'))
     }
   )
 
@@ -549,7 +550,7 @@ describeRunIf(process.env.TEST_ENV !== 'node', 'shallowMount', () => {
       shallowMount(TestComponent)
       mount(TestComponent)
       expect(console.error).not.calledWith(
-        sinon.match('Unknown custom element')
+        sandbox.match('Unknown custom element')
       )
     }
   )
diff --git a/test/specs/wrapper-array.spec.js b/test/specs/wrapper-array.spec.js
index a2d60ad3f..45c31ec8b 100644
--- a/test/specs/wrapper-array.spec.js
+++ b/test/specs/wrapper-array.spec.js
@@ -2,6 +2,10 @@ import { Wrapper, WrapperArray } from '~vue/test-utils'
 import { describeWithShallowAndMount } from '~resources/utils'
 
 describeWithShallowAndMount('WrapperArray', mountingMethod => {
+  const sandbox = sinon.createSandbox()
+
+  afterEach(sandbox.restore)
+
   function getWrapperArray(wrappers) {
     if (!wrappers) {
       wrappers = [1, 2, 3].map(v => {
@@ -142,7 +146,7 @@ describeWithShallowAndMount('WrapperArray', mountingMethod => {
 
   it('contains returns true if every wrapper.contains() returns true', () => {
     const selector = 'selector'
-    const contains = sinon.stub()
+    const contains = sandbox.stub()
     contains.withArgs(selector).returns(true)
     const wrapperArray = getWrapperArray([{ contains }, { contains }])
     expect(wrapperArray.contains(selector)).to.equal(true)
@@ -158,7 +162,7 @@ describeWithShallowAndMount('WrapperArray', mountingMethod => {
 
   it('is returns true if every wrapper.is() returns true', () => {
     const selector = 'selector'
-    const is = sinon.stub()
+    const is = sandbox.stub()
     is.withArgs(selector).returns(true)
     const wrapperArray = getWrapperArray([{ is }, { is }])
     expect(wrapperArray.is(selector)).to.equal(true)
@@ -221,7 +225,7 @@ describeWithShallowAndMount('WrapperArray', mountingMethod => {
   })
 
   it('setMethods calls setMethods on each wrapper', () => {
-    const setMethods = sinon.stub()
+    const setMethods = sandbox.stub()
     const methods = {}
     const wrapperArray = getWrapperArray([{ setMethods }, { setMethods }])
     wrapperArray.setMethods(methods)
@@ -230,7 +234,7 @@ describeWithShallowAndMount('WrapperArray', mountingMethod => {
   })
 
   it('setData calls setData on each wrapper', () => {
-    const setData = sinon.stub()
+    const setData = sandbox.stub()
     const data = {}
     const wrapperArray = getWrapperArray([{ setData }, { setData }])
     wrapperArray.setData(data)
@@ -239,7 +243,7 @@ describeWithShallowAndMount('WrapperArray', mountingMethod => {
   })
 
   it('setProps calls setProps on each wrapper', () => {
-    const setProps = sinon.stub()
+    const setProps = sandbox.stub()
     const props = {}
     const wrapperArray = getWrapperArray([{ setProps }, { setProps }])
     wrapperArray.setProps(props)
@@ -248,7 +252,7 @@ describeWithShallowAndMount('WrapperArray', mountingMethod => {
   })
 
   it('trigger calls trigger on each wrapper', () => {
-    const trigger = sinon.stub()
+    const trigger = sandbox.stub()
     const event = 'click'
     const options = {}
     const wrapperArray = getWrapperArray([{ trigger }, { trigger }])
@@ -258,7 +262,7 @@ describeWithShallowAndMount('WrapperArray', mountingMethod => {
   })
 
   it('destroy calls destroy on each wrapper', () => {
-    const destroy = sinon.stub()
+    const destroy = sandbox.stub()
     const wrapperArray = getWrapperArray([{ destroy }, { destroy }])
     wrapperArray.destroy()
     expect(destroy.calledTwice).to.equal(true)
diff --git a/test/specs/wrapper-array/trigger.spec.js b/test/specs/wrapper-array/trigger.spec.js
index 90b050f61..f25720f53 100644
--- a/test/specs/wrapper-array/trigger.spec.js
+++ b/test/specs/wrapper-array/trigger.spec.js
@@ -3,8 +3,12 @@ import ComponentWithEvents from '~resources/components/component-with-events.vue
 import { describeWithShallowAndMount } from '~resources/utils'
 
 describeWithShallowAndMount('trigger', mountingMethod => {
+  const sandbox = sinon.createSandbox()
+
+  afterEach(sandbox.restore)
+
   it('causes click handler to fire when wrapper.trigger("click") is called on a Component', () => {
-    const clickHandler = sinon.stub()
+    const clickHandler = sandbox.stub()
     const wrapper = mountingMethod(ComponentWithEvents, {
       propsData: { clickHandler }
     })
@@ -15,7 +19,7 @@ describeWithShallowAndMount('trigger', mountingMethod => {
   })
 
   it('causes keydown handler to fire when wrapper.trigger("keydown") is fired on a Component', () => {
-    const keydownHandler = sinon.stub()
+    const keydownHandler = sandbox.stub()
     const wrapper = mountingMethod(ComponentWithEvents, {
       propsData: { keydownHandler }
     })
@@ -25,7 +29,7 @@ describeWithShallowAndMount('trigger', mountingMethod => {
   })
 
   it('causes keydown handler to fire when wrapper.trigger("keydown.enter") is fired on a Component', () => {
-    const keydownHandler = sinon.stub()
+    const keydownHandler = sandbox.stub()
     const wrapper = mountingMethod(ComponentWithEvents, {
       propsData: { keydownHandler }
     })
diff --git a/test/specs/wrapper/destroy.spec.js b/test/specs/wrapper/destroy.spec.js
index e9f229c05..5e2283e4d 100644
--- a/test/specs/wrapper/destroy.spec.js
+++ b/test/specs/wrapper/destroy.spec.js
@@ -1,27 +1,30 @@
 import { describeWithShallowAndMount } from '~resources/utils'
-import sinon from 'sinon'
 
 describeWithShallowAndMount('destroy', mountingMethod => {
+  const sandbox = sinon.createSandbox()
+
+  afterEach(sandbox.restore)
+
   it('triggers beforeDestroy ', () => {
-    const spy = sinon.stub()
+    const stub = sandbox.stub()
     mountingMethod({
       render: () => {},
       beforeDestroy() {
-        spy()
+        stub()
       }
     }).destroy()
-    expect(spy.calledOnce).to.equal(true)
+    expect(stub.calledOnce).to.equal(true)
   })
 
   it('triggers destroy ', () => {
-    const spy = sinon.stub()
+    const stub = sandbox.stub()
     mountingMethod({
       render: () => {},
       destroyed() {
-        spy()
+        stub()
       }
     }).destroy()
-    expect(spy.calledOnce).to.equal(true)
+    expect(stub.calledOnce).to.equal(true)
   })
 
   it('removes element from document.body', () => {
diff --git a/test/specs/wrapper/setData.spec.js b/test/specs/wrapper/setData.spec.js
index ae6a6cf42..ca8ac2f53 100644
--- a/test/specs/wrapper/setData.spec.js
+++ b/test/specs/wrapper/setData.spec.js
@@ -4,14 +4,14 @@ import ComponentWithWatch from '~resources/components/component-with-watch.vue'
 import { describeWithShallowAndMount, vueVersion } from '~resources/utils'
 
 describeWithShallowAndMount('setData', mountingMethod => {
-  let info
+  const sandbox = sinon.createSandbox()
 
   beforeEach(() => {
-    info = sinon.stub(console, 'info')
+    sandbox.stub(console, 'info').callThrough()
   })
 
   afterEach(() => {
-    info.restore()
+    sandbox.restore()
   })
 
   it('sets component data and updates nested vm nodes when called on Vue instance', () => {
@@ -47,7 +47,7 @@ describeWithShallowAndMount('setData', mountingMethod => {
     const wrapper = mountingMethod(ComponentWithWatch)
     const data1 = 'testest'
     wrapper.setData({ data2: 'newProp', data1 })
-    expect(info.args[1][0]).to.equal(data1)
+    expect(console.info.args[1][0]).to.equal(data1)
   })
 
   it('throws error if node is not a Vue instance', () => {
diff --git a/test/specs/wrapper/setProps.spec.js b/test/specs/wrapper/setProps.spec.js
index 3cd09a37f..e3ed38923 100644
--- a/test/specs/wrapper/setProps.spec.js
+++ b/test/specs/wrapper/setProps.spec.js
@@ -5,14 +5,13 @@ import { describeWithShallowAndMount, vueVersion } from '~resources/utils'
 import { itDoNotRunIf } from 'conditional-specs'
 
 describeWithShallowAndMount('setProps', mountingMethod => {
-  let info
-
+  const sandbox = sinon.createSandbox()
   beforeEach(() => {
-    info = sinon.stub(console, 'info')
+    sandbox.stub(console, 'info').callThrough()
   })
 
   afterEach(() => {
-    info.restore()
+    sandbox.restore()
   })
 
   it('sets component props and updates DOM when called on Vue instance', () => {
@@ -121,7 +120,7 @@ describeWithShallowAndMount('setProps', mountingMethod => {
     const wrapper = mountingMethod(ComponentWithWatch)
     const prop1 = 'testest'
     wrapper.setProps({ prop2: 'newProp', prop1 })
-    expect(info.args[1][0]).to.equal(prop1)
+    expect(console.info.args[1][0]).to.equal(prop1)
   })
 
   it('should not run watchers if prop updated is null', () => {
diff --git a/test/specs/wrapper/trigger.spec.js b/test/specs/wrapper/trigger.spec.js
index 1859fa912..9406fc967 100644
--- a/test/specs/wrapper/trigger.spec.js
+++ b/test/specs/wrapper/trigger.spec.js
@@ -9,18 +9,14 @@ import Vue from 'vue'
 import { itDoNotRunIf } from 'conditional-specs'
 
 describeWithShallowAndMount('trigger', mountingMethod => {
-  let info
-
-  beforeEach(() => {
-    info = sinon.stub(console, 'info')
-  })
+  const sandbox = sinon.createSandbox()
 
   afterEach(() => {
-    info.restore()
+    sandbox.restore()
   })
 
   it('causes click handler to fire when wrapper.trigger("click") is called on a Component', () => {
-    const clickHandler = sinon.stub()
+    const clickHandler = sandbox.stub()
     const wrapper = mountingMethod(ComponentWithEvents, {
       propsData: { clickHandler }
     })
@@ -31,7 +27,7 @@ describeWithShallowAndMount('trigger', mountingMethod => {
   })
 
   it('causes keydown handler to fire when wrapper.trigger("keydown") is fired on a Component', () => {
-    const keydownHandler = sinon.stub()
+    const keydownHandler = sandbox.stub()
     const wrapper = mountingMethod(ComponentWithEvents, {
       propsData: { keydownHandler }
     })
@@ -41,7 +37,7 @@ describeWithShallowAndMount('trigger', mountingMethod => {
   })
 
   it('causes keydown handler to fire when wrapper.trigger("keydown.enter") is fired on a Component', () => {
-    const keydownHandler = sinon.stub()
+    const keydownHandler = sandbox.stub()
     const wrapper = mountingMethod(ComponentWithEvents, {
       propsData: { keydownHandler }
     })
@@ -68,7 +64,7 @@ describeWithShallowAndMount('trigger', mountingMethod => {
       pageup: 33,
       pagedown: 34
     }
-    const keyupHandler = sinon.stub()
+    const keyupHandler = sandbox.stub()
     const wrapper = mountingMethod(ComponentWithEvents, {
       propsData: { keyupHandler }
     })
@@ -88,7 +84,7 @@ describeWithShallowAndMount('trigger', mountingMethod => {
   })
 
   it('adds options to event', () => {
-    const clickHandler = sinon.stub()
+    const clickHandler = sandbox.stub()
     const wrapper = mountingMethod(ComponentWithEvents, {
       propsData: { clickHandler }
     })
@@ -103,7 +99,7 @@ describeWithShallowAndMount('trigger', mountingMethod => {
   })
 
   it('adds custom data to events', () => {
-    const stub = sinon.stub()
+    const stub = sandbox.stub()
     const TestComponent = {
       template: '<div @update="callStub" />',
       methods: {
@@ -123,7 +119,7 @@ describeWithShallowAndMount('trigger', mountingMethod => {
   })
 
   it('does not fire on disabled elements', () => {
-    const clickHandler = sinon.stub()
+    const clickHandler = sandbox.stub()
     const TestComponent = {
       template: '<button disabled @click="clickHandler"/>',
       props: ['clickHandler']

From 838c56dd96eedbc21d69b25950d24149d8e6a535 Mon Sep 17 00:00:00 2001
From: eddyerburgh <edward.yerburgh@gmail.com>
Date: Sun, 3 Feb 2019 15:05:02 +0000
Subject: [PATCH 2/6] chore: update sinon

---
 package.json |   6 +--
 yarn.lock    | 136 +++++++++++++++++++++++++++++++++++----------------
 2 files changed, 96 insertions(+), 46 deletions(-)

diff --git a/package.json b/package.json
index 6c501aaa2..4a24a7cf7 100644
--- a/package.json
+++ b/package.json
@@ -54,7 +54,7 @@
     "karma": "^1.7.0",
     "karma-mocha": "^1.3.0",
     "karma-phantomjs-launcher": "^1.0.4",
-    "karma-sinon-chai": "^1.3.1",
+    "karma-sinon-chai": "^2.0.2",
     "karma-sourcemap-loader": "^0.3.7",
     "karma-spec-reporter": "^0.0.31",
     "karma-webpack": "^2.0.3",
@@ -64,8 +64,8 @@
     "mocha-webpack": "^1.0.1",
     "prettier": "^1.16.0",
     "rollup": "^0.58.2",
-    "sinon": "^2.3.2",
-    "sinon-chai": "^2.10.0",
+    "sinon": "^7.2.3",
+    "sinon-chai": "^3.3.0",
     "typescript": "^3.0.1",
     "vee-validate": "^2.1.3",
     "vue": "2.5.21",
diff --git a/yarn.lock b/yarn.lock
index c6b21eee1..31b492ce8 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -738,6 +738,29 @@
     "@shellscape/koa-send" "^4.1.0"
     debug "^2.6.8"
 
+"@sinonjs/commons@^1.0.2", "@sinonjs/commons@^1.3.0":
+  version "1.3.0"
+  resolved "https://registry.yarnpkg.com/@sinonjs/commons/-/commons-1.3.0.tgz#50a2754016b6f30a994ceda6d9a0a8c36adda849"
+  integrity sha512-j4ZwhaHmwsCb4DlDOIWnI5YyKDNMoNThsmwEpfHx6a1EpsGZ9qYLxP++LMlmBRjtGptGHFsGItJ768snllFWpA==
+  dependencies:
+    type-detect "4.0.8"
+
+"@sinonjs/formatio@^3.1.0":
+  version "3.1.0"
+  resolved "https://registry.yarnpkg.com/@sinonjs/formatio/-/formatio-3.1.0.tgz#6ac9d1eb1821984d84c4996726e45d1646d8cce5"
+  integrity sha512-ZAR2bPHOl4Xg6eklUGpsdiIJ4+J1SNag1DHHrG/73Uz/nVwXqjgUtRPLoS+aVyieN9cSbc0E4LsU984tWcDyNg==
+  dependencies:
+    "@sinonjs/samsam" "^2 || ^3"
+
+"@sinonjs/samsam@^2 || ^3", "@sinonjs/samsam@^3.0.2":
+  version "3.0.2"
+  resolved "https://registry.yarnpkg.com/@sinonjs/samsam/-/samsam-3.0.2.tgz#304fb33bd5585a0b2df8a4c801fcb47fa84d8e43"
+  integrity sha512-m08g4CS3J6lwRQk1pj1EO+KEVWbrbXsmi9Pw0ySmrIbcVxVaedoFgLvFsV8wHLwh01EpROVz3KvVcD1Jmks9FQ==
+  dependencies:
+    "@sinonjs/commons" "^1.0.2"
+    array-from "^2.1.1"
+    lodash.get "^4.4.2"
+
 "@types/acorn@^4.0.3":
   version "4.0.3"
   resolved "https://registry.yarnpkg.com/@types/acorn/-/acorn-4.0.3.tgz#d1f3e738dde52536f9aad3d3380d14e448820afd"
@@ -1186,6 +1209,11 @@ array-find-index@^1.0.1:
   version "1.0.2"
   resolved "https://registry.yarnpkg.com/array-find-index/-/array-find-index-1.0.2.tgz#df010aa1287e164bbda6f9723b0a96a1ec4187a1"
 
+array-from@^2.1.1:
+  version "2.1.1"
+  resolved "https://registry.yarnpkg.com/array-from/-/array-from-2.1.1.tgz#cfe9d8c26628b9dc5aecc62a9f5d8f1f352c1195"
+  integrity sha1-z+nYwmYoudxa7MYqn12PHzUsEZU=
+
 array-ify@^1.0.0:
   version "1.0.0"
   resolved "https://registry.yarnpkg.com/array-ify/-/array-ify-1.0.0.tgz#9e528762b4a9066ad163a6962a364418e9626ece"
@@ -3632,9 +3660,10 @@ diff@3.2.0:
   version "3.2.0"
   resolved "https://registry.yarnpkg.com/diff/-/diff-3.2.0.tgz#c9ce393a4b7cbd0b058a725c93df299027868ff9"
 
-diff@^3.1.0:
-  version "3.4.0"
-  resolved "https://registry.yarnpkg.com/diff/-/diff-3.4.0.tgz#b1d85507daf3964828de54b37d0d73ba67dda56c"
+diff@^3.5.0:
+  version "3.5.0"
+  resolved "https://registry.yarnpkg.com/diff/-/diff-3.5.0.tgz#800c0dd1e0a8bfbc95835c202ad220fe317e5a12"
+  integrity sha512-A46qtFgd+g7pDZinpnwiRJtxbC1hpgf0uzP3iG89scHk0AUC7A1TGxf5OiiOUv/JMZR8GOt8hL900hV0bOy5xA==
 
 diffie-hellman@^5.0.0:
   version "5.0.2"
@@ -4463,12 +4492,6 @@ form-data@~2.3.1, form-data@~2.3.2:
     combined-stream "1.0.6"
     mime-types "^2.1.12"
 
-formatio@1.2.0:
-  version "1.2.0"
-  resolved "https://registry.yarnpkg.com/formatio/-/formatio-1.2.0.tgz#f3b2167d9068c4698a8d51f4f760a39a54d818eb"
-  dependencies:
-    samsam "1.x"
-
 fragment-cache@^0.2.1:
   version "0.2.1"
   resolved "https://registry.yarnpkg.com/fragment-cache/-/fragment-cache-0.2.1.tgz#4290fad27f13e89be7f33799c6bc5a0abfff0d19"
@@ -5781,6 +5804,11 @@ jsprim@^1.2.2:
     json-schema "0.2.3"
     verror "1.10.0"
 
+just-extend@^4.0.2:
+  version "4.0.2"
+  resolved "https://registry.yarnpkg.com/just-extend/-/just-extend-4.0.2.tgz#f3f47f7dfca0f989c55410a7ebc8854b07108afc"
+  integrity sha512-FrLwOgm+iXrPV+5zDU6Jqu4gCRXbWEQg2O3SKONsWE4w7AXFRkryS53bpWdaL9cNol+AmR3AEYz6kn+o0fCPnw==
+
 karma-mocha@^1.3.0:
   version "1.3.0"
   resolved "https://registry.yarnpkg.com/karma-mocha/-/karma-mocha-1.3.0.tgz#eeaac7ffc0e201eb63c467440d2b69c7cf3778bf"
@@ -5794,11 +5822,10 @@ karma-phantomjs-launcher@^1.0.4:
     lodash "^4.0.1"
     phantomjs-prebuilt "^2.1.7"
 
-karma-sinon-chai@^1.3.1:
-  version "1.3.3"
-  resolved "https://registry.yarnpkg.com/karma-sinon-chai/-/karma-sinon-chai-1.3.3.tgz#a597e5b4a1369fe7b3d7d76c09ed2061a38e747f"
-  dependencies:
-    lolex "^1.6.0"
+karma-sinon-chai@^2.0.2:
+  version "2.0.2"
+  resolved "https://registry.yarnpkg.com/karma-sinon-chai/-/karma-sinon-chai-2.0.2.tgz#e28c109b989973abafc28a7c9f09ef24a05e07c2"
+  integrity sha512-SDgh6V0CUd+7ruL1d3yG6lFzmJNGRNQuEuCYXLaorruNP9nwQfA7hpsp4clx4CbOo5Gsajh3qUOT7CrVStUKMw==
 
 karma-sourcemap-loader@^0.3.7:
   version "0.3.7"
@@ -6180,6 +6207,11 @@ lodash.create@3.1.1:
     lodash._basecreate "^3.0.0"
     lodash._isiterateecall "^3.0.0"
 
+lodash.get@^4.4.2:
+  version "4.4.2"
+  resolved "https://registry.yarnpkg.com/lodash.get/-/lodash.get-4.4.2.tgz#2d177f652fa31e939b4438d5341499dfa3825e99"
+  integrity sha1-LRd/ZS+jHpObRDjVNBSZ36OCXpk=
+
 lodash.isarguments@^3.0.0:
   version "3.1.0"
   resolved "https://registry.yarnpkg.com/lodash.isarguments/-/lodash.isarguments-3.1.0.tgz#2f573d85c6a24289ff00663b491c1d338ff3458a"
@@ -6269,9 +6301,15 @@ loglevelnext@^1.0.1, loglevelnext@^1.0.2:
     es6-symbol "^3.1.1"
     object.assign "^4.1.0"
 
-lolex@^1.6.0:
-  version "1.6.0"
-  resolved "https://registry.yarnpkg.com/lolex/-/lolex-1.6.0.tgz#3a9a0283452a47d7439e72731b9e07d7386e49f6"
+lolex@^2.3.2:
+  version "2.7.5"
+  resolved "https://registry.yarnpkg.com/lolex/-/lolex-2.7.5.tgz#113001d56bfc7e02d56e36291cc5c413d1aa0733"
+  integrity sha512-l9x0+1offnKKIzYVjyXU2SiwhXDLekRzKyhnbyldPHvC7BvLPVpdNUNR2KeMAiCN2D/kLNttZgQD5WjSxuBx3Q==
+
+lolex@^3.0.0:
+  version "3.0.0"
+  resolved "https://registry.yarnpkg.com/lolex/-/lolex-3.0.0.tgz#f04ee1a8aa13f60f1abd7b0e8f4213ec72ec193e"
+  integrity sha512-hcnW80h3j2lbUfFdMArd5UPA/vxZJ+G8vobd+wg3nVEQA0EigStbYcrG030FJxL6xiDDPEkoMatV9xIh5OecQQ==
 
 long@^3.2.0:
   version "3.2.0"
@@ -6792,10 +6830,6 @@ nanotiming@^7.2.0:
     nanoassert "^1.1.0"
     nanoscheduler "^1.0.2"
 
-native-promise-only@^0.8.1:
-  version "0.8.1"
-  resolved "https://registry.yarnpkg.com/native-promise-only/-/native-promise-only-0.8.1.tgz#20a318c30cb45f71fe7adfbf7b21c99c1472ef11"
-
 natural-compare@^1.4.0:
   version "1.4.0"
   resolved "https://registry.yarnpkg.com/natural-compare/-/natural-compare-1.4.0.tgz#4abebfeed7541f2c27acfb29bdbbd15c8d5ba4f7"
@@ -6820,6 +6854,17 @@ nice-try@^1.0.4:
   version "1.0.4"
   resolved "https://registry.yarnpkg.com/nice-try/-/nice-try-1.0.4.tgz#d93962f6c52f2c1558c0fbda6d512819f1efe1c4"
 
+nise@^1.4.8:
+  version "1.4.8"
+  resolved "https://registry.yarnpkg.com/nise/-/nise-1.4.8.tgz#ce91c31e86cf9b2c4cac49d7fcd7f56779bfd6b0"
+  integrity sha512-kGASVhuL4tlAV0tvA34yJYZIVihrUt/5bDwpp4tTluigxUr2bBlJeDXmivb6NuEdFkqvdv/Ybb9dm16PSKUhtw==
+  dependencies:
+    "@sinonjs/formatio" "^3.1.0"
+    just-extend "^4.0.2"
+    lolex "^2.3.2"
+    path-to-regexp "^1.7.0"
+    text-encoding "^0.6.4"
+
 no-case@^2.2.0:
   version "2.3.2"
   resolved "https://registry.yarnpkg.com/no-case/-/no-case-2.3.2.tgz#60b813396be39b3f1288a4c1ed5d1e7d28b464ac"
@@ -8557,10 +8602,6 @@ safe-regex@^1.1.0:
   version "2.1.2"
   resolved "https://registry.yarnpkg.com/safer-buffer/-/safer-buffer-2.1.2.tgz#44fa161b0187b9549dd84bb91802f9bd8385cd6a"
 
-samsam@1.x, samsam@^1.1.3:
-  version "1.3.0"
-  resolved "https://registry.yarnpkg.com/samsam/-/samsam-1.3.0.tgz#8d1d9350e25622da30de3e44ba692b5221ab7c50"
-
 sax@0.5.x:
   version "0.5.8"
   resolved "https://registry.yarnpkg.com/sax/-/sax-0.5.8.tgz#d472db228eb331c2506b0e8c15524adb939d12c1"
@@ -8673,22 +8714,23 @@ signal-exit@^3.0.0, signal-exit@^3.0.2:
   version "3.0.2"
   resolved "https://registry.yarnpkg.com/signal-exit/-/signal-exit-3.0.2.tgz#b5fdc08f1287ea1178628e415e25132b73646c6d"
 
-sinon-chai@^2.10.0:
-  version "2.14.0"
-  resolved "https://registry.yarnpkg.com/sinon-chai/-/sinon-chai-2.14.0.tgz#da7dd4cc83cd6a260b67cca0f7a9fdae26a1205d"
-
-sinon@^2.3.2:
-  version "2.4.1"
-  resolved "https://registry.yarnpkg.com/sinon/-/sinon-2.4.1.tgz#021fd64b54cb77d9d2fb0d43cdedfae7629c3a36"
-  dependencies:
-    diff "^3.1.0"
-    formatio "1.2.0"
-    lolex "^1.6.0"
-    native-promise-only "^0.8.1"
-    path-to-regexp "^1.7.0"
-    samsam "^1.1.3"
-    text-encoding "0.6.4"
-    type-detect "^4.0.0"
+sinon-chai@^3.3.0:
+  version "3.3.0"
+  resolved "https://registry.yarnpkg.com/sinon-chai/-/sinon-chai-3.3.0.tgz#8084ff99451064910fbe2c2cb8ab540c00b740ea"
+  integrity sha512-r2JhDY7gbbmh5z3Q62pNbrjxZdOAjpsqW/8yxAZRSqLZqowmfGZPGUZPFf3UX36NLis0cv8VEM5IJh9HgkSOAA==
+
+sinon@^7.2.3:
+  version "7.2.3"
+  resolved "https://registry.yarnpkg.com/sinon/-/sinon-7.2.3.tgz#f8bfd956df32ddf592f8c102fd46982366412d8e"
+  integrity sha512-i6j7sqcLEqTYqUcMV327waI745VASvYuSuQMCjbAwlpAeuCgKZ3LtrjDxAbu+GjNQR0FEDpywtwGCIh8GicNyg==
+  dependencies:
+    "@sinonjs/commons" "^1.3.0"
+    "@sinonjs/formatio" "^3.1.0"
+    "@sinonjs/samsam" "^3.0.2"
+    diff "^3.5.0"
+    lolex "^3.0.0"
+    nise "^1.4.8"
+    supports-color "^5.5.0"
 
 slash@^1.0.0:
   version "1.0.0"
@@ -9108,6 +9150,13 @@ supports-color@^5.3.0, supports-color@^5.4.0:
   dependencies:
     has-flag "^3.0.0"
 
+supports-color@^5.5.0:
+  version "5.5.0"
+  resolved "https://registry.yarnpkg.com/supports-color/-/supports-color-5.5.0.tgz#e2e69a44ac8772f78a1ec0b35b689df6530efc8f"
+  integrity sha512-QjVjwdXIt408MIiAqCX4oUKsgU2EqAGzs2Ppkm4aQYbjm+ZEWEcW4SfFNTr4uMNZma0ey4f5lgLrkB0aX0QMow==
+  dependencies:
+    has-flag "^3.0.0"
+
 svgo@^0.7.0:
   version "0.7.2"
   resolved "https://registry.yarnpkg.com/svgo/-/svgo-0.7.2.tgz#9f5772413952135c6fefbf40afe6a4faa88b4bb5"
@@ -9204,9 +9253,10 @@ term-size@^1.2.0:
   dependencies:
     execa "^0.7.0"
 
-text-encoding@0.6.4:
+text-encoding@^0.6.4:
   version "0.6.4"
   resolved "https://registry.yarnpkg.com/text-encoding/-/text-encoding-0.6.4.tgz#e399a982257a276dae428bb92845cb71bdc26d19"
+  integrity sha1-45mpgiV6J22uQou5KEXLcb3CbRk=
 
 text-extensions@^1.0.0:
   version "1.7.0"
@@ -9404,7 +9454,7 @@ type-check@~0.3.2:
   dependencies:
     prelude-ls "~1.1.2"
 
-type-detect@^4.0.0:
+type-detect@4.0.8, type-detect@^4.0.0:
   version "4.0.8"
   resolved "https://registry.yarnpkg.com/type-detect/-/type-detect-4.0.8.tgz#7646fb5f18871cfbb7749e69bd39a6388eb7450c"
 

From 52b9f37e0c9da7a89bd2f5ad655e171960b7a8d9 Mon Sep 17 00:00:00 2001
From: eddyerburgh <edward.yerburgh@gmail.com>
Date: Sun, 3 Feb 2019 15:07:07 +0000
Subject: [PATCH 3/6] chore: update mocha

---
 package.json |   4 +-
 yarn.lock    | 140 +++++++++++----------------------------------------
 2 files changed, 31 insertions(+), 113 deletions(-)

diff --git a/package.json b/package.json
index 4a24a7cf7..a8db04cde 100644
--- a/package.json
+++ b/package.json
@@ -26,7 +26,7 @@
     "test:unit:debug": "npm run build:test && node --inspect-brk node_modules/.bin/mocha-webpack --webpack-config test/setup/webpack.test.config.js test/specs --recursive --require test/setup/mocha.setup.js",
     "test:unit:karma": "npm run build:test && TARGET=browser karma start test/setup/karma.conf.js --single-run",
     "test:unit:node": "npm run build:test && npm run test:unit:node:only",
-    "test:unit:node:only": "TEST_ENV=node mocha-webpack --webpack-config test/setup/webpack.test.config.js test/specs --recursive --require test/setup/mocha.setup.js",
+    "test:unit:node:only": "cross-env TEST_ENV=node mocha-webpack --webpack-config test/setup/webpack.test.config.js test/specs --recursive --require test/setup/mocha.setup.js",
     "test:types": "tsc -p packages/test-utils/types && tsc -p packages/server-test-utils/types"
   },
   "devDependencies": {
@@ -60,7 +60,7 @@
     "karma-webpack": "^2.0.3",
     "lerna": "2",
     "markdown-it-include": "^1.0.0",
-    "mocha": "^3.5.0",
+    "mocha": "^5.2.0",
     "mocha-webpack": "^1.0.1",
     "prettier": "^1.16.0",
     "rollup": "^0.58.2",
diff --git a/yarn.lock b/yarn.lock
index 31b492ce8..3ddaae5d3 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -2172,9 +2172,10 @@ browser-process-hrtime@^0.1.2:
   version "0.1.2"
   resolved "https://registry.yarnpkg.com/browser-process-hrtime/-/browser-process-hrtime-0.1.2.tgz#425d68a58d3447f02a04aa894187fce8af8b7b8e"
 
-browser-stdout@1.3.0:
-  version "1.3.0"
-  resolved "https://registry.yarnpkg.com/browser-stdout/-/browser-stdout-1.3.0.tgz#f351d32969d32fa5d7a5567154263d928ae3bd1f"
+browser-stdout@1.3.1:
+  version "1.3.1"
+  resolved "https://registry.yarnpkg.com/browser-stdout/-/browser-stdout-1.3.1.tgz#baa559ee14ced73452229bad7326467c61fabd60"
+  integrity sha512-qhAVI1+Av2X7qelOfAIYwXONood6XlZE/fXaBSmW/T5SzLAmCgzi+eiWE7fUvbHaeNBQH13UftjpXxsfLkMpgw==
 
 browserify-aes@^1.0.0, browserify-aes@^1.0.4:
   version "1.1.1"
@@ -2733,16 +2734,10 @@ command-join@^2.0.0:
   version "2.0.0"
   resolved "https://registry.yarnpkg.com/command-join/-/command-join-2.0.0.tgz#52e8b984f4872d952ff1bdc8b98397d27c7144cf"
 
-commander@2.15.x, commander@^2.15.1, commander@~2.15.0:
+commander@2.15.1, commander@2.15.x, commander@^2.15.1, commander@~2.15.0:
   version "2.15.1"
   resolved "https://registry.yarnpkg.com/commander/-/commander-2.15.1.tgz#df46e867d0fc2aec66a34662b406a9ccafff5b0f"
 
-commander@2.9.0:
-  version "2.9.0"
-  resolved "https://registry.yarnpkg.com/commander/-/commander-2.9.0.tgz#9c99094176e12240cb22d6c5146098400fe0f7d4"
-  dependencies:
-    graceful-readlink ">= 1.0.0"
-
 commander@~2.13.0:
   version "2.13.0"
   resolved "https://registry.yarnpkg.com/commander/-/commander-2.13.0.tgz#6964bca67685df7c1f1430c584f07d7597885b9c"
@@ -3484,7 +3479,7 @@ de-indent@^1.0.2:
   version "1.0.2"
   resolved "https://registry.yarnpkg.com/de-indent/-/de-indent-1.0.2.tgz#b2038e846dc33baa5796128d0804b455b8c1e21d"
 
-debug@*, debug@^3.0.1, debug@^3.1.0:
+debug@*, debug@3.1.0, debug@^3.0.1, debug@^3.1.0:
   version "3.1.0"
   resolved "https://registry.yarnpkg.com/debug/-/debug-3.1.0.tgz#5bb5a0672628b64149566ba16819e61518c67261"
   dependencies:
@@ -3502,12 +3497,6 @@ debug@2.3.3:
   dependencies:
     ms "0.7.2"
 
-debug@2.6.8:
-  version "2.6.8"
-  resolved "https://registry.yarnpkg.com/debug/-/debug-2.6.8.tgz#e731531ca2ede27d188222427da17821d68ff4fc"
-  dependencies:
-    ms "2.0.0"
-
 debug@2.6.9, debug@^2.1.2, debug@^2.2.0, debug@^2.3.3, debug@^2.6.1, debug@^2.6.3, debug@^2.6.8:
   version "2.6.9"
   resolved "https://registry.yarnpkg.com/debug/-/debug-2.6.9.tgz#5d128515df134ff327e90a4c93f4e077a536341f"
@@ -3656,11 +3645,7 @@ diacritics@^1.3.0:
   version "1.3.0"
   resolved "https://registry.yarnpkg.com/diacritics/-/diacritics-1.3.0.tgz#3efa87323ebb863e6696cebb0082d48ff3d6f7a1"
 
-diff@3.2.0:
-  version "3.2.0"
-  resolved "https://registry.yarnpkg.com/diff/-/diff-3.2.0.tgz#c9ce393a4b7cbd0b058a725c93df299027868ff9"
-
-diff@^3.5.0:
+diff@3.5.0, diff@^3.5.0:
   version "3.5.0"
   resolved "https://registry.yarnpkg.com/diff/-/diff-3.5.0.tgz#800c0dd1e0a8bfbc95835c202ad220fe317e5a12"
   integrity sha512-A46qtFgd+g7pDZinpnwiRJtxbC1hpgf0uzP3iG89scHk0AUC7A1TGxf5OiiOUv/JMZR8GOt8hL900hV0bOy5xA==
@@ -4726,18 +4711,7 @@ glob@7.0.x:
     once "^1.3.0"
     path-is-absolute "^1.0.0"
 
-glob@7.1.1:
-  version "7.1.1"
-  resolved "https://registry.yarnpkg.com/glob/-/glob-7.1.1.tgz#805211df04faaf1c63a3600306cdf5ade50b2ec8"
-  dependencies:
-    fs.realpath "^1.0.0"
-    inflight "^1.0.4"
-    inherits "2"
-    minimatch "^3.0.2"
-    once "^1.3.0"
-    path-is-absolute "^1.0.0"
-
-glob@^7.0.3, glob@^7.0.5, glob@^7.1.1, glob@^7.1.2:
+glob@7.1.2, glob@^7.0.3, glob@^7.0.5, glob@^7.1.1, glob@^7.1.2:
   version "7.1.2"
   resolved "https://registry.yarnpkg.com/glob/-/glob-7.1.2.tgz#c19c9df9a028702d678612384a6552404c636d15"
   dependencies:
@@ -4839,10 +4813,6 @@ graceful-fs@^4.1.11, graceful-fs@^4.1.2, graceful-fs@^4.1.6, graceful-fs@^4.1.9:
   version "4.1.11"
   resolved "https://registry.yarnpkg.com/graceful-fs/-/graceful-fs-4.1.11.tgz#0e8bdfe4d1ddb8854d64e04ea7c00e2a026e5658"
 
-"graceful-readlink@>= 1.0.0":
-  version "1.0.1"
-  resolved "https://registry.yarnpkg.com/graceful-readlink/-/graceful-readlink-1.0.1.tgz#4cafad76bc62f02fa039b2f94e9a3dd3a391a725"
-
 gray-matter@^4.0.1:
   version "4.0.1"
   resolved "https://registry.yarnpkg.com/gray-matter/-/gray-matter-4.0.1.tgz#375263c194f0d9755578c277e41b1c1dfdf22c7d"
@@ -4852,9 +4822,10 @@ gray-matter@^4.0.1:
     section-matter "^1.0.0"
     strip-bom-string "^1.0.0"
 
-growl@1.9.2:
-  version "1.9.2"
-  resolved "https://registry.yarnpkg.com/growl/-/growl-1.9.2.tgz#0ea7743715db8d8de2c5ede1775e1b45ac85c02f"
+growl@1.10.5:
+  version "1.10.5"
+  resolved "https://registry.yarnpkg.com/growl/-/growl-1.10.5.tgz#f2735dc2283674fa67478b10181059355c369e5e"
+  integrity sha512-qBr4OuELkhPenW6goKVXiv47US3clb3/IbuWF9KNKEijAy9oeHxU9IgzjvJhHkUzhaj7rOUD7+YGWqUjLp5oSA==
 
 handlebars@^4.0.2:
   version "4.0.11"
@@ -6160,29 +6131,6 @@ locate-path@^2.0.0:
     p-locate "^2.0.0"
     path-exists "^3.0.0"
 
-lodash._baseassign@^3.0.0:
-  version "3.2.0"
-  resolved "https://registry.yarnpkg.com/lodash._baseassign/-/lodash._baseassign-3.2.0.tgz#8c38a099500f215ad09e59f1722fd0c52bfe0a4e"
-  dependencies:
-    lodash._basecopy "^3.0.0"
-    lodash.keys "^3.0.0"
-
-lodash._basecopy@^3.0.0:
-  version "3.0.1"
-  resolved "https://registry.yarnpkg.com/lodash._basecopy/-/lodash._basecopy-3.0.1.tgz#8da0e6a876cf344c0ad8a54882111dd3c5c7ca36"
-
-lodash._basecreate@^3.0.0:
-  version "3.0.3"
-  resolved "https://registry.yarnpkg.com/lodash._basecreate/-/lodash._basecreate-3.0.3.tgz#1bc661614daa7fc311b7d03bf16806a0213cf821"
-
-lodash._getnative@^3.0.0:
-  version "3.9.1"
-  resolved "https://registry.yarnpkg.com/lodash._getnative/-/lodash._getnative-3.9.1.tgz#570bc7dede46d61cdcde687d65d3eecbaa3aaff5"
-
-lodash._isiterateecall@^3.0.0:
-  version "3.0.9"
-  resolved "https://registry.yarnpkg.com/lodash._isiterateecall/-/lodash._isiterateecall-3.0.9.tgz#5203ad7ba425fae842460e696db9cf3e6aac057c"
-
 lodash._reinterpolate@~3.0.0:
   version "3.0.0"
   resolved "https://registry.yarnpkg.com/lodash._reinterpolate/-/lodash._reinterpolate-3.0.0.tgz#0ccf2d89166af03b3663c796538b75ac6e114d9d"
@@ -6199,35 +6147,11 @@ lodash.clonedeep@^4.5.0:
   version "4.5.0"
   resolved "https://registry.yarnpkg.com/lodash.clonedeep/-/lodash.clonedeep-4.5.0.tgz#e23f3f9c4f8fbdde872529c1071857a086e5ccef"
 
-lodash.create@3.1.1:
-  version "3.1.1"
-  resolved "https://registry.yarnpkg.com/lodash.create/-/lodash.create-3.1.1.tgz#d7f2849f0dbda7e04682bb8cd72ab022461debe7"
-  dependencies:
-    lodash._baseassign "^3.0.0"
-    lodash._basecreate "^3.0.0"
-    lodash._isiterateecall "^3.0.0"
-
 lodash.get@^4.4.2:
   version "4.4.2"
   resolved "https://registry.yarnpkg.com/lodash.get/-/lodash.get-4.4.2.tgz#2d177f652fa31e939b4438d5341499dfa3825e99"
   integrity sha1-LRd/ZS+jHpObRDjVNBSZ36OCXpk=
 
-lodash.isarguments@^3.0.0:
-  version "3.1.0"
-  resolved "https://registry.yarnpkg.com/lodash.isarguments/-/lodash.isarguments-3.1.0.tgz#2f573d85c6a24289ff00663b491c1d338ff3458a"
-
-lodash.isarray@^3.0.0:
-  version "3.0.4"
-  resolved "https://registry.yarnpkg.com/lodash.isarray/-/lodash.isarray-3.0.4.tgz#79e4eb88c36a8122af86f844aa9bcd851b5fbb55"
-
-lodash.keys@^3.0.0:
-  version "3.1.2"
-  resolved "https://registry.yarnpkg.com/lodash.keys/-/lodash.keys-3.1.2.tgz#4dbc0472b156be50a0b286855d1bd0b0c656098a"
-  dependencies:
-    lodash._getnative "^3.0.0"
-    lodash.isarguments "^3.0.0"
-    lodash.isarray "^3.0.0"
-
 lodash.memoize@^4.1.2:
   version "4.1.2"
   resolved "https://registry.yarnpkg.com/lodash.memoize/-/lodash.memoize-4.1.2.tgz#bcc6c49a42a2840ed997f323eada5ecd182e0bfe"
@@ -6616,7 +6540,7 @@ minimalistic-crypto-utils@^1.0.0, minimalistic-crypto-utils@^1.0.1:
   version "1.0.1"
   resolved "https://registry.yarnpkg.com/minimalistic-crypto-utils/-/minimalistic-crypto-utils-1.0.1.tgz#f6c00c1c0b082246e5c4d99dfb8c7c083b2b582a"
 
-minimatch@^3.0.0, minimatch@^3.0.2, minimatch@^3.0.4:
+minimatch@3.0.4, minimatch@^3.0.0, minimatch@^3.0.2, minimatch@^3.0.4:
   version "3.0.4"
   resolved "https://registry.yarnpkg.com/minimatch/-/minimatch-3.0.4.tgz#5166e286457f03306064be5497e8dbb0c3d32083"
   dependencies:
@@ -6717,22 +6641,22 @@ mocha-webpack@^1.0.1:
     toposort "^1.0.0"
     yargs "^4.8.0"
 
-mocha@^3.5.0:
-  version "3.5.3"
-  resolved "https://registry.yarnpkg.com/mocha/-/mocha-3.5.3.tgz#1e0480fe36d2da5858d1eb6acc38418b26eaa20d"
+mocha@^5.2.0:
+  version "5.2.0"
+  resolved "https://registry.yarnpkg.com/mocha/-/mocha-5.2.0.tgz#6d8ae508f59167f940f2b5b3c4a612ae50c90ae6"
+  integrity sha512-2IUgKDhc3J7Uug+FxMXuqIyYzH7gJjXECKe/w43IGgQHTSj3InJi+yAA7T24L9bQMRKiUEHxEX37G5JpVUGLcQ==
   dependencies:
-    browser-stdout "1.3.0"
-    commander "2.9.0"
-    debug "2.6.8"
-    diff "3.2.0"
+    browser-stdout "1.3.1"
+    commander "2.15.1"
+    debug "3.1.0"
+    diff "3.5.0"
     escape-string-regexp "1.0.5"
-    glob "7.1.1"
-    growl "1.9.2"
+    glob "7.1.2"
+    growl "1.10.5"
     he "1.1.1"
-    json3 "3.3.2"
-    lodash.create "3.1.1"
+    minimatch "3.0.4"
     mkdirp "0.5.1"
-    supports-color "3.1.2"
+    supports-color "5.4.0"
 
 modify-values@^1.0.0:
   version "1.0.0"
@@ -9116,11 +9040,11 @@ stylus@^0.54.5:
     sax "0.5.x"
     source-map "0.1.x"
 
-supports-color@3.1.2:
-  version "3.1.2"
-  resolved "https://registry.yarnpkg.com/supports-color/-/supports-color-3.1.2.tgz#72a262894d9d408b956ca05ff37b2ed8a6e2a2d5"
+supports-color@5.4.0, supports-color@^5.3.0, supports-color@^5.4.0:
+  version "5.4.0"
+  resolved "https://registry.yarnpkg.com/supports-color/-/supports-color-5.4.0.tgz#1c6b337402c2137605efe19f10fec390f6faab54"
   dependencies:
-    has-flag "^1.0.0"
+    has-flag "^3.0.0"
 
 supports-color@^2.0.0:
   version "2.0.0"
@@ -9144,12 +9068,6 @@ supports-color@^5.2.0:
   dependencies:
     has-flag "^3.0.0"
 
-supports-color@^5.3.0, supports-color@^5.4.0:
-  version "5.4.0"
-  resolved "https://registry.yarnpkg.com/supports-color/-/supports-color-5.4.0.tgz#1c6b337402c2137605efe19f10fec390f6faab54"
-  dependencies:
-    has-flag "^3.0.0"
-
 supports-color@^5.5.0:
   version "5.5.0"
   resolved "https://registry.yarnpkg.com/supports-color/-/supports-color-5.5.0.tgz#e2e69a44ac8772f78a1ec0b35b689df6530efc8f"

From ecf713796617a1e243d034666cbc23f2f42b1016 Mon Sep 17 00:00:00 2001
From: eddyerburgh <edward.yerburgh@gmail.com>
Date: Sun, 3 Feb 2019 16:08:33 +0000
Subject: [PATCH 4/6] refactor: use templates instead of compileToFunctions

---
 .../create-instance/create-component-stubs.js | 11 ++++++---
 packages/create-instance/create-instance.js   |  2 +-
 .../create-instance/patch-create-element.js   |  1 +
 test/specs/error-wrapper.spec.js              |  7 +++---
 test/specs/mounting-options/attrs.spec.js     |  8 ++++---
 test/specs/mounting-options/listeners.spec.js |  7 +++---
 test/specs/wrapper-array/at.spec.js           | 13 +++++++----
 test/specs/wrapper-array/attributes.spec.js   | 13 +++++++----
 test/specs/wrapper-array/classes.spec.js      | 13 +++++++----
 test/specs/wrapper-array/contains.spec.js     | 23 ++++++++-----------
 test/specs/wrapper-array/find.spec.js         | 15 ++++++------
 11 files changed, 65 insertions(+), 48 deletions(-)

diff --git a/packages/create-instance/create-component-stubs.js b/packages/create-instance/create-component-stubs.js
index 70b275b17..d2dc4ce07 100644
--- a/packages/create-instance/create-component-stubs.js
+++ b/packages/create-instance/create-component-stubs.js
@@ -65,9 +65,13 @@ function resolveOptions(component, _Vue) {
     return {}
   }
 
-  return isConstructor(component)
-    ? component.options
-    : _Vue.extend(component).options
+  if (isConstructor(component)) {
+    return component.options
+  }
+  const options = _Vue.extend(component).options
+  component._Ctor = {}
+
+  return options
 }
 
 export function createStubFromComponent(
@@ -165,6 +169,7 @@ export function createStubsFromStubsObject(
     }
 
     acc[stubName] = stub
+    stub._Ctor = {}
 
     return acc
   }, {})
diff --git a/packages/create-instance/create-instance.js b/packages/create-instance/create-instance.js
index b0869002b..fec2fdbb5 100644
--- a/packages/create-instance/create-instance.js
+++ b/packages/create-instance/create-instance.js
@@ -74,7 +74,7 @@ export default function createInstance(
   // make sure all extends are based on this instance
 
   const Constructor = _Vue.extend(componentOptions).extend(instanceOptions)
-
+  componentOptions._Ctor = {}
   Constructor.options._base = _Vue
 
   const scopedSlots = createScopedSlots(options.scopedSlots, _Vue)
diff --git a/packages/create-instance/patch-create-element.js b/packages/create-instance/patch-create-element.js
index dc152996e..3f234cca6 100644
--- a/packages/create-instance/patch-create-element.js
+++ b/packages/create-instance/patch-create-element.js
@@ -21,6 +21,7 @@ function shouldExtend(component, _Vue) {
 function extend(component, _Vue) {
   const componentOptions = component.options ? component.options : component
   const stub = _Vue.extend(componentOptions)
+  componentOptions._Ctor = {}
   stub.options.$_vueTestUtils_original = component
   stub.options._base = _Vue
   return stub
diff --git a/test/specs/error-wrapper.spec.js b/test/specs/error-wrapper.spec.js
index 299839f56..0eb610696 100644
--- a/test/specs/error-wrapper.spec.js
+++ b/test/specs/error-wrapper.spec.js
@@ -1,4 +1,3 @@
-import { compileToFunctions } from 'vue-template-compiler'
 import { describeWithShallowAndMount } from '~resources/utils'
 
 describeWithShallowAndMount('ErrorWrapper', mountingMethod => {
@@ -36,10 +35,12 @@ describeWithShallowAndMount('ErrorWrapper', mountingMethod => {
   ]
   methods.forEach(method => {
     it(`${method} throws error when called`, () => {
-      const compiled = compileToFunctions('<p />')
+      const TestComponent = {
+        template: '<p />'
+      }
       const selector = 'div'
       const message = `[vue-test-utils]: find did not return ${selector}, cannot call ${method}() on empty Wrapper`
-      const wrapper = mountingMethod(compiled)
+      const wrapper = mountingMethod(TestComponent)
       const error = wrapper.find(selector)
       expect(error.constructor.name).to.equal('ErrorWrapper')
       expect(() => error[method]())
diff --git a/test/specs/mounting-options/attrs.spec.js b/test/specs/mounting-options/attrs.spec.js
index cb6ba5de7..8ab35dbc6 100644
--- a/test/specs/mounting-options/attrs.spec.js
+++ b/test/specs/mounting-options/attrs.spec.js
@@ -1,4 +1,3 @@
-import { compileToFunctions } from 'vue-template-compiler'
 import { attrsSupported } from '~resources/utils'
 import {
   describeWithMountingMethods,
@@ -15,7 +14,10 @@ describeWithMountingMethods('options.attrs', mountingMethod => {
     'handles inherit attrs',
     () => {
       if (!attrsSupported) return
-      const wrapper = mountingMethod(compileToFunctions('<p :id="anAttr" />'), {
+      const TestComponent = {
+        template: '<p :id="anAttr" />'
+      }
+      const wrapper = mountingMethod(TestComponent, {
         attrs: {
           anAttr: 'an attribute'
         }
@@ -29,7 +31,7 @@ describeWithMountingMethods('options.attrs', mountingMethod => {
     mountingMethod.name === 'renderToString' || vueVersion < 2.5,
     'defines attrs as empty object even when not passed',
     () => {
-      const wrapper = mountingMethod(compileToFunctions('<p />'))
+      const wrapper = mountingMethod({ template: '<p />' })
       expect(wrapper.vm.$attrs).to.deep.equal({})
     }
   )
diff --git a/test/specs/mounting-options/listeners.spec.js b/test/specs/mounting-options/listeners.spec.js
index 6cdd25006..2720f08f0 100644
--- a/test/specs/mounting-options/listeners.spec.js
+++ b/test/specs/mounting-options/listeners.spec.js
@@ -1,4 +1,3 @@
-import { compileToFunctions } from 'vue-template-compiler'
 import { listenersSupported } from '~resources/utils'
 import {
   describeWithShallowAndMount,
@@ -14,7 +13,9 @@ describeWithShallowAndMount('options.listeners', mountingMethod => {
     () => {
       const aListener = () => {}
       const wrapper = mountingMethod(
-        compileToFunctions('<p :id="aListener" />'),
+        {
+          template: '<p :id="aListener" />'
+        },
         {
           listeners: {
             aListener
@@ -56,7 +57,7 @@ describeWithShallowAndMount('options.listeners', mountingMethod => {
     vueVersion < 2.5,
     'defines listeners as empty object even when not passed',
     () => {
-      const wrapper = mountingMethod(compileToFunctions('<p />'))
+      const wrapper = mountingMethod({ template: '<p />' })
       expect(wrapper.vm.$listeners).to.deep.equal({})
     }
   )
diff --git a/test/specs/wrapper-array/at.spec.js b/test/specs/wrapper-array/at.spec.js
index 4fc014ab5..5d18bfe6e 100644
--- a/test/specs/wrapper-array/at.spec.js
+++ b/test/specs/wrapper-array/at.spec.js
@@ -1,11 +1,12 @@
 import { describeWithShallowAndMount } from '~resources/utils'
-import { compileToFunctions } from 'vue-template-compiler'
 import '~vue/test-utils'
 
 describeWithShallowAndMount('at', mountingMethod => {
   it('returns Wrapper at index', () => {
-    const compiled = compileToFunctions('<div><p /><p class="index-1"/></div>')
-    const p = mountingMethod(compiled)
+    const TestComponent = {
+      template: '<div><p /><p class="index-1"/></div>'
+    }
+    const p = mountingMethod(TestComponent)
       .findAll('p')
       .at(1)
     expect(p.vnode).to.be.an('object')
@@ -14,10 +15,12 @@ describeWithShallowAndMount('at', mountingMethod => {
 
   it('throws error if no item exists at index', () => {
     const index = 2
-    const compiled = compileToFunctions('<div><p /><p class="index-1"/></div>')
+    const TestComponent = {
+      template: '<div><p /><p class="index-1"/></div>'
+    }
     const message = `[vue-test-utils]: no item exists at ${index}`
     expect(() =>
-      mountingMethod(compiled)
+      mountingMethod(TestComponent)
         .findAll('p')
         .at(index)
     )
diff --git a/test/specs/wrapper-array/attributes.spec.js b/test/specs/wrapper-array/attributes.spec.js
index 69c8daee5..a8acc62f1 100644
--- a/test/specs/wrapper-array/attributes.spec.js
+++ b/test/specs/wrapper-array/attributes.spec.js
@@ -1,13 +1,14 @@
 import { describeWithShallowAndMount } from '~resources/utils'
-import { compileToFunctions } from 'vue-template-compiler'
 import '~vue/test-utils'
 
 describeWithShallowAndMount('attributes', mountingMethod => {
   it('throws error if wrapper array contains no items', () => {
-    const compiled = compileToFunctions('<div />')
+    const TestComponent = {
+      template: '<div />'
+    }
     const message = '[vue-test-utils]: attributes cannot be called on 0 items'
     expect(() =>
-      mountingMethod(compiled)
+      mountingMethod(TestComponent)
         .findAll('p')
         .attributes('p')
     )
@@ -16,8 +17,10 @@ describeWithShallowAndMount('attributes', mountingMethod => {
   })
 
   it('throws error when called on a WrapperArray', () => {
-    const compiled = compileToFunctions('<div><div /></div>')
-    const wrapper = mountingMethod(compiled)
+    const TestComponent = {
+      template: '<div><div /></div>'
+    }
+    const wrapper = mountingMethod(TestComponent)
     const message =
       '[vue-test-utils]: attributes must be called on a single wrapper, use at(i) to access a wrapper'
     const fn = () => wrapper.findAll('div').attributes()
diff --git a/test/specs/wrapper-array/classes.spec.js b/test/specs/wrapper-array/classes.spec.js
index 5c1d08fd9..cbe1d707e 100644
--- a/test/specs/wrapper-array/classes.spec.js
+++ b/test/specs/wrapper-array/classes.spec.js
@@ -1,13 +1,14 @@
 import { describeWithShallowAndMount } from '~resources/utils'
-import { compileToFunctions } from 'vue-template-compiler'
 import '~vue/test-utils'
 
 describeWithShallowAndMount('classes', mountingMethod => {
   it('throws error if wrapper array contains no items', () => {
-    const compiled = compileToFunctions('<div />')
+    const TestComponent = {
+      template: '<div />'
+    }
     const message = '[vue-test-utils]: classes cannot be called on 0 items'
     expect(() =>
-      mountingMethod(compiled)
+      mountingMethod(TestComponent)
         .findAll('p')
         .classes('p')
     )
@@ -16,8 +17,10 @@ describeWithShallowAndMount('classes', mountingMethod => {
   })
 
   it('throws error when called on a WrapperArray', () => {
-    const compiled = compileToFunctions('<div><div /></div>')
-    const wrapper = mountingMethod(compiled)
+    const TestComponent = {
+      template: '<div><div /></div>'
+    }
+    const wrapper = mountingMethod(TestComponent)
     const message =
       '[vue-test-utils]: classes must be called on a single wrapper, use at(i) to access a wrapper'
     const fn = () => wrapper.findAll('div').classes()
diff --git a/test/specs/wrapper-array/contains.spec.js b/test/specs/wrapper-array/contains.spec.js
index 975aac550..566263108 100644
--- a/test/specs/wrapper-array/contains.spec.js
+++ b/test/specs/wrapper-array/contains.spec.js
@@ -1,31 +1,28 @@
 import { describeWithShallowAndMount } from '~resources/utils'
-import { compileToFunctions } from 'vue-template-compiler'
 import '~vue/test-utils'
 
 describeWithShallowAndMount('contains', mountingMethod => {
   it('returns true if every Wrapper contains element', () => {
-    const compiled = compileToFunctions(
-      '<span><div><p /></div><div><p /></div></span>'
-    )
-    const wrapper = mountingMethod(compiled)
+    const TestComponent = {
+      template: '<span><div><p /></div><div><p /></div></span>'
+    }
+    const wrapper = mountingMethod(TestComponent)
     const divArr = wrapper.findAll('div')
     expect(divArr.contains('p')).to.equal(true)
   })
 
   it('returns false if any Wrapper does not contain element', () => {
-    const compiled = compileToFunctions(
-      '<div><div></div><div><p /></div></div>'
-    )
-    const wrapper = mountingMethod(compiled)
+    const TestComponent = { template: '<div><div></div><div><p /></div></div>' }
+    const wrapper = mountingMethod(TestComponent)
     const divArr = wrapper.findAll('div')
     expect(divArr.contains('p')).to.equal(false)
   })
 
   it('throws error if wrapper array contains no items', () => {
-    const compiled = compileToFunctions('<div />')
+    const TestComponent = { template: '<div />' }
     const message = '[vue-test-utils]: contains cannot be called on 0 items'
     expect(() =>
-      mountingMethod(compiled)
+      mountingMethod(TestComponent)
         .findAll('p')
         .contains('p')
     )
@@ -34,8 +31,8 @@ describeWithShallowAndMount('contains', mountingMethod => {
   })
 
   it('throws error if selector is not a valid selector', () => {
-    const compiled = compileToFunctions('<div><p></p></div>')
-    const wrapper = mountingMethod(compiled)
+    const TestComponent = { template: '<div><p></p></div>' }
+    const wrapper = mountingMethod(TestComponent)
     const pArr = wrapper.findAll('p')
     const invalidSelectors = [
       undefined,
diff --git a/test/specs/wrapper-array/find.spec.js b/test/specs/wrapper-array/find.spec.js
index a7d599e91..75193f6ca 100644
--- a/test/specs/wrapper-array/find.spec.js
+++ b/test/specs/wrapper-array/find.spec.js
@@ -1,13 +1,14 @@
 import { describeWithShallowAndMount } from '~resources/utils'
-import { compileToFunctions } from 'vue-template-compiler'
 import '~vue/test-utils'
 
 describeWithShallowAndMount('find', mountingMethod => {
   it('throws error if wrapper array contains no items', () => {
-    const compiled = compileToFunctions('<div />')
+    const TestComponent = {
+      template: '<div />'
+    }
     const message = '[vue-test-utils]: find cannot be called on 0 items'
     expect(() =>
-      mountingMethod(compiled)
+      mountingMethod(TestComponent)
         .findAll('p')
         .find('p')
     )
@@ -16,10 +17,10 @@ describeWithShallowAndMount('find', mountingMethod => {
   })
 
   it('throws an error when called on a WrapperArray', () => {
-    const compiled = compileToFunctions(
-      '<div><div></div><div><p /></div></div>'
-    )
-    const wrapper = mountingMethod(compiled)
+    const TestComponent = {
+      template: '<div><div></div><div><p /></div></div>'
+    }
+    const wrapper = mountingMethod(TestComponent)
     const message =
       '[vue-test-utils]: find must be called on a single wrapper, use at(i) to access a wrapper'
     expect(() => wrapper.findAll('div').find('div'))

From 67f45228318293eef37ec851321957849511dfea Mon Sep 17 00:00:00 2001
From: eddyerburgh <edward.yerburgh@gmail.com>
Date: Sun, 3 Feb 2019 16:58:11 +0000
Subject: [PATCH 5/6] test: stop unnecessary logs

---
 test/resources/components/component-with-events.vue | 1 -
 test/resources/components/recursive-component.vue   | 4 ++--
 test/specs/config.spec.js                           | 4 ++--
 test/specs/mount.spec.js                            | 7 +++----
 test/specs/mounting-options/attrs.spec.js           | 2 +-
 test/specs/mounting-options/listeners.spec.js       | 2 +-
 test/specs/mounting-options/localVue.spec.js        | 2 +-
 test/specs/mounting-options/scopedSlots.spec.js     | 1 +
 test/specs/mounting-options/stubs.spec.js           | 4 ++--
 9 files changed, 13 insertions(+), 14 deletions(-)

diff --git a/test/resources/components/component-with-events.vue b/test/resources/components/component-with-events.vue
index c3a207518..896c1a055 100644
--- a/test/resources/components/component-with-events.vue
+++ b/test/resources/components/component-with-events.vue
@@ -42,7 +42,6 @@ export default {
     mousedownHandler(event) {
       if (event.button === 0) {
         this.clickHandler()
-        console.info(event.defaultPrevented)
       }
     },
     toggleActive() {
diff --git a/test/resources/components/recursive-component.vue b/test/resources/components/recursive-component.vue
index 1d19e0680..8c0a70b56 100644
--- a/test/resources/components/recursive-component.vue
+++ b/test/resources/components/recursive-component.vue
@@ -1,8 +1,8 @@
 <template>
   <div>
     <recursive-component
-      v-for="item in items"
-      :key="item"
+      v-for="(item, i) in items"
+      :key="i"
       :items="items ? items[0] : []"
       >{{ something }}</recursive-component
     >
diff --git a/test/specs/config.spec.js b/test/specs/config.spec.js
index 0cfebe3ad..8e0fa3875 100644
--- a/test/specs/config.spec.js
+++ b/test/specs/config.spec.js
@@ -116,7 +116,7 @@ describeWithShallowAndMount('config', mountingMethod => {
     const testComponent = {
       template: `
         <div>
-          <transition-group><p /><p /></transition-group>
+          <transition-group><p key="1"/><p key="2" /></transition-group>
         </div>
       `
     }
@@ -130,7 +130,7 @@ describeWithShallowAndMount('config', mountingMethod => {
     const testComponent = {
       template: `
         <div>
-          <transition-group><p /><p /></transition-group>
+          <transition-group><p key="1" /><p key="2" /></transition-group>
         </div>
       `
     }
diff --git a/test/specs/mount.spec.js b/test/specs/mount.spec.js
index a2c3e9682..428630d23 100644
--- a/test/specs/mount.spec.js
+++ b/test/specs/mount.spec.js
@@ -102,7 +102,7 @@ describeRunIf(process.env.TEST_ENV !== 'node', 'mount', () => {
     'handles extended components added to Vue constructor',
     () => {
       const ChildComponent = Vue.extend({
-        template: '<div />',
+        render: h => h('div'),
         mounted() {
           this.$route.params
         }
@@ -140,7 +140,6 @@ describeRunIf(process.env.TEST_ENV !== 'node', 'mount', () => {
     if (
       !(navigator.userAgent.includes && navigator.userAgent.includes('node.js'))
     ) {
-      console.log('window read only. skipping test ...')
       return
     }
 
@@ -235,7 +234,7 @@ describeRunIf(process.env.TEST_ENV !== 'node', 'mount', () => {
   it('deletes mounting options before passing options to component', () => {
     const wrapper = mount(
       {
-        render: h => h('div')
+        template: '<div />'
       },
       {
         provide: {
@@ -250,7 +249,7 @@ describeRunIf(process.env.TEST_ENV !== 'node', 'mount', () => {
         },
         localVue: createLocalVue(),
         stubs: {
-          prop: 'val'
+          prop: { template: '<div />' }
         },
         attrs: {
           prop: 'val'
diff --git a/test/specs/mounting-options/attrs.spec.js b/test/specs/mounting-options/attrs.spec.js
index 8ab35dbc6..5394bc305 100644
--- a/test/specs/mounting-options/attrs.spec.js
+++ b/test/specs/mounting-options/attrs.spec.js
@@ -15,7 +15,7 @@ describeWithMountingMethods('options.attrs', mountingMethod => {
     () => {
       if (!attrsSupported) return
       const TestComponent = {
-        template: '<p :id="anAttr" />'
+        template: '<p :id="$attrs.anAttr" />'
       }
       const wrapper = mountingMethod(TestComponent, {
         attrs: {
diff --git a/test/specs/mounting-options/listeners.spec.js b/test/specs/mounting-options/listeners.spec.js
index 2720f08f0..d9aabc859 100644
--- a/test/specs/mounting-options/listeners.spec.js
+++ b/test/specs/mounting-options/listeners.spec.js
@@ -14,7 +14,7 @@ describeWithShallowAndMount('options.listeners', mountingMethod => {
       const aListener = () => {}
       const wrapper = mountingMethod(
         {
-          template: '<p :id="aListener" />'
+          template: '<p :id="$listeners.aListener" />'
         },
         {
           listeners: {
diff --git a/test/specs/mounting-options/localVue.spec.js b/test/specs/mounting-options/localVue.spec.js
index bab034b54..b2614bd51 100644
--- a/test/specs/mounting-options/localVue.spec.js
+++ b/test/specs/mounting-options/localVue.spec.js
@@ -89,7 +89,7 @@ describeWithMountingMethods('options.localVue', mountingMethod => {
     const Extends = {
       template: '<div />',
       created() {
-        console.log(this.$route.params)
+        this.$route.params
       }
     }
     const TestComponent = {
diff --git a/test/specs/mounting-options/scopedSlots.spec.js b/test/specs/mounting-options/scopedSlots.spec.js
index 7b34febc4..5e80c9ef8 100644
--- a/test/specs/mounting-options/scopedSlots.spec.js
+++ b/test/specs/mounting-options/scopedSlots.spec.js
@@ -238,6 +238,7 @@ describeWithShallowAndMount('scopedSlots', mountingMethod => {
     'renders scoped slots in sync mode by default',
     () => {
       const TestComponent = {
+        template: '<div />',
         data() {
           return {
             val: null
diff --git a/test/specs/mounting-options/stubs.spec.js b/test/specs/mounting-options/stubs.spec.js
index 9b0d59a4e..e1e8138ce 100644
--- a/test/specs/mounting-options/stubs.spec.js
+++ b/test/specs/mounting-options/stubs.spec.js
@@ -100,12 +100,12 @@ describeWithMountingMethods('options.stub', mountingMethod => {
       })
       const wrapper = mountingMethod(TestComponent, {
         stubs: {
-          ToStubComponent: { template: '<date />' }
+          ToStubComponent: { template: '<time />' }
         }
       })
       const HTML =
         mountingMethod.name === 'renderToString' ? wrapper : wrapper.html()
-      expect(HTML).contains('<date')
+      expect(HTML).contains('<time')
     }
   )
 

From 02bfb2fceda14df4ccaa0425813859fc0465d27d Mon Sep 17 00:00:00 2001
From: eddyerburgh <edward.yerburgh@gmail.com>
Date: Sun, 3 Feb 2019 17:43:13 +0000
Subject: [PATCH 6/6] test: restore sandbox to remove memory leak

---
 test/specs/components/TransitionStub.spec.js    | 1 +
 test/specs/config.spec.js                       | 1 +
 test/specs/mount.spec.js                        | 1 +
 test/specs/mounting-options/mocks.spec.js       | 1 +
 test/specs/mounting-options/scopedSlots.spec.js | 1 +
 test/specs/mounting-options/stubs.spec.js       | 1 +
 test/specs/mounting-options/sync.spec.js        | 1 +
 test/specs/shallow-mount.spec.js                | 4 ++--
 test/specs/wrapper-array.spec.js                | 5 ++++-
 test/specs/wrapper-array/trigger.spec.js        | 5 ++++-
 test/specs/wrapper/destroy.spec.js              | 5 ++++-
 test/specs/wrapper/setData.spec.js              | 1 +
 test/specs/wrapper/setProps.spec.js             | 1 +
 test/specs/wrapper/trigger.spec.js              | 1 +
 14 files changed, 24 insertions(+), 5 deletions(-)

diff --git a/test/specs/components/TransitionStub.spec.js b/test/specs/components/TransitionStub.spec.js
index f30d7d5f1..56286d6a6 100644
--- a/test/specs/components/TransitionStub.spec.js
+++ b/test/specs/components/TransitionStub.spec.js
@@ -10,6 +10,7 @@ describeWithShallowAndMount('TransitionStub', mountingMethod => {
   })
 
   afterEach(() => {
+    sandbox.reset()
     sandbox.restore()
   })
 
diff --git a/test/specs/config.spec.js b/test/specs/config.spec.js
index 8e0fa3875..4d3276568 100644
--- a/test/specs/config.spec.js
+++ b/test/specs/config.spec.js
@@ -25,6 +25,7 @@ describeWithShallowAndMount('config', mountingMethod => {
     config.stubs = configStubsSave
     config.logModifiedComponents = configLogSave
     config.silent = configSilentSave
+    sandbox.reset()
     sandbox.restore()
   })
 
diff --git a/test/specs/mount.spec.js b/test/specs/mount.spec.js
index 428630d23..4c8a77cbe 100644
--- a/test/specs/mount.spec.js
+++ b/test/specs/mount.spec.js
@@ -19,6 +19,7 @@ describeRunIf(process.env.TEST_ENV !== 'node', 'mount', () => {
 
   afterEach(() => {
     window = windowSave // eslint-disable-line no-native-reassign
+    sandbox.reset()
     sandbox.restore()
   })
 
diff --git a/test/specs/mounting-options/mocks.spec.js b/test/specs/mounting-options/mocks.spec.js
index bcd356cc5..e5a1967bf 100644
--- a/test/specs/mounting-options/mocks.spec.js
+++ b/test/specs/mounting-options/mocks.spec.js
@@ -17,6 +17,7 @@ describeWithMountingMethods('options.mocks', mountingMethod => {
 
   afterEach(() => {
     config.mocks = configMocksSave
+    sandbox.reset()
     sandbox.restore()
   })
 
diff --git a/test/specs/mounting-options/scopedSlots.spec.js b/test/specs/mounting-options/scopedSlots.spec.js
index 5e80c9ef8..f48ea462f 100644
--- a/test/specs/mounting-options/scopedSlots.spec.js
+++ b/test/specs/mounting-options/scopedSlots.spec.js
@@ -9,6 +9,7 @@ describeWithShallowAndMount('scopedSlots', mountingMethod => {
 
   afterEach(() => {
     window = windowSave // eslint-disable-line no-native-reassign
+    sandbox.reset()
     sandbox.restore()
   })
 
diff --git a/test/specs/mounting-options/stubs.spec.js b/test/specs/mounting-options/stubs.spec.js
index e1e8138ce..fd6b11613 100644
--- a/test/specs/mounting-options/stubs.spec.js
+++ b/test/specs/mounting-options/stubs.spec.js
@@ -21,6 +21,7 @@ describeWithMountingMethods('options.stub', mountingMethod => {
   })
 
   afterEach(() => {
+    sandbox.reset()
     sandbox.restore()
     config.stubs = configStubsSave
     serverConfig.stubs = serverConfigSave
diff --git a/test/specs/mounting-options/sync.spec.js b/test/specs/mounting-options/sync.spec.js
index b0395caa6..8fdd2bf8f 100644
--- a/test/specs/mounting-options/sync.spec.js
+++ b/test/specs/mounting-options/sync.spec.js
@@ -9,6 +9,7 @@ describeWithShallowAndMount('options.sync', mountingMethod => {
   })
 
   afterEach(() => {
+    sandbox.reset()
     sandbox.restore()
   })
 
diff --git a/test/specs/shallow-mount.spec.js b/test/specs/shallow-mount.spec.js
index e0b5d888c..1e22aad0b 100644
--- a/test/specs/shallow-mount.spec.js
+++ b/test/specs/shallow-mount.spec.js
@@ -19,8 +19,8 @@ describeRunIf(process.env.TEST_ENV !== 'node', 'shallowMount', () => {
   })
 
   afterEach(() => {
-    console.info.restore()
-    console.error.restore()
+    sandbox.reset()
+    sandbox.restore()
   })
 
   it('returns new VueWrapper of Vue localVue if no options are passed', () => {
diff --git a/test/specs/wrapper-array.spec.js b/test/specs/wrapper-array.spec.js
index 45c31ec8b..5933ce299 100644
--- a/test/specs/wrapper-array.spec.js
+++ b/test/specs/wrapper-array.spec.js
@@ -4,7 +4,10 @@ import { describeWithShallowAndMount } from '~resources/utils'
 describeWithShallowAndMount('WrapperArray', mountingMethod => {
   const sandbox = sinon.createSandbox()
 
-  afterEach(sandbox.restore)
+  afterEach(() => {
+    sandbox.reset()
+    sandbox.restore()
+  })
 
   function getWrapperArray(wrappers) {
     if (!wrappers) {
diff --git a/test/specs/wrapper-array/trigger.spec.js b/test/specs/wrapper-array/trigger.spec.js
index f25720f53..81c5ad77f 100644
--- a/test/specs/wrapper-array/trigger.spec.js
+++ b/test/specs/wrapper-array/trigger.spec.js
@@ -5,7 +5,10 @@ import { describeWithShallowAndMount } from '~resources/utils'
 describeWithShallowAndMount('trigger', mountingMethod => {
   const sandbox = sinon.createSandbox()
 
-  afterEach(sandbox.restore)
+  afterEach(() => {
+    sandbox.reset()
+    sandbox.restore()
+  })
 
   it('causes click handler to fire when wrapper.trigger("click") is called on a Component', () => {
     const clickHandler = sandbox.stub()
diff --git a/test/specs/wrapper/destroy.spec.js b/test/specs/wrapper/destroy.spec.js
index 5e2283e4d..a326339db 100644
--- a/test/specs/wrapper/destroy.spec.js
+++ b/test/specs/wrapper/destroy.spec.js
@@ -3,7 +3,10 @@ import { describeWithShallowAndMount } from '~resources/utils'
 describeWithShallowAndMount('destroy', mountingMethod => {
   const sandbox = sinon.createSandbox()
 
-  afterEach(sandbox.restore)
+  afterEach(() => {
+    sandbox.reset()
+    sandbox.restore()
+  })
 
   it('triggers beforeDestroy ', () => {
     const stub = sandbox.stub()
diff --git a/test/specs/wrapper/setData.spec.js b/test/specs/wrapper/setData.spec.js
index ca8ac2f53..2b9919ceb 100644
--- a/test/specs/wrapper/setData.spec.js
+++ b/test/specs/wrapper/setData.spec.js
@@ -11,6 +11,7 @@ describeWithShallowAndMount('setData', mountingMethod => {
   })
 
   afterEach(() => {
+    sandbox.reset()
     sandbox.restore()
   })
 
diff --git a/test/specs/wrapper/setProps.spec.js b/test/specs/wrapper/setProps.spec.js
index e3ed38923..ba1a79946 100644
--- a/test/specs/wrapper/setProps.spec.js
+++ b/test/specs/wrapper/setProps.spec.js
@@ -11,6 +11,7 @@ describeWithShallowAndMount('setProps', mountingMethod => {
   })
 
   afterEach(() => {
+    sandbox.reset()
     sandbox.restore()
   })
 
diff --git a/test/specs/wrapper/trigger.spec.js b/test/specs/wrapper/trigger.spec.js
index 9406fc967..1fc3b8771 100644
--- a/test/specs/wrapper/trigger.spec.js
+++ b/test/specs/wrapper/trigger.spec.js
@@ -12,6 +12,7 @@ describeWithShallowAndMount('trigger', mountingMethod => {
   const sandbox = sinon.createSandbox()
 
   afterEach(() => {
+    sandbox.reset()
     sandbox.restore()
   })