-
Notifications
You must be signed in to change notification settings - Fork 668
jsdom documentation removed? and stale link #1774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi! Thank you for your comment 🙌 We decided not to maintain docs for a broader set of tools because it is hard to keep it up to date. See #1610 (comment) That being said, it is true that comment from the mentioned test should be updated. Fancy to fix it? 😄 |
Thanks for a great project. I've come across the same thing that @Cobertos mentioned. When I run my
Just to clarify, @afontcu mentioned the comment from the test needs updating. I might have misunderstood (probably) the message is printed out by |
This is in a codebase that was previously working fine with |
In my case, after upgrading node.js packages and getting this issue, the fix for me was to add this to my testEnvironment: 'jsdom' |
@simondean is it possible that you bumped Jest to v27? |
@afontcu just check and yep I’ve bumped Jest to v27 |
Then that must be it – Jest v27 flipped defaults for the test environment from "jsdom" to "node": https://jestjs.io/blog/2021/05/25/jest-27#flipping-defaults |
Documentation Feedback
Seems like the docs have been updated and there's no more examples on how to use this library with jsdom or alternative DOM implementation? It would be nice if that could be added back.
The link in warn-if-no-window.js is also out of date and points to nowhere.
Looks like it was some changes from this commit. Installation does not mention anything about how to install or use jsdom/jsdom-global
The text was updated successfully, but these errors were encountered: