-
Notifications
You must be signed in to change notification settings - Fork 668
Missing decpration warning for wrapper.contains() from documentaion #1582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Just noticed that there is a deprecation warning on the 'wrapper.find' document (https://vue-test-utils.vuejs.org/api/wrapper/#find), which would obviously preclude that method from being part of this deprecation warning. |
Hi! You're right, we're missing a deprecation warning on docs. Fancy to open up a PR? :) |
Sure, I can do that. |
Hi @SmilingJoe! Did you have the chance to take a look at this? :) |
Fixed in #1612! |
What problem does this feature solve?
Recently upgraded @vue/test-utils from 1.0.0-beta.31 to 1.0.2. Upon running our unit tests, received the following error:
ERROR: '[vue-test-utils]: contains is deprecated and will be removed in the next major version Use
wrapper.find
,wrapper.findComponent
orwrapper.get
instead'Noticed that there is no warning of this deprecation specified in the API Wrapper documentation:
https://vue-test-utils.vuejs.org/api/wrapper/#contains
Providing this deprecation warning, along with a specific replacement example, in the documentation will save time for developers.
What does the proposed API look like?
Propose adding the following deprecation warning to the top of relevant API Wrapper "contains" document:
The text was updated successfully, but these errors were encountered: