Skip to content

(docs)Update links to "get" #1420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
novellac opened this issue Jan 28, 2020 · 4 comments
Closed

(docs)Update links to "get" #1420

novellac opened this issue Jan 28, 2020 · 4 comments

Comments

@novellac
Copy link

novellac commented Jan 28, 2020

Version

1.0.0-beta.31

Reproduction link

https://vue-test-utils.vuejs.org/api/wrapper/find.html

Steps to reproduce

  • Scroll to the bottom of the page
  • Click on the link "get" in the sentence "See also: get."

What is expected?

Clicking on the link will lead to a 404.

What is actually happening?

"https://vue-test-utils.vuejs.org/api/get.html" cant' be found, and there is no redirect.


The absolute URL of the correct link could be either: https://vue-test-utils.vuejs.org/api/wrapper/#get OR https://vue-test-utils.vuejs.org/api/wrapper/get.html

@novellac novellac changed the title Update link (docs)Update link Jan 28, 2020
@novellac novellac changed the title (docs)Update link (docs)Update links to "get" Jan 28, 2020
@dobromir-hristov
Copy link
Contributor

Want to make a PR?

@novellac
Copy link
Author

Yep, I will try to get the docs site spun up on my local and have a go at a PR. Is there a preference between /api/wrapper/#get and /api/wrapper/get.html ?

@afontcu
Copy link
Member

afontcu commented Jan 28, 2020

Hi! I'd go with https://vue-test-utils.vuejs.org/api/wrapper/get.html since the other "See also" link points to the .html file.

Thanks for this! :)

@dobromir-hristov
Copy link
Contributor

Hey. I updated the links, had some weird caching bugs, but got them sorted.

Thanks @novellac for finding this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants