refactor: remove unnecessary processing (#538)

38elements · eddyerburgh · commit f3d4086c5f10 · 2018-04-18T07:23:59.000+02:00
diff --git a/packages/shared/validators.js b/packages/shared/validators.js
@@ -46,13 +46,11 @@ export function componentNeedsCompiling (component: Component) {
 }
 
 export function isRefSelector (refOptionsObject: any) {
-  if (typeof refOptionsObject !== 'object' || !Object.keys(refOptionsObject || {}).length) {
+  if (typeof refOptionsObject !== 'object' || Object.keys(refOptionsObject || {}).length !== 1) {
     return false
   }
 
-  return Object
-    .keys(refOptionsObject)
-    .every(key => ['ref'].includes(key) && typeof refOptionsObject[key] === 'string')
+  return typeof refOptionsObject.ref === 'string'
 }
 
 export function isNameSelector (nameOptionsObject: any) {

Original file line number	Diff line number	Diff line change
`@@ -46,13 +46,11 @@ export function componentNeedsCompiling (component: Component) {`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`export function isRefSelector (refOptionsObject: any) {`
`49`		`- if (typeof refOptionsObject !== 'object' \|\| !Object.keys(refOptionsObject \|\| {}).length) {`
	`49`	`+ if (typeof refOptionsObject !== 'object' \|\| Object.keys(refOptionsObject \|\| {}).length !== 1) {`
`50`	`50`	`return false`
`51`	`51`	`}`
`52`	`52`
`53`		`- return Object`
`54`		`- .keys(refOptionsObject)`
`55`		`- .every(key => ['ref'].includes(key) && typeof refOptionsObject[key] === 'string')`
	`53`	`+ return typeof refOptionsObject.ref === 'string'`
`56`	`54`	`}`
`57`	`55`
`58`	`56`	`export function isNameSelector (nameOptionsObject: any) {`