Skip to content

Commit 6fa6e06

Browse files
Nick Gravelyneddyerburgh
Nick Gravelyn
authored andcommitted
fix: add-attrs and add-listeners correctly restore silent config option (#428)
1 parent 3cffbab commit 6fa6e06

File tree

4 files changed

+24
-4
lines changed

4 files changed

+24
-4
lines changed

src/lib/add-attrs.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import Vue from 'vue'
22

33
export default function addAttrs (vm, attrs) {
4-
const originalVueConfig = Vue.config
4+
const originalSilent = Vue.config.silent
55
Vue.config.silent = true
66
if (attrs) {
77
vm.$attrs = attrs
88
} else {
99
vm.$attrs = {}
1010
}
11-
Vue.config.silent = originalVueConfig.silent
11+
Vue.config.silent = originalSilent
1212
}

src/lib/add-listeners.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import Vue from 'vue'
22

33
export default function addListeners (vm, listeners) {
4-
const originalVueConfig = Vue.config
4+
const originalSilent = Vue.config.silent
55
Vue.config.silent = true
66
if (listeners) {
77
vm.$listeners = listeners
88
} else {
99
vm.$listeners = {}
1010
}
11-
Vue.config.silent = originalVueConfig.silent
11+
Vue.config.silent = originalSilent
1212
}

test/specs/add-attrs.spec.js

+10
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
import Vue from 'vue'
2+
import addAttrs from '~src/lib/add-attrs'
3+
4+
describe('add-attrs', () => {
5+
it('restores silent config value to original value', () => {
6+
Vue.config.silent = false
7+
addAttrs({}, {})
8+
expect(Vue.config.silent).to.be.false
9+
})
10+
})

test/specs/add-listeners.spec.js

+10
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
import Vue from 'vue'
2+
import addListeners from '~src/lib/add-listeners'
3+
4+
describe('add-listeners', () => {
5+
it('restores silent config value to original value', () => {
6+
Vue.config.silent = false
7+
addListeners({}, {})
8+
expect(Vue.config.silent).to.be.false
9+
})
10+
})

0 commit comments

Comments
 (0)